mirror of
https://github.com/TryGhost/Ghost.git
synced 2024-12-22 10:21:36 +03:00
c6a95c6478
no issue - this commit cleans up the usages of `include` and `withRelated`. ### API layer (`include`) - as request parameter e.g. `?include=roles,tags` - as theme API parameter e.g. `{{get .... include="author"}}` - as internal API access e.g. `api.posts.browse({include: 'author,tags'})` - the `include` notation is more readable than `withRelated` - and it allows us to use a different easier format (comma separated list) - the API utility transforms these more readable properties into model style (or into Ghost style) ### Model access (`withRelated`) - e.g. `models.Post.findPage({withRelated: ['tags']})` - driven by bookshelf --- Commits explained. * Reorder the usage of `convertOptions` - 1. validation - 2. options convertion - 3. permissions - the reason is simple, the permission layer access the model layer - we have to prepare the options before talking to the model layer - added `convertOptions` where it was missed (not required, but for consistency reasons) * Use `withRelated` when accessing the model layer and use `include` when accessing the API layer * Change `convertOptions` API utiliy - API Usage - ghost.api(..., {include: 'tags,authors'}) - `include` should only be used when calling the API (either via request or via manual usage) - `include` is only for readability and easier format - Ghost (Model Layer Usage) - models.Post.findOne(..., {withRelated: ['tags', 'authors']}) - should only use `withRelated` - model layer cannot read 'tags,authors` - model layer has no idea what `include` means, speaks a different language - `withRelated` is bookshelf - internal usage * include-count plugin: use `withRelated` instead of `include` - imagine you outsource this plugin to git and publish it to npm - `include` is an unknown option in bookshelf * Updated `permittedOptions` in base model - `include` is no longer a known option * Remove all occurances of `include` in the model layer * Extend `filterOptions` base function - this function should be called as first action - we clone the unfiltered options - check if you are using `include` (this is a protection which could help us in the beginning) - check for permitted and (later on default `withRelated`) options - the usage is coming in next commit * Ensure we call `filterOptions` as first action - use `ghostBookshelf.Model.filterOptions` as first action - consistent naming pattern for incoming options: `unfilteredOptions` - re-added allowed options for `toJSON` - one unsolved architecture problem: - if you override a function e.g. `edit` - then you should call `filterOptions` as first action - the base implementation of e.g. `edit` will call it again - future improvement * Removed `findOne` from Invite model - no longer needed, the base implementation is the same
360 lines
12 KiB
JavaScript
360 lines
12 KiB
JavaScript
// # Tag API
|
|
// RESTful API for the Tag resource
|
|
var Promise = require('bluebird'),
|
|
_ = require('lodash'),
|
|
fs = require('fs-extra'),
|
|
pipeline = require('../lib/promise/pipeline'),
|
|
fsLib = require('../lib/fs'),
|
|
localUtils = require('./utils'),
|
|
models = require('../models'),
|
|
common = require('../lib/common'),
|
|
docName = 'subscribers',
|
|
subscribers;
|
|
|
|
/**
|
|
* ### Subscribers API Methods
|
|
*
|
|
* **See:** [API Methods](constants.js.html#api%20methods)
|
|
*/
|
|
subscribers = {
|
|
/**
|
|
* ## Browse
|
|
* @param {{context}} options
|
|
* @returns {Promise<Subscriber>} Subscriber Collection
|
|
*/
|
|
browse: function browse(options) {
|
|
var tasks;
|
|
|
|
/**
|
|
* ### Model Query
|
|
* Make the call to the Model layer
|
|
* @param {Object} options
|
|
* @returns {Object} options
|
|
*/
|
|
function doQuery(options) {
|
|
return models.Subscriber.findPage(options);
|
|
}
|
|
|
|
// Push all of our tasks into a `tasks` array in the correct order
|
|
tasks = [
|
|
localUtils.validate(docName, {opts: localUtils.browseDefaultOptions}),
|
|
localUtils.convertOptions(),
|
|
localUtils.handlePermissions(docName, 'browse'),
|
|
doQuery
|
|
];
|
|
|
|
// Pipeline calls each task passing the result of one to be the arguments for the next
|
|
return pipeline(tasks, options);
|
|
},
|
|
|
|
/**
|
|
* ## Read
|
|
* @param {{id}} options
|
|
* @return {Promise<Subscriber>} Subscriber
|
|
*/
|
|
read: function read(options) {
|
|
var attrs = ['id', 'email'],
|
|
tasks;
|
|
|
|
/**
|
|
* ### Model Query
|
|
* Make the call to the Model layer
|
|
* @param {Object} options
|
|
* @returns {Object} options
|
|
*/
|
|
function doQuery(options) {
|
|
return models.Subscriber.findOne(options.data, _.omit(options, ['data']))
|
|
.then(function onModelResponse(model) {
|
|
if (!model) {
|
|
return Promise.reject(new common.errors.NotFoundError({
|
|
message: common.i18n.t('errors.api.subscribers.subscriberNotFound')
|
|
}));
|
|
}
|
|
|
|
return {
|
|
subscribers: [model.toJSON(options)]
|
|
};
|
|
});
|
|
}
|
|
|
|
// Push all of our tasks into a `tasks` array in the correct order
|
|
tasks = [
|
|
localUtils.validate(docName, {attrs: attrs}),
|
|
localUtils.convertOptions(),
|
|
localUtils.handlePermissions(docName, 'read'),
|
|
doQuery
|
|
];
|
|
|
|
// Pipeline calls each task passing the result of one to be the arguments for the next
|
|
return pipeline(tasks, options);
|
|
},
|
|
|
|
/**
|
|
* ## Add
|
|
* @param {Subscriber} object the subscriber to create
|
|
* @returns {Promise(Subscriber)} Newly created Subscriber
|
|
*/
|
|
add: function add(object, options) {
|
|
var tasks;
|
|
|
|
/**
|
|
* ### Model Query
|
|
* Make the call to the Model layer
|
|
* @param {Object} options
|
|
* @returns {Object} options
|
|
*/
|
|
function doQuery(options) {
|
|
return models.Subscriber.getByEmail(options.data.subscribers[0].email)
|
|
.then(function (subscriber) {
|
|
if (subscriber && options.context.external) {
|
|
// we don't expose this information
|
|
return Promise.resolve(subscriber);
|
|
} else if (subscriber) {
|
|
return Promise.reject(new common.errors.ValidationError({message: common.i18n.t('errors.api.subscribers.subscriberAlreadyExists')}));
|
|
}
|
|
|
|
return models.Subscriber.add(options.data.subscribers[0], _.omit(options, ['data'])).catch(function (error) {
|
|
if (error.code && error.message.toLowerCase().indexOf('unique') !== -1) {
|
|
return Promise.reject(new common.errors.ValidationError({message: common.i18n.t('errors.api.subscribers.subscriberAlreadyExists')}));
|
|
}
|
|
|
|
return Promise.reject(error);
|
|
});
|
|
})
|
|
.then(function onModelResponse(model) {
|
|
return {
|
|
subscribers: [model.toJSON(options)]
|
|
};
|
|
});
|
|
}
|
|
|
|
// Push all of our tasks into a `tasks` array in the correct order
|
|
tasks = [
|
|
localUtils.validate(docName),
|
|
localUtils.convertOptions(),
|
|
localUtils.handlePermissions(docName, 'add'),
|
|
doQuery
|
|
];
|
|
|
|
// Pipeline calls each task passing the result of one to be the arguments for the next
|
|
return pipeline(tasks, object, options);
|
|
},
|
|
|
|
/**
|
|
* ## Edit
|
|
*
|
|
* @public
|
|
* @param {Subscriber} object Subscriber or specific properties to update
|
|
* @param {{id, context, include}} options
|
|
* @return {Promise<Subscriber>} Edited Subscriber
|
|
*/
|
|
edit: function edit(object, options) {
|
|
var tasks;
|
|
|
|
/**
|
|
* Make the call to the Model layer
|
|
* @param {Object} options
|
|
* @returns {Object} options
|
|
*/
|
|
function doQuery(options) {
|
|
return models.Subscriber.edit(options.data.subscribers[0], _.omit(options, ['data']))
|
|
.then(function onModelResponse(model) {
|
|
if (!model) {
|
|
return Promise.reject(new common.errors.NotFoundError({
|
|
message: common.i18n.t('errors.api.subscribers.subscriberNotFound')
|
|
}));
|
|
}
|
|
|
|
return {
|
|
subscribers: [model.toJSON(options)]
|
|
};
|
|
});
|
|
}
|
|
|
|
// Push all of our tasks into a `tasks` array in the correct order
|
|
tasks = [
|
|
localUtils.validate(docName, {opts: localUtils.idDefaultOptions}),
|
|
localUtils.convertOptions(),
|
|
localUtils.handlePermissions(docName, 'edit'),
|
|
doQuery
|
|
];
|
|
|
|
// Pipeline calls each task passing the result of one to be the arguments for the next
|
|
return pipeline(tasks, object, options);
|
|
},
|
|
|
|
/**
|
|
* ## Destroy
|
|
*
|
|
* @public
|
|
* @param {{id, context}} options
|
|
* @return {Promise}
|
|
*/
|
|
destroy: function destroy(options) {
|
|
var tasks;
|
|
|
|
/**
|
|
* ### Delete Subscriber
|
|
* If we have an email param, check the subscriber exists
|
|
* @type {[type]}
|
|
*/
|
|
function getSubscriberByEmail(options) {
|
|
if (options.email) {
|
|
return models.Subscriber.getByEmail(options.email, options)
|
|
.then(function (subscriber) {
|
|
if (!subscriber) {
|
|
return Promise.reject(new common.errors.NotFoundError({
|
|
message: common.i18n.t('errors.api.subscribers.subscriberNotFound')
|
|
}));
|
|
}
|
|
|
|
options.id = subscriber.get('id');
|
|
return options;
|
|
});
|
|
}
|
|
|
|
return options;
|
|
}
|
|
|
|
/**
|
|
* ### Delete Subscriber
|
|
* Make the call to the Model layer
|
|
* @param {Object} options
|
|
*/
|
|
function doQuery(options) {
|
|
return models.Subscriber.destroy(options).return(null);
|
|
}
|
|
|
|
// Push all of our tasks into a `tasks` array in the correct order
|
|
tasks = [
|
|
localUtils.validate(docName, {opts: ['id', 'email']}),
|
|
localUtils.convertOptions(),
|
|
localUtils.handlePermissions(docName, 'destroy'),
|
|
getSubscriberByEmail,
|
|
doQuery
|
|
];
|
|
|
|
// Pipeline calls each task passing the result of one to be the arguments for the next
|
|
return pipeline(tasks, options);
|
|
},
|
|
|
|
/**
|
|
* ### Export Subscribers
|
|
* Generate the CSV to export
|
|
*
|
|
* @public
|
|
* @param {{context}} options
|
|
* @returns {Promise} Ghost Export CSV format
|
|
*/
|
|
exportCSV: function exportCSV(options) {
|
|
var tasks = [];
|
|
|
|
options = options || {};
|
|
|
|
function formatCSV(data) {
|
|
var fields = ['id', 'email', 'created_at', 'deleted_at'],
|
|
csv = fields.join(',') + '\r\n',
|
|
subscriber,
|
|
field,
|
|
j,
|
|
i;
|
|
|
|
for (j = 0; j < data.length; j = j + 1) {
|
|
subscriber = data[j];
|
|
|
|
for (i = 0; i < fields.length; i = i + 1) {
|
|
field = fields[i];
|
|
csv += subscriber[field] !== null ? subscriber[field] : '';
|
|
if (i !== fields.length - 1) {
|
|
csv += ',';
|
|
}
|
|
}
|
|
csv += '\r\n';
|
|
}
|
|
return csv;
|
|
}
|
|
|
|
// Export data, otherwise send error 500
|
|
function exportSubscribers() {
|
|
return models.Subscriber.findAll(options).then(function (data) {
|
|
return formatCSV(data.toJSON(options));
|
|
}).catch(function (err) {
|
|
return Promise.reject(new common.errors.GhostError({err: err}));
|
|
});
|
|
}
|
|
|
|
tasks = [
|
|
localUtils.convertOptions(),
|
|
localUtils.handlePermissions(docName, 'browse'),
|
|
exportSubscribers
|
|
];
|
|
|
|
return pipeline(tasks, options);
|
|
},
|
|
|
|
/**
|
|
* ### Import CSV
|
|
* Import subscribers from a CSV file
|
|
*
|
|
* @public
|
|
* @param {{context}} options
|
|
* @returns {Promise} Success
|
|
*/
|
|
importCSV: function (options) {
|
|
var tasks = [];
|
|
options = options || {};
|
|
|
|
function importCSV(options) {
|
|
var filePath = options.path,
|
|
fulfilled = 0,
|
|
invalid = 0,
|
|
duplicates = 0;
|
|
|
|
return fsLib.readCSV({
|
|
path: filePath,
|
|
columnsToExtract: [{name: 'email', lookup: /email/i}]
|
|
}).then(function (result) {
|
|
return Promise.all(result.map(function (entry) {
|
|
return subscribers.add(
|
|
{subscribers: [{email: entry.email}]},
|
|
{context: options.context}
|
|
).reflect();
|
|
})).each(function (inspection) {
|
|
if (inspection.isFulfilled()) {
|
|
fulfilled = fulfilled + 1;
|
|
} else {
|
|
if (inspection.reason() instanceof common.errors.ValidationError) {
|
|
duplicates = duplicates + 1;
|
|
} else {
|
|
invalid = invalid + 1;
|
|
}
|
|
}
|
|
});
|
|
}).then(function () {
|
|
return {
|
|
meta: {
|
|
stats: {
|
|
imported: fulfilled,
|
|
duplicates: duplicates,
|
|
invalid: invalid
|
|
}
|
|
}
|
|
};
|
|
}).finally(function () {
|
|
// Remove uploaded file from tmp location
|
|
return fs.unlink(filePath);
|
|
});
|
|
}
|
|
|
|
tasks = [
|
|
localUtils.convertOptions(),
|
|
localUtils.handlePermissions(docName, 'add'),
|
|
importCSV
|
|
];
|
|
|
|
return pipeline(tasks, options);
|
|
}
|
|
};
|
|
|
|
module.exports = subscribers;
|