Ghost/test/e2e-api/admin/products.test.js
Simon Backx 9ad45ee5be
Added tests for creating product benefits without name (#14217)
refs https://github.com/TryGhost/Team/issues/1188

The products API did return a 500 error when you tried to store product benefits with an empty name. This should throw a 422 Validation Error instead. This change includes some tests for this error. The error itself has been solved by updating the bookshelf-relations dependency earlier.

- Added test when creating a new product with an empty benefit name
- Added test when updating an existing product with new benefits, with an empty name
- Added a test that creates a tier with benefits
2022-03-10 10:10:35 +01:00

132 lines
3.3 KiB
JavaScript

const should = require('should');
const sinon = require('sinon');
const {agentProvider, fixtureManager, mockManager} = require('../../utils/e2e-framework');
describe('Tiers API', function () {
let agent;
before(async function () {
agent = await agentProvider.getAdminAPIAgent();
await fixtureManager.init('members');
await agent.loginAsOwner();
});
beforeEach(function () {
mockManager.mockLabsDisabled('multipleProducts');
const stripeService = require('../../../core/server/services/stripe');
stripeService.api._configured = true;
mockManager.mockStripe();
sinon
.stub(stripeService.api, 'createProduct')
.resolves({
id: 'prod_LFPlH9BDDwXcZ1'
});
sinon
.stub(stripeService.api, 'createPrice')
.resolves({
id: 'price_1KYpK92eZvKYlo2C86IrYSPM',
currency: 'usd',
nickname: null,
unit_amount: 299
});
});
afterEach(function () {
mockManager.restore();
const stripeService = require('../../../core/server/services/stripe');
stripeService.api._configured = false;
});
it('Errors when price is non-integer', async function () {
const tier = {
name: 'Blah',
monthly_price: {
amount: 99.99
}
};
await agent
.post('/products/')
.body({products: [tier]})
.expectStatus(422);
});
it('Errors when price is negative', async function () {
const tier = {
name: 'Blah',
monthly_price: {
amount: -100
}
};
await agent
.post('/products/')
.body({products: [tier]})
.expectStatus(422);
});
it('Errors when price is too large', async function () {
const tier = {
name: 'Blah',
monthly_price: {
amount: Number.MAX_SAFE_INTEGER
}
};
await agent
.post('/products/')
.body({products: [tier]})
.expectStatus(422);
});
it('Create a new tier with benefits', async function () {
const tier = {
name: 'Blah',
monthly_price: {
amount: 10
},
benefits: [{
name: 'This is a benefit'
}]
};
await agent
.post('/products/')
.body({products: [tier]})
.expectStatus(201);
});
it('Errors when a benefit has an empty name', async function () {
const tier = {
name: 'Blah',
monthly_price: {
amount: 10
},
benefits: [{
name: ''
}]
};
await agent
.post('/products/')
.body({products: [tier]})
.expectStatus(422);
});
it('Errors when a product is edited with a benefit that has an empty name', async function () {
const tier = {
benefits: [{
name: ''
}]
};
await agent
.put('/products/' + fixtureManager.get('products', 0).id)
.body({products: [tier]})
.expectStatus(422);
});
});