mirror of
https://github.com/TryGhost/Ghost.git
synced 2024-12-25 03:44:29 +03:00
6161f94910
refs: https://github.com/TryGhost/Toolbox/issues/595 We're rolling out new rules around the node assert library, the first of which is enforcing the use of assert/strict. This means we don't need to use the strict version of methods, as the standard version will work that way by default. This caught some gotchas in our existing usage of assert where the lack of strict mode had unexpected results: - Url matching needs to be done on `url.href` seeaa58b354a4
- Null and undefined are not the same thing, there were a few cases of this being confused - Particularly questionable changes in [PostExporter tests](c1a468744b
) tracked [here](https://github.com/TryGhost/Team/issues/3505). - A typo seeeaac9c293a
Moving forward, using assert strict should help us to catch unexpected behaviour, particularly around nulls and undefineds during implementation.
151 lines
5.3 KiB
JavaScript
151 lines
5.3 KiB
JavaScript
const assert = require('assert/strict');
|
|
const ObjectID = require('bson-objectid');
|
|
const Mention = require('../lib/Mention');
|
|
|
|
const validInput = {
|
|
source: 'https://source.com',
|
|
target: 'https://target.com',
|
|
sourceTitle: 'Title!',
|
|
sourceExcerpt: 'Excerpt!'
|
|
};
|
|
|
|
describe('Mention', function () {
|
|
describe('toJSON', function () {
|
|
it('Returns a object with the expected properties', async function () {
|
|
const mention = await Mention.create(validInput);
|
|
const actual = Object.keys(mention.toJSON());
|
|
const expected = [
|
|
'id',
|
|
'source',
|
|
'target',
|
|
'timestamp',
|
|
'payload',
|
|
'resourceId',
|
|
'resourceType',
|
|
'sourceTitle',
|
|
'sourceSiteTitle',
|
|
'sourceAuthor',
|
|
'sourceExcerpt',
|
|
'sourceFavicon',
|
|
'sourceFeaturedImage',
|
|
'verified'
|
|
];
|
|
assert.deepEqual(actual, expected);
|
|
});
|
|
});
|
|
|
|
describe('verify', function () {
|
|
it('Does basic check for the target URL and updates verified property', async function () {
|
|
const mention = await Mention.create(validInput);
|
|
assert(!mention.verified);
|
|
|
|
mention.verify('<a href="https://target.com/">');
|
|
assert(mention.verified);
|
|
|
|
mention.verify('<a href="https://not-da-target.com">');
|
|
assert(!mention.verified);
|
|
});
|
|
it('Does check for Image targets', async function () {
|
|
const mention = await Mention.create({
|
|
...validInput,
|
|
target: 'https://target.com/image.jpg'
|
|
});
|
|
assert(!mention.verified);
|
|
|
|
mention.verify('<img src="https://target.com/image.jpg">');
|
|
assert(mention.verified);
|
|
|
|
mention.verify('<img src="https://not-da-target.com/image.jpg">');
|
|
assert(!mention.verified);
|
|
});
|
|
it('Does check for Video targets', async function () {
|
|
const mention = await Mention.create({
|
|
...validInput,
|
|
target: 'https://target.com/video.mp4'
|
|
});
|
|
assert(!mention.verified);
|
|
|
|
mention.verify('<video src="https://target.com/video.mp4">');
|
|
assert(mention.verified);
|
|
|
|
mention.verify('<video src="https://not-da-target.com/video.mp4">');
|
|
assert(!mention.verified);
|
|
});
|
|
});
|
|
|
|
describe('create', function () {
|
|
it('Will error with invalid inputs', async function () {
|
|
const invalidInputs = [
|
|
{id: 'Not valid ID'},
|
|
{id: 123},
|
|
{source: 'Not a valid source'},
|
|
{target: 'Not a valid target'},
|
|
{timestamp: 'Not a valid timestamp'},
|
|
{resourceId: 'Invalid resourceId'},
|
|
{sourceTitle: 123},
|
|
{sourceExcerpt: 123},
|
|
{sourceFavicon: 'Invalid source favicon'},
|
|
{sourceFeaturedImage: 'Invalid source featured image'}
|
|
];
|
|
|
|
for (const invalidInput of invalidInputs) {
|
|
let errored = false;
|
|
try {
|
|
await Mention.create({
|
|
...validInput,
|
|
...invalidInput
|
|
});
|
|
} catch (err) {
|
|
errored = true;
|
|
} finally {
|
|
if (!errored) {
|
|
assert.fail(`Should have errored with invalid input ${JSON.stringify(invalidInput)}`);
|
|
}
|
|
}
|
|
}
|
|
});
|
|
|
|
it('Will not error with valid inputs', async function () {
|
|
const validInputs = [
|
|
{id: new ObjectID()},
|
|
{source: new URL('https://source.com/')},
|
|
{target: new URL('https://target.com/')},
|
|
{timestamp: new Date()},
|
|
{timestamp: '2023-01-01T00:00:00Z'},
|
|
{payload: {extra: 'shit'}},
|
|
{resourceId: new ObjectID()},
|
|
{sourceFavicon: 'https://source.com/favicon.ico'},
|
|
{sourceFavicon: new URL('https://source.com/favicon.ico')},
|
|
{sourceFeaturedImage: 'https://source.com/assets/image.jpg'},
|
|
{sourceFeaturedImage: new URL('https://source.com/assets/image.jpg')}
|
|
];
|
|
|
|
for (const localValidInput of validInputs) {
|
|
await Mention.create({
|
|
...validInput,
|
|
...localValidInput
|
|
});
|
|
}
|
|
});
|
|
|
|
it('Will trim titles which are too long', async function () {
|
|
const mention = await Mention.create({
|
|
...validInput,
|
|
sourceTitle: Array.from({length: 3000}).join('A')
|
|
});
|
|
|
|
assert(mention.sourceTitle.length === 2000);
|
|
});
|
|
|
|
it('Will default the title to the host of the source URL if missing', async function () {
|
|
const mention = await Mention.create({
|
|
...validInput,
|
|
sourceTitle: null
|
|
});
|
|
|
|
assert(mention.sourceTitle);
|
|
assert(mention.sourceTitle === 'source.com');
|
|
});
|
|
});
|
|
});
|