TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-12-25 03:44:29 +03:00
Code Issues Projects Releases Wiki Activity
c1cd18b526
Ghost/ghost
History
Hannah Wolfe 6161f94910
Updated to use assert/strict everywhere (#17047) 
refs: https://github.com/TryGhost/Toolbox/issues/595

We're rolling out new rules around the node assert library, the first of which is enforcing the use of assert/strict. This means we don't need to use the strict version of methods, as the standard version will work that way by default.

This caught some gotchas in our existing usage of assert where the lack of strict mode had unexpected results:
- Url matching needs to be done on `url.href` see aa58b354a4
- Null and undefined are not the same thing,  there were a few cases of this being confused
- Particularly questionable changes in [PostExporter tests](c1a468744b) tracked [here](https://github.com/TryGhost/Team/issues/3505).
- A typo see eaac9c293a

Moving forward, using assert strict should help us to catch unexpected behaviour, particularly around nulls and undefineds during implementation.
2023-06-21 09:56:59 +01:00
..
adapter-cache-memory-ttl Updated to use assert/strict everywhere (#17047) 2023-06-21 09:56:59 +01:00
adapter-cache-redis Updated to use assert/strict everywhere (#17047) 2023-06-21 09:56:59 +01:00
adapter-manager Added consistent linting pattern to all packages 2023-06-13 10:43:29 +01:00
admin Merged v5.52.2 into main 2023-06-21 03:32:58 +00:00
admin-x-settings Updated to use assert/strict everywhere (#17047) 2023-06-21 09:56:59 +01:00
announcement-bar-settings Updated to use assert/strict everywhere (#17047) 2023-06-21 09:56:59 +01:00
api-framework ✨ Implemented duplicate post functionality (#16767) 2023-05-15 09:30:32 +01:00
api-version-compatibility-service Updated to use assert/strict everywhere (#17047) 2023-06-21 09:56:59 +01:00
audience-feedback Updated to use assert/strict everywhere (#17047) 2023-06-21 09:56:59 +01:00
bootstrap-socket Added consistent linting pattern to all packages 2023-06-13 10:43:29 +01:00
collections Added "getBySlug" method to Collections Service 2023-06-16 16:31:50 +07:00
constants Added consistent linting pattern to all packages 2023-06-13 10:43:29 +01:00
core Updated to use assert/strict everywhere (#17047) 2023-06-21 09:56:59 +01:00
custom-theme-settings-service Added consistent linting pattern to all packages 2023-06-13 10:43:29 +01:00
data-generator Added eslint rule for file naming convention 2023-05-09 12:34:34 -04:00
domain-events Updated to use assert/strict everywhere (#17047) 2023-06-21 09:56:59 +01:00
dynamic-routing-events Updated to use assert/strict everywhere (#17047) 2023-06-21 09:56:59 +01:00
email-analytics-provider-mailgun Added consistent linting pattern to all packages 2023-06-13 10:43:29 +01:00
email-analytics-service Added consistent linting pattern to all packages 2023-06-13 10:43:29 +01:00
email-content-generator Updated to use assert/strict everywhere (#17047) 2023-06-21 09:56:59 +01:00
email-events Updated to use assert/strict everywhere (#17047) 2023-06-21 09:56:59 +01:00
email-service Updated to use assert/strict everywhere (#17047) 2023-06-21 09:56:59 +01:00
email-suppression-list Updated to use assert/strict everywhere (#17047) 2023-06-21 09:56:59 +01:00
event-aware-cache-wrapper Updated to use assert/strict everywhere (#17047) 2023-06-21 09:56:59 +01:00
express-dynamic-redirects Added consistent linting pattern to all packages 2023-06-13 10:43:29 +01:00
external-media-inliner Updated to use assert/strict everywhere (#17047) 2023-06-21 09:56:59 +01:00
extract-api-key Updated to use assert/strict everywhere (#17047) 2023-06-21 09:56:59 +01:00
html-to-plaintext Updated to use assert/strict everywhere (#17047) 2023-06-21 09:56:59 +01:00
i18n Updated to use assert/strict everywhere (#17047) 2023-06-21 09:56:59 +01:00
importer-handler-content-files Updated to use assert/strict everywhere (#17047) 2023-06-21 09:56:59 +01:00
importer-revue Updated to use assert/strict everywhere (#17047) 2023-06-21 09:56:59 +01:00
in-memory-repository Added "getBySlug" method to Collections Service 2023-06-16 16:31:50 +07:00
job-manager Updated to use assert/strict everywhere (#17047) 2023-06-21 09:56:59 +01:00
link-redirects Updated to use assert/strict everywhere (#17047) 2023-06-21 09:56:59 +01:00
link-replacer Updated to use assert/strict everywhere (#17047) 2023-06-21 09:56:59 +01:00
link-tracking Updated to use assert/strict everywhere (#17047) 2023-06-21 09:56:59 +01:00
magic-link Updated to use assert/strict everywhere (#17047) 2023-06-21 09:56:59 +01:00
mailgun-client Updated to use assert/strict everywhere (#17047) 2023-06-21 09:56:59 +01:00
member-attribution Updated to use assert/strict everywhere (#17047) 2023-06-21 09:56:59 +01:00
member-events Added consistent linting pattern to all packages 2023-06-13 10:43:29 +01:00
members-api Updated to use assert/strict everywhere (#17047) 2023-06-21 09:56:59 +01:00
members-csv Updated to use assert/strict everywhere (#17047) 2023-06-21 09:56:59 +01:00
members-events-service Updated to use assert/strict everywhere (#17047) 2023-06-21 09:56:59 +01:00
members-importer Updated to use assert/strict everywhere (#17047) 2023-06-21 09:56:59 +01:00
members-ssr Added consistent linting pattern to all packages 2023-06-13 10:43:29 +01:00
mentions-email-report Update Test & linting packages 2023-04-05 15:16:08 +02:00
milestones Updated to use assert/strict everywhere (#17047) 2023-06-21 09:56:59 +01:00
minifier Added consistent linting pattern to all packages 2023-06-13 10:43:29 +01:00
mw-api-version-mismatch Updated to use assert/strict everywhere (#17047) 2023-06-21 09:56:59 +01:00
mw-cache-control Update Test & linting packages 2023-04-05 15:16:08 +02:00
mw-error-handler Updated to use assert/strict everywhere (#17047) 2023-06-21 09:56:59 +01:00
mw-session-from-token Added consistent linting pattern to all packages 2023-06-13 10:43:29 +01:00
mw-update-user-last-seen Added consistent linting pattern to all packages 2023-06-13 10:43:29 +01:00
mw-version-match Update dependency semver to v7.5.2 2023-06-16 09:56:57 +02:00
mw-vhost Updated to use assert/strict everywhere (#17047) 2023-06-21 09:56:59 +01:00
oembed-service Updated to use assert/strict everywhere (#17047) 2023-06-21 09:56:59 +01:00
offers Added consistent linting pattern to all packages 2023-06-13 10:43:29 +01:00
package-json Added consistent linting pattern to all packages 2023-06-13 10:43:29 +01:00
payments Updated to use assert/strict everywhere (#17047) 2023-06-21 09:56:59 +01:00
post-revisions Update dependency typescript to v5.1.3 2023-06-02 09:06:20 +02:00
posts-service Updated to use assert/strict everywhere (#17047) 2023-06-21 09:56:59 +01:00
referrers Update Test & linting packages 2023-04-05 15:16:08 +02:00
security Added consistent linting pattern to all packages 2023-06-13 10:43:29 +01:00
session-service Added consistent linting pattern to all packages 2023-06-13 10:43:29 +01:00
settings-path-manager Added consistent linting pattern to all packages 2023-06-13 10:43:29 +01:00
slack-notifications Updated to use assert/strict everywhere (#17047) 2023-06-21 09:56:59 +01:00
staff-service Added eslint rule for file naming convention 2023-05-09 12:34:34 -04:00
stats-service Updated to use assert/strict everywhere (#17047) 2023-06-21 09:56:59 +01:00
stripe Updated to use assert/strict everywhere (#17047) 2023-06-21 09:56:59 +01:00
tiers Updated to use assert/strict everywhere (#17047) 2023-06-21 09:56:59 +01:00
update-check-service Updated to use assert/strict everywhere (#17047) 2023-06-21 09:56:59 +01:00
verification-trigger Updated to use assert/strict everywhere (#17047) 2023-06-21 09:56:59 +01:00
version-notifications-data-service Updated to use assert/strict everywhere (#17047) 2023-06-21 09:56:59 +01:00
webmentions Updated to use assert/strict everywhere (#17047) 2023-06-21 09:56:59 +01:00