TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-12-29 13:52:10 +03:00
Code Issues Projects Releases Wiki Activity
c38ca94683
Ghost/ghost/admin/tests/acceptance
History
Kukhyeon Heo c38ca94683 🐛 Fixed Ctrl/Cmd+S triggering browser save when tags or authors input has focus (#1707) 
closes https://github.com/TryGhost/Ghost/issues/11786

`GhTokenInput` uses `PowerSelect` component of `ember-power-select` internally in `app/components/gh-token-input/select-multiple`. 

When you open that component, [you can find](d36f38f39e/addon/components/power-select.ts (L262-L278)) that it calls `stopImmediatePropagation` when ctrl/cmd or meta key is down.

```js
  handleTriggerKeydown(e: KeyboardEvent) {
    if (this.args.onKeydown && this.args.onKeydown(this.storedAPI, e) === false) {
      e.stopImmediatePropagation();
      return;
    }
    if (e.ctrlKey || e.metaKey) {
      e.stopImmediatePropagation();
      return;
    }
    if ((e.keyCode >= 48 && e.keyCode <= 90) || isNumpadKeyEvent(e)) { // Keys 0-9, a-z or numpad keys
      (this.triggerTypingTask as unknown as Performable).perform(e);
    } else if (e.keyCode === 32) {  // Space
      this._handleKeySpace(this.storedAPI, e);
    } else {
      return this._routeKeydown(this.storedAPI, e);
    }
  }
```

Because of that, I had to dispatch event directly to the root of the Ghost admin app.
2020-09-21 18:14:57 +01:00
..
settings Removed errant .only from test suite 2020-07-22 20:00:03 +01:00
authentication-test.js Updated for breaking changes in ember-cli-mirage@1.0.0 2019-05-27 09:58:33 +01:00
content-test.js Updated to fetch settings using /settings/?group= instead of ?type= 2020-06-24 14:23:51 +01:00
custom-post-templates-test.js Updated for breaking changes in ember-cli-mirage@1.0.0 2019-05-27 09:58:33 +01:00
editor-test.js 🐛 Fixed Ctrl/Cmd+S triggering browser save when tags or authors input has focus (#1707) 2020-09-21 18:14:57 +01:00
error-handling-test.js 🔥 Removed all subscriber feature related code (#1337) 2019-09-26 15:58:01 +02:00
members-test.js Removed bulk member edit dev experiment 2020-07-23 15:03:18 +01:00
password-reset-test.js Updated for breaking changes in ember-cli-mirage@1.0.0 2019-05-27 09:58:33 +01:00
setup-test.js Removed <GhDownloadCount> 2020-01-27 09:51:45 +00:00
signin-test.js Updated for breaking changes in ember-cli-mirage@1.0.0 2019-05-27 09:58:33 +01:00
signup-test.js Updated for breaking changes in ember-cli-mirage@1.0.0 2019-05-27 09:58:33 +01:00
staff-test.js Enabled auto reset state for action buttons 2020-06-04 18:44:38 +05:30