mirror of
https://github.com/TryGhost/Ghost.git
synced 2024-12-30 14:22:07 +03:00
c646e78fff
no issue Having `session.user` return a promise made dealing with it in components difficult because you always had to remember it returned a promise rather than a model and had to handle the async behaviour. It also meant that you couldn't use any current user properties directly inside getters which made refactors to Glimmer/Octane idioms harder to reason about. `session.user` was a cached computed property so it really made no sense for it to be a promise - it was loaded on first access and then always returned instantly but with a fulfilled promise rather than the underlying model. Refactoring to a synchronous property that is loaded as part of the authentication flows (we load the current user to check that we're logged in - we may as well make use of that!) means one less thing to be aware of/remember and provides a nicer migration process to Glimmer components. As part of the refactor, the auth flows and pre-load of required data across other services was also simplified to make it easier to find and follow. - refactored app setup and `session.user` - added `session.populateUser()` that fetches a user model from the current user endpoint and sets it on `session.user` - removed knowledge of app setup from the `cookie` authenticator and moved it into = `session.postAuthPreparation()`, this means we have the same post-authentication setup no matter which authenticator is used so we have more consistent behaviour in tests which don't use the `cookie` authenticator - switched `session` service to native class syntax to get the expected `super()` behaviour - updated `handleAuthentication()` so it populate's `session.user` and performs post-auth setup before transitioning (handles sign-in after app load) - updated `application` route to remove duplicated knowledge of app preload behaviour that now lives in `session.postAuthPreparation()` (handles already-authed app load) - removed out-of-date attempt at pre-loading data from setup controller as that's now handled automatically via `session.handleAuthentication` - updated app code to not treat `session.user` as a promise - predominant usage was router `beforeModel` hooks that transitioned users without valid permissions, this sets us up for an easier removal of the `current-user-settings` mixin in the future
35 lines
1.6 KiB
Handlebars
35 lines
1.6 KiB
Handlebars
<div class="gh-post-preview-email-container">
|
|
<div class="gh-post-preview-email-mockup">
|
|
<div class="gh-pe-emailclient-sender">
|
|
<p>
|
|
<span class="strong">{{this.config.blogTitle}}</span> <{{full-email-address this.settings.membersFromAddress}}>
|
|
</p>
|
|
<p><span class="dark">To:</span> Jamie Larson <jamie@example.com></p>
|
|
</div>
|
|
<iframe class="gh-pe-iframe" {{did-insert this.renderEmailPreview}} sandbox="allow-same-origin allow-popups"></iframe>
|
|
</div>
|
|
</div>
|
|
<div class="gh-post-preview-email-footer">
|
|
<span class="mr3 nowrap fw6 f8 darkgrey">Send a test newsletter</span>
|
|
|
|
<div class="gh-post-preview-email-input {{if this.sendPreviewEmailError "error"}}">
|
|
<Input
|
|
@value={{this.previewEmailAddress}}
|
|
class="gh-input gh-post-preview-email-input"
|
|
placeholder="you@yoursite.com"
|
|
aria-invalid={{if this.sendPreviewEmailError "true"}}
|
|
aria-describedby={{if this.sendPreviewEmailError "sendError"}}
|
|
{{on-key "Enter" (perform this.sendPreviewEmailTask)}}
|
|
/>
|
|
{{#if this.sendPreviewEmailError}}
|
|
<div class="error fixed nowrap f8 lh-heading"><span class="response" id="sendError">{{this.sendPreviewEmailError}}</span></div>
|
|
{{/if}}
|
|
</div>
|
|
<GhTaskButton
|
|
@task={{this.sendPreviewEmailTask}}
|
|
@buttonText="Send"
|
|
@successText="Sent"
|
|
@runningText="Sending..."
|
|
@class="gh-btn gh-btn-green gh-btn-icon gh-post-preview-email-trigger"
|
|
/>
|
|
</div> |