mirror of
https://github.com/TryGhost/Ghost.git
synced 2024-12-18 16:01:40 +03:00
060d791a63
no issue
The `settings` service has been a source of confusion when writing with modern Ember patterns because it's use of the deprecated `ProxyMixin` forced all property access/setting to go via `.get()` and `.set()` whereas the rest of the system has mostly (there are a few other uses of ProxyObjects remaining) eliminated the use of the non-native get/set methods.
- removed use of `ProxyMixin` in the `settings` service by grabbing the attributes off the setting model after fetching and using `Object.defineProperty()` to add native getters/setters that pass through to the model's getters/setters. Ember's autotracking automatically works across the native getters/setters so we can then use the service as if it was any other native object
- updated all code to use `settings.{attrName}` directly for getting/setting instead of `.get()` and `.set()`
- removed use of observer in the `customViews` service because it was being set up before the native properties had been added on the settings service meaning autotracking wasn't able to set up properly
86 lines
2.4 KiB
JavaScript
86 lines
2.4 KiB
JavaScript
import AdminRoute from 'ghost-admin/routes/admin';
|
|
import ConfirmUnsavedChangesModal from '../../components/modals/confirm-unsaved-changes';
|
|
import VerifyNewsletterEmail from '../../components/modals/newsletters/verify-newsletter-email';
|
|
import {action} from '@ember/object';
|
|
import {inject as service} from '@ember/service';
|
|
|
|
export default class MembersEmailLabsRoute extends AdminRoute {
|
|
@service feature;
|
|
@service modals;
|
|
@service notifications;
|
|
@service settings;
|
|
|
|
queryParams = {
|
|
verifyEmail: {
|
|
replace: true
|
|
}
|
|
};
|
|
|
|
confirmModal = null;
|
|
hasConfirmed = false;
|
|
|
|
model() {
|
|
return this.settings.reload();
|
|
}
|
|
|
|
afterModel(model, transition) {
|
|
if (transition.to.queryParams.verifyEmail) {
|
|
this.modals.open(VerifyNewsletterEmail, {
|
|
token: transition.to.queryParams.verifyEmail
|
|
});
|
|
|
|
// clear query param so it doesn't linger and cause problems re-entering route
|
|
transition.abort();
|
|
return this.transitionTo('settings.newsletters', {queryParams: {verifyEmail: null}});
|
|
}
|
|
}
|
|
|
|
@action
|
|
willTransition(transition) {
|
|
if (this.hasConfirmed) {
|
|
return true;
|
|
}
|
|
|
|
// always abort when not confirmed because Ember's router doesn't automatically wait on promises
|
|
transition.abort();
|
|
|
|
this.confirmUnsavedChanges().then((shouldLeave) => {
|
|
if (shouldLeave) {
|
|
this.hasConfirmed = true;
|
|
return transition.retry();
|
|
}
|
|
});
|
|
}
|
|
|
|
deactivate() {
|
|
this.confirmModal = null;
|
|
this.hasConfirmed = false;
|
|
}
|
|
|
|
confirmUnsavedChanges() {
|
|
if (!this.settings.hasDirtyAttributes) {
|
|
return Promise.resolve(true);
|
|
}
|
|
|
|
if (!this.confirmModal) {
|
|
this.confirmModal = this.modals.open(ConfirmUnsavedChangesModal)
|
|
.then((discardChanges) => {
|
|
if (discardChanges === true) {
|
|
this.settings.rollbackAttributes();
|
|
}
|
|
return discardChanges;
|
|
}).finally(() => {
|
|
this.confirmModal = null;
|
|
});
|
|
}
|
|
|
|
return this.confirmModal;
|
|
}
|
|
|
|
buildRouteInfoMetadata() {
|
|
return {
|
|
titleToken: 'Settings - Email newsletter'
|
|
};
|
|
}
|
|
}
|