mirror of
https://github.com/TryGhost/Ghost.git
synced 2024-12-12 06:25:51 +03:00
d81bc91bd2
refs #7116, refs #2001 - Changes the way Ghost errors are implemented to benefit from proper inheritance - Moves all error definitions into a single file - Changes the error constructor to take an options object, rather than needing the arguments to be passed in the correct order. - Provides a wrapper so that any errors that haven't already been converted to GhostErrors get converted before they are displayed. Summary of changes: * 🐛 set NODE_ENV in config handler * ✨ add GhostError implementation (core/server/errors.js) - register all errors in one file - inheritance from GhostError - option pattern * 🔥 remove all error files * ✨ wrap all errors into GhostError in case of HTTP * 🎨 adaptions - option pattern for errors - use GhostError when needed * 🎨 revert debug deletion and add TODO for error id's
139 lines
5.5 KiB
JavaScript
139 lines
5.5 KiB
JavaScript
var should = require('should'),
|
|
sinon = require('sinon'),
|
|
Promise = require('bluebird'),
|
|
db = require('../../server/data/db'),
|
|
errors = require('../../server/errors'),
|
|
exporter = require('../../server/data/export'),
|
|
schema = require('../../server/data/schema'),
|
|
settings = require('../../server/api/settings'),
|
|
schemaTables = Object.keys(schema.tables),
|
|
sandbox = sinon.sandbox.create();
|
|
|
|
describe('Exporter', function () {
|
|
var versionStub, tablesStub, queryMock, knexMock, knexStub;
|
|
|
|
afterEach(function () {
|
|
sandbox.restore();
|
|
knexStub.restore();
|
|
});
|
|
|
|
describe('doExport', function () {
|
|
beforeEach(function () {
|
|
versionStub = sandbox.stub(schema.versioning, 'getDatabaseVersion').returns(new Promise.resolve('004'));
|
|
tablesStub = sandbox.stub(schema.commands, 'getTables').returns(schemaTables);
|
|
|
|
queryMock = {
|
|
select: sandbox.stub()
|
|
};
|
|
|
|
knexMock = sandbox.stub().returns(queryMock);
|
|
|
|
// this MUST use sinon, not sandbox, see sinonjs/sinon#781
|
|
knexStub = sinon.stub(db, 'knex', {get: function () { return knexMock; }});
|
|
});
|
|
|
|
it('should try to export all the correct tables', function (done) {
|
|
// Setup for success
|
|
queryMock.select.returns(new Promise.resolve({}));
|
|
|
|
// Execute
|
|
exporter.doExport().then(function (exportData) {
|
|
// No tables, less the number of excluded tables
|
|
var expectedCallCount = schemaTables.length - 4;
|
|
|
|
should.exist(exportData);
|
|
|
|
versionStub.calledOnce.should.be.true();
|
|
tablesStub.calledOnce.should.be.true();
|
|
knexStub.get.called.should.be.true();
|
|
knexMock.called.should.be.true();
|
|
queryMock.select.called.should.be.true();
|
|
|
|
knexMock.callCount.should.eql(expectedCallCount);
|
|
queryMock.select.callCount.should.have.eql(expectedCallCount);
|
|
|
|
knexMock.getCall(0).args[0].should.eql('posts');
|
|
knexMock.getCall(1).args[0].should.eql('users');
|
|
knexMock.getCall(2).args[0].should.eql('roles');
|
|
knexMock.getCall(3).args[0].should.eql('roles_users');
|
|
knexMock.getCall(4).args[0].should.eql('permissions');
|
|
knexMock.getCall(5).args[0].should.eql('permissions_users');
|
|
knexMock.getCall(6).args[0].should.eql('permissions_roles');
|
|
knexMock.getCall(7).args[0].should.eql('permissions_apps');
|
|
knexMock.getCall(8).args[0].should.eql('settings');
|
|
knexMock.getCall(9).args[0].should.eql('tags');
|
|
knexMock.getCall(10).args[0].should.eql('posts_tags');
|
|
knexMock.getCall(11).args[0].should.eql('apps');
|
|
knexMock.getCall(12).args[0].should.eql('app_settings');
|
|
knexMock.getCall(13).args[0].should.eql('app_fields');
|
|
|
|
knexMock.calledWith('clients').should.be.false();
|
|
knexMock.calledWith('client_trusted_domains').should.be.false();
|
|
knexMock.calledWith('refreshtokens').should.be.false();
|
|
knexMock.calledWith('accesstokens').should.be.false();
|
|
|
|
done();
|
|
}).catch(done);
|
|
});
|
|
|
|
it('should catch and log any errors', function (done) {
|
|
// Setup for failure
|
|
queryMock.select.returns(new Promise.reject({}));
|
|
|
|
// Execute
|
|
exporter.doExport()
|
|
.then(function () {
|
|
done(new Error('expected error for export'));
|
|
})
|
|
.catch(function (err) {
|
|
(err instanceof errors.DataExportError).should.eql(true);
|
|
done();
|
|
});
|
|
});
|
|
});
|
|
|
|
describe('exportFileName', function () {
|
|
it('should return a correctly structured filename', function (done) {
|
|
var settingsStub = sandbox.stub(settings, 'read').returns(
|
|
new Promise.resolve({settings: [{value: 'testblog'}]})
|
|
);
|
|
|
|
exporter.fileName().then(function (result) {
|
|
should.exist(result);
|
|
settingsStub.calledOnce.should.be.true();
|
|
result.should.match(/^testblog\.ghost\.[0-9]{4}-[0-9]{2}-[0-9]{2}\.json$/);
|
|
|
|
done();
|
|
}).catch(done);
|
|
});
|
|
|
|
it('should return a correctly structured filename if settings is empty', function (done) {
|
|
var settingsStub = sandbox.stub(settings, 'read').returns(
|
|
new Promise.resolve()
|
|
);
|
|
|
|
exporter.fileName().then(function (result) {
|
|
should.exist(result);
|
|
settingsStub.calledOnce.should.be.true();
|
|
result.should.match(/^ghost\.[0-9]{4}-[0-9]{2}-[0-9]{2}\.json$/);
|
|
|
|
done();
|
|
}).catch(done);
|
|
});
|
|
|
|
it('should return a correctly structured filename if settings errors', function (done) {
|
|
var settingsStub = sandbox.stub(settings, 'read').returns(
|
|
new Promise.reject()
|
|
);
|
|
|
|
exporter.fileName().then(function (result) {
|
|
should.exist(result);
|
|
settingsStub.calledOnce.should.be.true();
|
|
result.should.match(/^ghost\.[0-9]{4}-[0-9]{2}-[0-9]{2}\.json$/);
|
|
|
|
done();
|
|
}).catch(done);
|
|
});
|
|
});
|
|
});
|