mirror of
https://github.com/TryGhost/Ghost.git
synced 2024-11-28 22:43:30 +03:00
243b387063
refs #8126, #8221, #8223 ✨ New 'Proxy' for all helper requires - this is not currently enforced, but could be, much like apps - the proxy object is HUGE - changed date to use SafeString, this should have been there anyway - use the proxy for all helpers, including those in apps 😁 ✨ 🎨 Single instance of hbs for theme + for errors - we now have theme/engine instead of requiring express-hbs everywhere - only error-handler still also requires express-hbs, this is so that we can render errors without extra crud - TODO: remove the asset helper after #8126 IF it is not needed, or else remove the TODO 🎨 Cleanup visibility utils 🎨 Clean up the proxy a little bit 🚨 Unskip test as it now works! 🎨 Minor amends as per comments
104 lines
3.6 KiB
JavaScript
104 lines
3.6 KiB
JavaScript
var _ = require('lodash'),
|
|
api = require('../api'),
|
|
helpers = require('../helpers/register'),
|
|
filters = require('../filters'),
|
|
i18n = require('../i18n'),
|
|
generateProxyFunctions;
|
|
|
|
generateProxyFunctions = function (name, permissions, isInternal) {
|
|
var getPermission = function (perm) {
|
|
return permissions[perm];
|
|
},
|
|
getPermissionToMethod = function (perm, method) {
|
|
var perms = getPermission(perm);
|
|
|
|
if (!perms) {
|
|
return false;
|
|
}
|
|
|
|
return _.find(perms, function (name) {
|
|
return name === method;
|
|
});
|
|
},
|
|
runIfPermissionToMethod = function (perm, method, wrappedFunc, context, args) {
|
|
// internal apps get all permissions
|
|
if (isInternal) {
|
|
return wrappedFunc.apply(context, args);
|
|
}
|
|
|
|
var permValue = getPermissionToMethod(perm, method);
|
|
|
|
if (!permValue) {
|
|
throw new Error(i18n.t('errors.apps.accessResourceWithoutPermission.error', {name:name, perm: perm, method: method}));
|
|
}
|
|
|
|
return wrappedFunc.apply(context, args);
|
|
},
|
|
checkRegisterPermissions = function (perm, registerMethod) {
|
|
return _.wrap(registerMethod, function (origRegister, name) {
|
|
return runIfPermissionToMethod(perm, name, origRegister, this, _.toArray(arguments).slice(1));
|
|
});
|
|
},
|
|
passThruAppContextToApi = function (perm, apiMethods) {
|
|
var appContext = {
|
|
app: name
|
|
};
|
|
|
|
return _.reduce(apiMethods, function (memo, apiMethod, methodName) {
|
|
memo[methodName] = function () {
|
|
var args = _.toArray(arguments),
|
|
options = args[args.length - 1];
|
|
|
|
if (_.isObject(options)) {
|
|
options.context = _.clone(appContext);
|
|
}
|
|
return apiMethod.apply({}, args);
|
|
};
|
|
|
|
return memo;
|
|
}, {});
|
|
},
|
|
proxy;
|
|
|
|
proxy = {
|
|
filters: {
|
|
register: checkRegisterPermissions('filters', filters.registerFilter.bind(filters)),
|
|
deregister: checkRegisterPermissions('filters', filters.deregisterFilter.bind(filters))
|
|
},
|
|
helpers: {
|
|
register: checkRegisterPermissions('helpers', helpers.registerThemeHelper.bind(helpers)),
|
|
registerAsync: checkRegisterPermissions('helpers', helpers.registerAsyncThemeHelper.bind(helpers))
|
|
},
|
|
api: {
|
|
posts: passThruAppContextToApi('posts',
|
|
_.pick(api.posts, 'browse', 'read', 'edit', 'add', 'destroy')
|
|
),
|
|
tags: passThruAppContextToApi('tags',
|
|
_.pick(api.tags, 'browse')
|
|
),
|
|
notifications: passThruAppContextToApi('notifications',
|
|
_.pick(api.notifications, 'browse', 'add', 'destroy')
|
|
),
|
|
settings: passThruAppContextToApi('settings',
|
|
_.pick(api.settings, 'browse', 'read', 'edit')
|
|
)
|
|
}
|
|
};
|
|
|
|
return proxy;
|
|
};
|
|
|
|
function AppProxy(options) {
|
|
if (!options.name) {
|
|
throw new Error(i18n.t('errors.apps.mustProvideAppName.error'));
|
|
}
|
|
|
|
if (!options.permissions) {
|
|
throw new Error(i18n.t('errors.apps.mustProvideAppPermissions.error'));
|
|
}
|
|
|
|
_.extend(this, generateProxyFunctions(options.name, options.permissions, options.internal));
|
|
}
|
|
|
|
module.exports = AppProxy;
|