Ghost/test/unit/services/routing/controllers/entry_spec.js
Naz 143921948d Fixed "no-shadow" eslint warning in tests
refs b6728ecb0f

- The "no-shadow" eslint rune was introduced into ghost's eslint plugin (referenced commmit), which resulted in flood of warning in console output when linting the project codebase.
- This cleanup is aiming to make any new linting issues more visible. Follow up commits will contain similar cleanups in other parts of the codebase
2020-10-19 17:45:26 +13:00

240 lines
6.9 KiB
JavaScript

const should = require('should');
const sinon = require('sinon');
const testUtils = require('../../../../utils');
const configUtils = require('../../../../utils/configUtils');
const urlService = require('../../../../../core/frontend/services/url');
const urlUtils = require('../../../../../core/shared/url-utils');
const controllers = require('../../../../../core/frontend/services/routing/controllers');
const helpers = require('../../../../../core/frontend/services/routing/helpers');
const EDITOR_URL = `/#/editor/post/`;
describe('Unit - services/routing/controllers/entry', function () {
let req;
let res;
let entryLookUpStub;
let secureStub;
let renderStub;
let post;
let page;
beforeEach(function () {
post = testUtils.DataGenerator.forKnex.createPost();
post.url = '/does-exist/';
page = testUtils.DataGenerator.forKnex.createPost({page: 1});
secureStub = sinon.stub();
entryLookUpStub = sinon.stub();
renderStub = sinon.stub();
sinon.stub(helpers, 'entryLookup').get(function () {
return entryLookUpStub;
});
sinon.stub(helpers, 'secure').get(function () {
return secureStub;
});
sinon.stub(helpers, 'renderEntry').get(function () {
return renderStub;
});
sinon.stub(urlUtils, 'redirectToAdmin');
sinon.stub(urlUtils, 'redirect301');
sinon.stub(urlService, 'getResourceById');
req = {
path: '/',
params: {},
route: {}
};
res = {
routerOptions: {
resourceType: 'posts'
},
render: sinon.spy(),
redirect: sinon.spy(),
locals: {}
};
});
afterEach(function () {
sinon.restore();
});
it('resource not found', function (done) {
req.path = '/does-not-exist/';
entryLookUpStub.withArgs(req.path, res.routerOptions)
.resolves(null);
controllers.entry(req, res, function (err) {
should.not.exist(err);
done();
});
});
it('resource found', function (done) {
req.path = post.url;
req.originalUrl = req.path;
res.routerOptions.resourceType = 'posts';
urlService.getResourceById.withArgs(post.id).returns({
config: {
type: 'posts'
}
});
entryLookUpStub.withArgs(req.path, res.routerOptions)
.resolves({
entry: post
});
controllers.entry(req, res, function () {
secureStub.calledOnce.should.be.true();
done();
}).catch(done);
});
describe('[edge cases] resource found', function () {
it('isUnknownOption: true', function (done) {
req.path = post.url;
entryLookUpStub.withArgs(req.path, res.routerOptions)
.resolves({
isUnknownOption: true,
entry: post
});
controllers.entry(req, res, function (err) {
should.not.exist(err);
done();
});
});
it('isEditURL: true', function (done) {
req.path = post.url;
entryLookUpStub.withArgs(req.path, res.routerOptions)
.resolves({
isEditURL: true,
entry: post
});
urlUtils.redirectToAdmin.callsFake(function (statusCode, _res, editorUrl) {
statusCode.should.eql(302);
editorUrl.should.eql(EDITOR_URL + post.id);
done();
});
controllers.entry(req, res, (err) => {
done(err);
});
});
it('isEditURL: true with admin redirects disabled', function (done) {
configUtils.set('admin:redirects', false);
req.path = post.url;
entryLookUpStub.withArgs(req.path, res.routerOptions)
.resolves({
isEditURL: true,
entry: post
});
urlUtils.redirectToAdmin.callsFake(function (statusCode, _res, editorUrl) {
configUtils.restore();
done(new Error('redirectToAdmin was called'));
});
controllers.entry(req, res, (err) => {
configUtils.restore();
urlUtils.redirectToAdmin.called.should.eql(false);
should.not.exist(err);
done(err);
});
});
it('type of router !== type of resource', function (done) {
req.path = post.url;
res.routerOptions.resourceType = 'posts';
urlService.getResourceById.withArgs(post.id).returns({
config: {
type: 'pages'
}
});
entryLookUpStub.withArgs(req.path, res.routerOptions)
.resolves({
entry: post
});
controllers.entry(req, res, function (err) {
should.not.exist(err);
done();
});
});
it('requested url !== resource url', function (done) {
post.url = '/2017/08' + post.url;
req.path = '/2017/07' + post.url;
req.originalUrl = req.path;
res.routerOptions.resourceType = 'posts';
urlService.getResourceById.withArgs(post.id).returns({
config: {
type: 'posts'
}
});
entryLookUpStub.withArgs(req.path, res.routerOptions)
.resolves({
entry: post
});
urlUtils.redirect301.callsFake(function (_res, postUrl) {
postUrl.should.eql(post.url);
done();
});
controllers.entry(req, res, function (err) {
should.exist(err);
done(err);
});
});
it('requested url !== resource url: with query params', function (done) {
post.url = '/2017/08' + post.url;
req.path = '/2017/07' + post.url;
req.originalUrl = req.path + '?query=true';
res.routerOptions.resourceType = 'posts';
urlService.getResourceById.withArgs(post.id).returns({
config: {
type: 'posts'
}
});
entryLookUpStub.withArgs(req.path, res.routerOptions)
.resolves({
entry: post
});
urlUtils.redirect301.callsFake(function (_res, postUrl) {
postUrl.should.eql(post.url + '?query=true');
done();
});
controllers.entry(req, res, function (err) {
done(err);
});
});
});
});