Ghost/core/frontend/services/sitemap/base-generator.js
Kevin Ansfield afbe0c27fb
🐛 Fixed __GHOST_URL__ appearing in sitemaps (#12787)
closes https://github.com/TryGhost/Team/issues/552

Refactors URL transforms so they take place at the model layer rather than the API serializer layer. Continuation of the pattern created for the settings model in https://github.com/TryGhost/Ghost/pull/12738

- Added checks to all front-end tests to ensure output does not contain the magic replacement string
  - includes failing acceptance test for `__GHOST_URL__` appearing in sitemaps
- Removed all transform-ready URL transforms from API serializers
  - input serializers transform image urls relative->absolute to keep absolute-urls as the consistent "outside of the database" format
  - output serializers should not need to perform any URL transforms as that will be done at the model layer
- Added url transforms to models layer
  - removes knowledge from the API serializers which shouldn't need to know how data is stored internally in the database
  - makes absolute urls the consistent "outside of the database" URL format
  - adds transform step to the sitemap generator because the data used for that is fetched directly via knex which will not run through the bookshelf `parse()` methods
2021-03-18 17:16:37 +00:00

185 lines
4.9 KiB
JavaScript

const _ = require('lodash');
const xml = require('xml');
const moment = require('moment');
const path = require('path');
const urlUtils = require('../../../shared/url-utils');
const localUtils = require('./utils');
// Sitemap specific xml namespace declarations that should not change
const XMLNS_DECLS = {
_attr: {
xmlns: 'http://www.sitemaps.org/schemas/sitemap/0.9',
'xmlns:image': 'http://www.google.com/schemas/sitemap-image/1.1'
}
};
class BaseSiteMapGenerator {
constructor() {
this.nodeLookup = {};
this.nodeTimeLookup = {};
this.siteMapContent = null;
this.lastModified = 0;
}
generateXmlFromNodes() {
const self = this;
// Get a mapping of node to timestamp
const timedNodes = _.map(this.nodeLookup, function (node, id) {
return {
id: id,
// Using negative here to sort newest to oldest
ts: -(self.nodeTimeLookup[id] || 0),
node: node
};
}, []);
// Sort nodes by timestamp
const sortedNodes = _.sortBy(timedNodes, 'ts');
// Grab just the nodes
const urlElements = _.map(sortedNodes, 'node');
const data = {
// Concat the elements to the _attr declaration
urlset: [XMLNS_DECLS].concat(urlElements)
};
// Generate full xml
let sitemapXml = localUtils.getDeclarations() + xml(data);
// Perform url transformatons
// - Necessary because sitemap data is supplied by the router which
// uses knex directly bypassing model-layer attribute transforms
sitemapXml = urlUtils.transformReadyToAbsolute(sitemapXml);
return sitemapXml;
}
addUrl(url, datum) {
const node = this.createUrlNodeFromDatum(url, datum);
if (node) {
this.updateLastModified(datum);
this.updateLookups(datum, node);
// force regeneration of xml
this.siteMapContent = null;
}
}
removeUrl(url, datum) {
this.removeFromLookups(datum);
// force regeneration of xml
this.siteMapContent = null;
this.lastModified = Date.now();
}
getLastModifiedForDatum(datum) {
if (datum.updated_at || datum.published_at || datum.created_at) {
const modifiedDate = datum.updated_at || datum.published_at || datum.created_at;
return moment(modifiedDate);
} else {
return moment();
}
}
updateLastModified(datum) {
const lastModified = this.getLastModifiedForDatum(datum);
if (lastModified > this.lastModified) {
this.lastModified = lastModified;
}
}
createUrlNodeFromDatum(url, datum) {
let node;
let imgNode;
node = {
url: [
{loc: url},
{lastmod: moment(this.getLastModifiedForDatum(datum)).toISOString()}
]
};
imgNode = this.createImageNodeFromDatum(datum);
if (imgNode) {
node.url.push(imgNode);
}
return node;
}
createImageNodeFromDatum(datum) {
// Check for cover first because user has cover but the rest only have image
const image = datum.cover_image || datum.profile_image || datum.feature_image;
let imageUrl;
let imageEl;
if (!image) {
return;
}
// Grab the image url
imageUrl = urlUtils.urlFor('image', {image: image}, true);
// Verify the url structure
if (!this.validateImageUrl(imageUrl)) {
return;
}
// Create the weird xml node syntax structure that is expected
imageEl = [
{'image:loc': imageUrl},
{'image:caption': path.basename(imageUrl)}
];
// Return the node to be added to the url xml node
return {
'image:image': imageEl
};
}
validateImageUrl(imageUrl) {
return !!imageUrl;
}
getXml() {
if (this.siteMapContent) {
return this.siteMapContent;
}
const content = this.generateXmlFromNodes();
this.siteMapContent = content;
return content;
}
/**
* @NOTE
* The url service currently has no url update event.
* It removes and adds the url. If the url service extends it's
* feature set, we can detect if a node has changed.
*/
updateLookups(datum, node) {
this.nodeLookup[datum.id] = node;
this.nodeTimeLookup[datum.id] = this.getLastModifiedForDatum(datum);
}
removeFromLookups(datum) {
delete this.nodeLookup[datum.id];
delete this.nodeTimeLookup[datum.id];
}
reset() {
this.nodeLookup = {};
this.nodeTimeLookup = {};
this.siteMapContent = null;
}
}
module.exports = BaseSiteMapGenerator;