Ghost/ghost/admin/app
Simon Backx b911208b41
Improved filter support in activity API to allow pagination (#15684)
fixes https://github.com/TryGhost/Team/issues/2129

- This changes how the activity feed API parses the filter.
- We now parse the filter early to a MongoDB filter, and split it in two. One of the filters is applied to the pageActions, and the other one is used individually for every event type. We now allow to use grouping and OR's inside the filters because of this change. As long as we don't combine filters on 'type' with other filters inside grouped filters or OR, then it is allowed.
- We make use of mongoTransformer to manually inject a mongo filter without needing to parse it from a string value again (that would make it a lot harder because we would have to convert the splitted filter back to a string and we currently don't have methods for that).
- Added sorting by id for events with the same timestamp (required for reliable pagination)
- Added id to each event (required for pagination)
- Added more tests for filters
- Added test for pagination
- Removed unsued getSubscriptions and getVolume methods

Used new mongo utility methods introduced here: https://github.com/TryGhost/NQL/pull/49
2022-10-27 12:13:24 +02:00
..
adapters 🐛 Fixed settings overriden when updated from multiple tabs (#15536) 2022-10-12 14:03:54 +01:00
authenticators Made session.user a synchronous property rather than a promise 2021-07-08 14:54:31 +01:00
components Added linking between member and subscription created events (#15693) 2022-10-27 11:44:19 +02:00
controllers Fixed labs not working on posts page initial load 2022-10-26 16:03:02 +02:00
errors Improved validation process for members CSV import 2020-07-07 00:28:30 +12:00
helpers Improved filter support in activity API to allow pagination (#15684) 2022-10-27 12:13:24 +02:00
initializers Resolved ember-simple-auth deprecations 2022-01-22 00:30:56 +00:00
mixins Updated ValidationEngine to support bare native class models (#15567) 2022-10-07 20:13:42 +01:00
models Added email feedback column (#15698) 2022-10-27 11:22:50 +04:00
modifiers Migrated staff user screen to Ember Octane patterns (#15532) 2022-10-05 12:05:31 +01:00
routes Added mock component for analytics settings page 2022-10-26 15:15:09 +02:00
serializers 🐛 Fixed settings overriden when updated from multiple tabs (#15536) 2022-10-12 14:03:54 +01:00
services Added linking between member and subscription created events (#15693) 2022-10-27 11:44:19 +02:00
session-stores Migrated session-store to native class syntax 2022-02-02 18:41:16 +00:00
styles Added a quick fix to bring back the feedback tab pie chart 2022-10-26 18:15:35 +01:00
templates Added link to analytics settings to the settings page 2022-10-26 15:15:09 +02:00
transforms Dropped ember-cli-moment-shim dependency 2022-09-24 13:28:23 +02:00
transitions Fixed autofocus not working on modal inputs 2018-06-04 17:48:57 +01:00
utils Removed need for .get() with config service 2022-10-07 16:14:57 +01:00
validators Updated ValidationEngine to support bare native class models (#15567) 2022-10-07 20:13:42 +01:00
app.js Dropped ember-cli-moment-shim dependency 2022-09-24 13:28:23 +02:00
index.html Fixed loading animation for Safari 2022-10-17 10:11:07 +02:00
README.md Renamed "client" references to "admin" 2022-05-17 09:09:14 +01:00
router.js Added mock component for analytics settings page 2022-10-26 15:15:09 +02:00
transitions.js Removed tour feature 2021-03-02 14:29:26 +00:00

Ghost Admin App

Ember.js application used as a client-side admin for the Ghost blogging platform. This readme is a work in progress guide aimed at explaining the specific nuances of the Ghost Ember app to contributors whose main focus is on this side of things.

CSS

We use pure CSS, which is pre-processed for backwards compatibility by Myth. We do not follow any strict CSS framework, however our general style is pretty similar to BEM.

Styles are primarily broken up into 4 main categories:

  • Patterns - are base level visual styles for HTML elements (eg. Buttons)
  • Components - are groups of patterns used to create a UI component (eg. Modals)
  • Layouts - are groups of components used to create application screens (eg. Settings)

All of these separate files are subsequently imported and compiled in app.css.

Front End Standards

  • 4 spaces for HTML & CSS indentation. Never tabs.
  • Double quotes only, never single quotes.
  • Use tags and elements appropriate for an HTML5 doctype (including self-closing tags)
  • Adhere to the Recess CSS property order.
  • Always a space after a property's colon (.e.g, display: block; and not display:block;).
  • End all lines with a semi-colon.
  • For multiple, comma-separated selectors, place each selector on its own line.
  • Use js- prefixed classes for JavaScript hooks into the DOM, and never use these in CSS as per Slightly Obtrusive JavaSript
  • Avoid over-nesting CSS. Never nest more than 3 levels deep.
  • Use comments to explain "why" not "what" (Good: This requires a z-index in order to appear above mobile navigation. Bad: This is a thing which is always on top!)