mirror of
https://github.com/TryGhost/Ghost.git
synced 2024-12-11 22:13:20 +03:00
143921948d
refs b6728ecb0f
- The "no-shadow" eslint rune was introduced into ghost's eslint plugin (referenced commmit), which resulted in flood of warning in console output when linting the project codebase.
- This cleanup is aiming to make any new linting issues more visible. Follow up commits will contain similar cleanups in other parts of the codebase
168 lines
5.1 KiB
JavaScript
168 lines
5.1 KiB
JavaScript
const errors = require('@tryghost/errors');
|
|
const should = require('should');
|
|
const sinon = require('sinon');
|
|
const path = require('path');
|
|
const ampController = require('../../../../core/frontend/apps/amp/lib/router');
|
|
const urlService = require('../../../../core/frontend/services/url');
|
|
const helpers = require('../../../../core/frontend/services/routing/helpers');
|
|
const testUtils = require('../../../utils');
|
|
const configUtils = require('../../../utils/configUtils');
|
|
|
|
// Helper function to prevent unit tests
|
|
// from failing via timeout when they
|
|
// should just immediately fail
|
|
function failTest(done) {
|
|
return function (err) {
|
|
done(err);
|
|
};
|
|
}
|
|
|
|
describe('Unit - apps/amp/lib/router', function () {
|
|
let res;
|
|
let req;
|
|
let defaultPath;
|
|
let rendererStub;
|
|
|
|
beforeEach(function () {
|
|
rendererStub = sinon.stub();
|
|
|
|
sinon.stub(helpers, 'renderer').get(function () {
|
|
return rendererStub;
|
|
});
|
|
|
|
res = {
|
|
render: sinon.spy(),
|
|
locals: {
|
|
context: ['amp', 'post']
|
|
}
|
|
};
|
|
|
|
req = {
|
|
route: {path: '/'},
|
|
query: {r: ''},
|
|
params: {},
|
|
amp: {},
|
|
body: {
|
|
post: {
|
|
title: 'test'
|
|
}
|
|
}
|
|
};
|
|
|
|
defaultPath = path.join(configUtils.config.get('paths').appRoot, '/core/frontend/apps/amp/lib/views/amp.hbs');
|
|
});
|
|
|
|
afterEach(function () {
|
|
sinon.restore();
|
|
});
|
|
|
|
describe('fn: renderer', function () {
|
|
it('should render default amp page when theme has no amp template', function (done) {
|
|
helpers.renderer.callsFake(function (_req, _res, data) {
|
|
_res.routerOptions.defaultTemplate.should.eql(defaultPath);
|
|
data.should.eql({post: {title: 'test'}});
|
|
done();
|
|
});
|
|
|
|
ampController.renderer(req, res, failTest(done));
|
|
});
|
|
|
|
it('throws 404 when req.body has no post', function (done) {
|
|
req.body = {};
|
|
|
|
ampController.renderer(req, res, function (err) {
|
|
(err instanceof errors.NotFoundError).should.be.true();
|
|
helpers.renderer.called.should.be.false();
|
|
done();
|
|
});
|
|
});
|
|
|
|
it('throws 404 when req.body.post is a page', function (done) {
|
|
req.body = {
|
|
post: {
|
|
page: true
|
|
}
|
|
};
|
|
|
|
ampController.renderer(req, res, function (err) {
|
|
(err instanceof errors.NotFoundError).should.be.true();
|
|
helpers.renderer.called.should.be.false();
|
|
done();
|
|
});
|
|
});
|
|
});
|
|
|
|
describe('fn: getPostData', function () {
|
|
let entryLookupStub;
|
|
let post;
|
|
|
|
beforeEach(function () {
|
|
post = testUtils.DataGenerator.forKnex.createPost({slug: 'welcome'});
|
|
|
|
res = {
|
|
locals: {}
|
|
};
|
|
|
|
req = {};
|
|
|
|
entryLookupStub = sinon.stub();
|
|
|
|
sinon.stub(helpers, 'entryLookup').get(function () {
|
|
return entryLookupStub;
|
|
});
|
|
|
|
sinon.stub(urlService, 'getPermalinkByUrl');
|
|
});
|
|
|
|
afterEach(function () {
|
|
sinon.restore();
|
|
});
|
|
|
|
it('should successfully get the post data from slug', function (done) {
|
|
res.locals.relativeUrl = req.originalUrl = '/welcome/amp';
|
|
|
|
urlService.getPermalinkByUrl.withArgs('/welcome/').returns('/:slug/');
|
|
|
|
helpers.entryLookup.withArgs('/welcome/', {permalinks: '/:slug/', query: {controller: 'postsPublic', resource: 'posts'}})
|
|
.resolves({
|
|
entry: post
|
|
});
|
|
|
|
ampController.getPostData(req, res, function () {
|
|
req.body.post.should.be.eql(post);
|
|
done();
|
|
});
|
|
});
|
|
|
|
it('subdirectory: should successfully get the post data from slug', function (done) {
|
|
req.originalUrl = '/blog/welcome/amp';
|
|
res.locals.relativeUrl = '/welcome/amp';
|
|
|
|
urlService.getPermalinkByUrl.withArgs('/welcome/').returns('/:slug/');
|
|
|
|
helpers.entryLookup.withArgs('/welcome/', {permalinks: '/:slug/', query: {controller: 'postsPublic', resource: 'posts'}}).resolves({
|
|
entry: post
|
|
});
|
|
|
|
ampController.getPostData(req, res, function () {
|
|
req.body.post.should.be.eql(post);
|
|
done();
|
|
});
|
|
});
|
|
|
|
it('should return error if entrylookup returns NotFoundError', function (done) {
|
|
res.locals.relativeUrl = req.originalUrl = '/welcome/amp';
|
|
|
|
urlService.getPermalinkByUrl.withArgs('/welcome/').returns('/:slug/');
|
|
|
|
helpers.entryLookup.withArgs('/welcome/', {permalinks: '/:slug/', query: {controller: 'postsPublic', resource: 'posts'}})
|
|
.rejects(new errors.NotFoundError());
|
|
|
|
ampController.getPostData(req, res, function (err) {
|
|
(err instanceof errors.NotFoundError).should.be.true();
|
|
done();
|
|
});
|
|
});
|
|
});
|
|
});
|