mirror of
https://github.com/TryGhost/Ghost.git
synced 2024-12-30 06:12:03 +03:00
a565da06b2
refs https://github.com/TryGhost/Team/issues/1257 Offer Redemptions were being overcounted due to the way we were updating Stripe configuration for the Members service. We would create a new instance of the members-api, which would have event handlers for creating Offer Redemptions - by creating a new instance each time Stripe config changed, we would overcount them. Here we've pulled out Stripe related logic into the Stripe service, and updated it internally - rather than creating a new instance. This means that we've been able to remove all of the logic for re-instantiating the members-api. - Bumped members-api & stripe-service - Removed reinstantiation of members-api - Used stripe service to execute migrations - Updated Stripe Service to handle webhooks & migrations - Used webhook controller from stripe service - Used disconnect method from stripe service - Removed unused stripe dependency - Removed Stripe webhook config from members-api
63 lines
3.4 KiB
JavaScript
63 lines
3.4 KiB
JavaScript
const debug = require('@tryghost/debug')('members');
|
|
const {URL} = require('url');
|
|
const cors = require('cors');
|
|
const bodyParser = require('body-parser');
|
|
const express = require('../../../shared/express');
|
|
const urlUtils = require('../../../shared/url-utils');
|
|
const sentry = require('../../../shared/sentry');
|
|
const membersService = require('../../services/members');
|
|
const stripeService = require('../../services/stripe');
|
|
const middleware = membersService.middleware;
|
|
const shared = require('../shared');
|
|
const labs = require('../../../shared/labs');
|
|
const errorHandler = require('@tryghost/mw-error-handler');
|
|
|
|
module.exports = function setupMembersApp() {
|
|
debug('Members App setup start');
|
|
const membersApp = express('members');
|
|
|
|
// Members API shouldn't be cached
|
|
membersApp.use(shared.middleware.cacheControl('private'));
|
|
|
|
// Support CORS for requests from the frontend
|
|
const siteUrl = new URL(urlUtils.getSiteUrl());
|
|
membersApp.use(cors(siteUrl.origin));
|
|
|
|
// Currently global handling for signing in with ?token= magiclinks
|
|
membersApp.use(middleware.createSessionFromMagicLink);
|
|
|
|
// Routing
|
|
|
|
// Webhooks
|
|
membersApp.post('/webhooks/stripe', bodyParser.raw({type: 'application/json'}), stripeService.webhookController.handle.bind(stripeService.webhookController));
|
|
|
|
// Initializes members specific routes as well as assigns members specific data to the req/res objects
|
|
// We don't want to add global bodyParser middleware as that interfers with stripe webhook requests on - `/webhooks`.
|
|
membersApp.get('/api/member', middleware.getMemberData);
|
|
membersApp.put('/api/member', bodyParser.json({limit: '1mb'}), middleware.updateMemberData);
|
|
membersApp.post('/api/member/email', bodyParser.json({limit: '1mb'}), (req, res) => membersService.api.middleware.updateEmailAddress(req, res));
|
|
membersApp.get('/api/session', middleware.getIdentityToken);
|
|
membersApp.get('/api/offers/:id', middleware.getOfferData);
|
|
membersApp.delete('/api/session', middleware.deleteSession);
|
|
membersApp.get('/api/site', shared.middleware.cacheControl('public', {maxAge: 30}), middleware.getMemberSiteData);
|
|
|
|
// NOTE: this is wrapped in a function to ensure we always go via the getter
|
|
membersApp.post('/api/send-magic-link', bodyParser.json(), shared.middleware.brute.membersAuth, (req, res, next) => membersService.api.middleware.sendMagicLink(req, res, next));
|
|
membersApp.post('/api/create-stripe-checkout-session', (req, res, next) => membersService.api.middleware.createCheckoutSession(req, res, next));
|
|
membersApp.post('/api/create-stripe-update-session', (req, res, next) => membersService.api.middleware.createCheckoutSetupSession(req, res, next));
|
|
membersApp.put('/api/subscriptions/:id', (req, res, next) => membersService.api.middleware.updateSubscription(req, res, next));
|
|
membersApp.post('/api/events', labs.enabledMiddleware('membersActivity'), middleware.loadMemberSession, (req, res, next) => membersService.api.middleware.createEvents(req, res, next));
|
|
|
|
// API error handling
|
|
membersApp.use('/api', errorHandler.resourceNotFound);
|
|
membersApp.use('/api', errorHandler.handleJSONResponseV2(sentry));
|
|
|
|
// Webhook error handling
|
|
membersApp.use('/webhooks', errorHandler.resourceNotFound);
|
|
membersApp.use('/webhooks', errorHandler.handleJSONResponseV2(sentry));
|
|
|
|
debug('Members App setup end');
|
|
|
|
return membersApp;
|
|
};
|