mirror of
https://github.com/TryGhost/Ghost.git
synced 2024-12-02 08:13:34 +03:00
d10da5a02b
refs https://github.com/TryGhost/Team/issues/1513 - `sender_name` is now nullable with a fallback to the site title - updated new-newsletter route - removed default setting of site title in `senderName` of the new newsletter instance - removed extra checks when showing unsaved changes modal as we no longer need to compare the `senderName` attribute against the site title - updated newsletter preview so the sender name falls back to the site title - updated sender name input placeholder to show the site title - removed not-empty validation - fixed the switch to "multiple newsletter" state in the background of the new-newsletter modal - problem was `displayingDefault` getter was looking at all active newsletters rather than just the filtered ones so it was counting the new-but-unsaved newsletter even though it wasn't displayed in the list - fixes layout glitch when the new-newsletter modal animates out after cancelling creation |
||
|---|---|---|
| .. | ||
| adapters | ||
| authenticators | ||
| components | ||
| controllers | ||
| errors | ||
| helpers | ||
| initializers | ||
| mixins | ||
| models | ||
| modifiers | ||
| routes | ||
| serializers | ||
| services | ||
| session-stores | ||
| styles | ||
| templates | ||
| transforms | ||
| transitions | ||
| utils | ||
| validators | ||
| app.js | ||
| index.html | ||
| README.md | ||
| router.js | ||
| transitions.js | ||
Ghost Admin Client
Ember.js application used as a client-side admin for the Ghost blogging platform. This readme is a work in progress guide aimed at explaining the specific nuances of the Ghost Ember app to contributors whose main focus is on this side of things.
CSS
We use pure CSS, which is pre-processed for backwards compatibility by Myth. We do not follow any strict CSS framework, however our general style is pretty similar to BEM.
Styles are primarily broken up into 4 main categories:
- Patterns - are base level visual styles for HTML elements (eg. Buttons)
- Components - are groups of patterns used to create a UI component (eg. Modals)
- Layouts - are groups of components used to create application screens (eg. Settings)
All of these separate files are subsequently imported and compiled in app.css.
Front End Standards
- 4 spaces for HTML & CSS indentation. Never tabs.
- Double quotes only, never single quotes.
- Use tags and elements appropriate for an HTML5 doctype (including self-closing tags)
- Adhere to the Recess CSS property order.
- Always a space after a property's colon (.e.g, display: block; and not display:block;).
- End all lines with a semi-colon.
- For multiple, comma-separated selectors, place each selector on its own line.
- Use js- prefixed classes for JavaScript hooks into the DOM, and never use these in CSS as per Slightly Obtrusive JavaSript
- Avoid over-nesting CSS. Never nest more than 3 levels deep.
- Use comments to explain "why" not "what" (Good: This requires a z-index in order to appear above mobile navigation. Bad: This is a thing which is always on top!)