mirror of
https://github.com/TryGhost/Ghost.git
synced 2024-12-28 05:14:12 +03:00
6161f94910
refs: https://github.com/TryGhost/Toolbox/issues/595 We're rolling out new rules around the node assert library, the first of which is enforcing the use of assert/strict. This means we don't need to use the strict version of methods, as the standard version will work that way by default. This caught some gotchas in our existing usage of assert where the lack of strict mode had unexpected results: - Url matching needs to be done on `url.href` seeaa58b354a4
- Null and undefined are not the same thing, there were a few cases of this being confused - Particularly questionable changes in [PostExporter tests](c1a468744b
) tracked [here](https://github.com/TryGhost/Team/issues/3505). - A typo seeeaac9c293a
Moving forward, using assert strict should help us to catch unexpected behaviour, particularly around nulls and undefineds during implementation.
157 lines
5.8 KiB
JavaScript
157 lines
5.8 KiB
JavaScript
const {LinkRedirectsService} = require('../index');
|
|
const assert = require('assert/strict');
|
|
const sinon = require('sinon');
|
|
const crypto = require('crypto');
|
|
|
|
describe('LinkRedirectsService', function () {
|
|
afterEach(function () {
|
|
sinon.restore();
|
|
});
|
|
|
|
it('exported', function () {
|
|
assert.equal(require('../index').LinkRedirectsService, LinkRedirectsService);
|
|
});
|
|
|
|
describe('getSlugUrl', function () {
|
|
it('works for first random slug that does not exist', async function () {
|
|
const instance = new LinkRedirectsService({
|
|
linkRedirectRepository: {
|
|
getByURL: () => Promise.resolve(undefined)
|
|
},
|
|
config: {
|
|
baseURL: new URL('https://localhost:2368/')
|
|
}
|
|
});
|
|
// stub crypto.randomBytes to return a known value toString
|
|
sinon.stub(crypto, 'randomBytes').returns(Buffer.from('00000000', 'hex'));
|
|
const url = await instance.getSlugUrl();
|
|
assert.equal(url.href, 'https://localhost:2368/r/00000000');
|
|
});
|
|
|
|
it('works when first random slug already exists', async function () {
|
|
const instance = new LinkRedirectsService({
|
|
linkRedirectRepository: {
|
|
getByURL: (url) => {
|
|
if (url.href === 'https://localhost:2368/r/00000000') {
|
|
return Promise.resolve({});
|
|
}
|
|
return Promise.resolve(undefined);
|
|
}
|
|
},
|
|
config: {
|
|
baseURL: new URL('https://localhost:2368/')
|
|
}
|
|
});
|
|
// stub crypto.randomBytes to return 00000000 first and something else
|
|
sinon.stub(crypto, 'randomBytes')
|
|
.onFirstCall().returns(Buffer.from('00000000', 'hex'))
|
|
.onSecondCall().returns(Buffer.from('11111111', 'hex'));
|
|
const url = await instance.getSlugUrl();
|
|
assert.equal(url.href, 'https://localhost:2368/r/11111111');
|
|
});
|
|
});
|
|
|
|
describe('addRedirect', function () {
|
|
it('saves', async function () {
|
|
const linkRedirectRepository = {
|
|
save: sinon.fake()
|
|
};
|
|
const instance = new LinkRedirectsService({
|
|
linkRedirectRepository,
|
|
config: {
|
|
baseURL: new URL('https://localhost:2368/')
|
|
}
|
|
});
|
|
await instance.addRedirect(new URL('https://localhost:2368/a'), new URL('https://localhost:2368/b'));
|
|
assert.equal(linkRedirectRepository.save.callCount, 1);
|
|
assert.equal(linkRedirectRepository.save.getCall(0).args[0].from.href, 'https://localhost:2368/a');
|
|
assert.equal(linkRedirectRepository.save.getCall(0).args[0].to.href, 'https://localhost:2368/b');
|
|
});
|
|
});
|
|
|
|
describe('handleRequest', function () {
|
|
it('redirects if found', async function () {
|
|
const linkRedirectRepository = {
|
|
getByURL: (url) => {
|
|
if (url.href === 'https://localhost:2368/r/a') {
|
|
return Promise.resolve({
|
|
to: new URL('https://localhost:2368/b')
|
|
});
|
|
}
|
|
return Promise.resolve(undefined);
|
|
}
|
|
};
|
|
const instance = new LinkRedirectsService({
|
|
linkRedirectRepository,
|
|
config: {
|
|
baseURL: new URL('https://localhost:2368/')
|
|
}
|
|
});
|
|
const req = {
|
|
originalUrl: '/r/a'
|
|
};
|
|
const res = {
|
|
redirect: sinon.fake(),
|
|
setHeader: sinon.fake()
|
|
};
|
|
await instance.handleRequest(req, res);
|
|
assert.equal(res.redirect.callCount, 1);
|
|
assert.equal(res.redirect.getCall(0).args[0], 'https://localhost:2368/b');
|
|
assert(res.setHeader.calledWith('X-Robots-Tag', 'noindex, nofollow'));
|
|
});
|
|
|
|
it('does not redirect if not found', async function () {
|
|
const linkRedirectRepository = {
|
|
getByURL: () => Promise.resolve(undefined)
|
|
};
|
|
const instance = new LinkRedirectsService({
|
|
linkRedirectRepository,
|
|
config: {
|
|
baseURL: new URL('https://localhost:2368/')
|
|
}
|
|
});
|
|
const req = {
|
|
originalUrl: 'r/a'
|
|
};
|
|
const res = {};
|
|
const next = sinon.fake();
|
|
await instance.handleRequest(req, res, next);
|
|
assert.equal(next.callCount, 1);
|
|
});
|
|
|
|
it('does not redirect if url does not contain a redirect prefix on site with no subdir', async function () {
|
|
const instance = new LinkRedirectsService({
|
|
config: {
|
|
baseURL: new URL('https://localhost:2368/')
|
|
}
|
|
});
|
|
const req = {
|
|
originalUrl: 'no_r/prefix'
|
|
};
|
|
const res = {};
|
|
const next = sinon.fake();
|
|
|
|
await instance.handleRequest(req, res, next);
|
|
|
|
assert.equal(next.callCount, 1);
|
|
});
|
|
|
|
it('does not redirect if url does not contain a redirect prefix on site with subdir', async function () {
|
|
const instance = new LinkRedirectsService({
|
|
config: {
|
|
baseURL: new URL('https://localhost:2368/blog')
|
|
}
|
|
});
|
|
const req = {
|
|
originalUrl: 'blog/no_r/prefix'
|
|
};
|
|
const res = {};
|
|
const next = sinon.fake();
|
|
|
|
await instance.handleRequest(req, res, next);
|
|
|
|
assert.equal(next.callCount, 1);
|
|
});
|
|
});
|
|
});
|