mirror of
https://github.com/TryGhost/Ghost.git
synced 2025-01-03 16:38:22 +03:00
18bd10308b
- updated various files I noticed were outdated on my travels around the codebase - doesn't make any more advanced ES6 changes, this is mostly in the persuit of getting rid of var x = y, z = a; lists at the top of files
182 lines
6.2 KiB
JavaScript
182 lines
6.2 KiB
JavaScript
const should = require('should');
|
|
const sinon = require('sinon');
|
|
const express = require('express');
|
|
const serveFavicon = require('../../../../../core/server/web/site/middleware/serve-favicon');
|
|
const settingsCache = require('../../../../../core/server/services/settings/cache');
|
|
const storage = require('../../../../../core/server/adapters/storage');
|
|
const configUtils = require('../../../../utils/configUtils');
|
|
const path = require('path');
|
|
|
|
describe('Serve Favicon', function () {
|
|
let req, res, next, blogApp, localSettingsCache = {}, originalStoragePath;
|
|
|
|
beforeEach(function () {
|
|
req = sinon.spy();
|
|
res = sinon.spy();
|
|
next = sinon.spy();
|
|
blogApp = express();
|
|
req.app = blogApp;
|
|
|
|
sinon.stub(settingsCache, 'get').callsFake(function (key) {
|
|
return localSettingsCache[key];
|
|
});
|
|
|
|
originalStoragePath = storage.getStorage().storagePath;
|
|
});
|
|
|
|
afterEach(function () {
|
|
sinon.restore();
|
|
configUtils.restore();
|
|
localSettingsCache = {};
|
|
storage.getStorage().storagePath = originalStoragePath;
|
|
});
|
|
|
|
describe('serveFavicon', function () {
|
|
it('should return a middleware', function () {
|
|
const middleware = serveFavicon();
|
|
|
|
middleware.should.be.a.Function();
|
|
});
|
|
|
|
it('should skip if the request does NOT match the file', function () {
|
|
const middleware = serveFavicon();
|
|
req.path = '/robots.txt';
|
|
middleware(req, res, next);
|
|
next.called.should.be.true();
|
|
});
|
|
|
|
describe('serves', function () {
|
|
it('custom uploaded favicon.png', function (done) {
|
|
const middleware = serveFavicon();
|
|
req.path = '/favicon.png';
|
|
|
|
storage.getStorage().storagePath = path.join(__dirname, '../../../../../test/utils/fixtures/images/');
|
|
localSettingsCache.icon = 'favicon.png';
|
|
|
|
res = {
|
|
writeHead: function (statusCode) {
|
|
statusCode.should.eql(200);
|
|
},
|
|
end: function (body) {
|
|
body.length.should.eql(6792);
|
|
done();
|
|
}
|
|
};
|
|
|
|
middleware(req, res, next);
|
|
});
|
|
|
|
it('custom uploaded favicon.ico', function (done) {
|
|
const middleware = serveFavicon();
|
|
req.path = '/favicon.ico';
|
|
|
|
storage.getStorage().storagePath = path.join(__dirname, '../../../../../test/utils/fixtures/images/');
|
|
localSettingsCache.icon = 'favicon.ico';
|
|
|
|
res = {
|
|
writeHead: function (statusCode) {
|
|
statusCode.should.eql(200);
|
|
},
|
|
end: function (body) {
|
|
body.length.should.eql(15086);
|
|
done();
|
|
}
|
|
};
|
|
|
|
middleware(req, res, next);
|
|
});
|
|
|
|
it('custom uploaded myicon.ico', function (done) {
|
|
const middleware = serveFavicon();
|
|
req.path = '/favicon.ico';
|
|
|
|
storage.getStorage().storagePath = path.join(__dirname, '../../../../../test/utils/fixtures/images/');
|
|
localSettingsCache.icon = 'myicon.ico';
|
|
|
|
res = {
|
|
writeHead: function (statusCode) {
|
|
statusCode.should.eql(200);
|
|
},
|
|
end: function (body) {
|
|
body.length.should.eql(15086);
|
|
done();
|
|
}
|
|
};
|
|
|
|
middleware(req, res, next);
|
|
});
|
|
|
|
it('default favicon.ico', function (done) {
|
|
const middleware = serveFavicon();
|
|
req.path = '/favicon.ico';
|
|
localSettingsCache.icon = '';
|
|
|
|
res = {
|
|
writeHead: function (statusCode) {
|
|
statusCode.should.eql(200);
|
|
},
|
|
end: function (body) {
|
|
body.length.should.eql(1108);
|
|
done();
|
|
}
|
|
};
|
|
|
|
middleware(req, res, next);
|
|
});
|
|
});
|
|
|
|
describe('redirects', function () {
|
|
it('to custom favicon.ico when favicon.png is requested', function (done) {
|
|
const middleware = serveFavicon();
|
|
req.path = '/favicon.png';
|
|
|
|
configUtils.set('paths:contentPath', path.join(__dirname, '../../../../../test/utils/fixtures/'));
|
|
localSettingsCache.icon = 'favicon.ico';
|
|
|
|
res = {
|
|
redirect: function (statusCode) {
|
|
statusCode.should.eql(302);
|
|
done();
|
|
}
|
|
};
|
|
|
|
middleware(req, res, next);
|
|
});
|
|
|
|
it('to custom favicon.png when favicon.ico is requested', function (done) {
|
|
const middleware = serveFavicon();
|
|
req.path = '/favicon.ico';
|
|
|
|
configUtils.set('paths:contentPath', path.join(__dirname, '../../../../../test/utils/fixtures/'));
|
|
localSettingsCache.icon = 'favicon.png';
|
|
|
|
res = {
|
|
redirect: function (statusCode) {
|
|
statusCode.should.eql(302);
|
|
done();
|
|
}
|
|
};
|
|
|
|
middleware(req, res, next);
|
|
});
|
|
|
|
it('to favicon.ico when favicon.png is requested', function (done) {
|
|
const middleware = serveFavicon();
|
|
req.path = '/favicon.png';
|
|
|
|
configUtils.set('paths:publicFilePath', path.join(__dirname, '../../../../../test/utils/fixtures/'));
|
|
localSettingsCache.icon = '';
|
|
|
|
res = {
|
|
redirect: function (statusCode) {
|
|
statusCode.should.eql(302);
|
|
done();
|
|
}
|
|
};
|
|
|
|
middleware(req, res, next);
|
|
});
|
|
});
|
|
});
|
|
});
|