mirror of
https://github.com/TryGhost/Ghost.git
synced 2024-11-29 15:12:58 +03:00
e01ffa3620
no issue - review use of Ember core hooks and add a call to `this._super` if missing - fix a few occurrences of using the wrong component lifecycle hooks that could result in multiple/duplicate event handlers being attached `_super` should always be called when overriding Ember's base hooks so that core functionality or app functionality added through extensions, mixins or addons is not lost. This is important as it guards against issues arising from later refactorings or core changes. As example of lost functionality, there were a number of routes that extended from `AuthenticatedRoute` but then overrode the `beforeModel` hook without calling `_super` which meant that the route was no longer treated as authenticated.
32 lines
934 B
JavaScript
32 lines
934 B
JavaScript
import Ember from 'ember';
|
|
|
|
const {Route, addObserver, inject, removeObserver} = Ember;
|
|
|
|
// Routes that extend MobileIndexRoute need to implement
|
|
// desktopTransition, a function which is called when
|
|
// the user resizes to desktop levels.
|
|
export default Route.extend({
|
|
desktopTransition: Ember.K,
|
|
_callDesktopTransition: null,
|
|
|
|
mediaQueries: inject.service(),
|
|
|
|
activate() {
|
|
this._super(...arguments);
|
|
this._callDesktopTransition = () => {
|
|
if (!this.get('mediaQueries.isMobile')) {
|
|
this.desktopTransition();
|
|
}
|
|
};
|
|
addObserver(this, 'mediaQueries.isMobile', this._callDesktopTransition);
|
|
},
|
|
|
|
deactivate() {
|
|
this._super(...arguments);
|
|
if (this._callDesktopTransition) {
|
|
removeObserver(this, 'mediaQueries.isMobile', this._callDesktopTransition);
|
|
this._callDesktopTransition = null;
|
|
}
|
|
}
|
|
});
|