mirror of
https://github.com/TryGhost/Ghost.git
synced 2024-12-18 16:01:40 +03:00
d2d7fb3fe7
refs https://github.com/TryGhost/Ghost/pull/14197 - Moved from updating the last_seen_at value "at most every 24h" to "at most every UTC day". - It will simplify explaining the following behavior: a publication is set in UTC-10, a user visits at 2pm on Monday and at 1pm on Tuesday, the last_seen_at value is still Monday. - There is no way to go around the above issue due to the technical constraint of updating the `last_seen_at` value at most once a day. - This might create database write spikes at midnight UTC
55 lines
2.2 KiB
JavaScript
55 lines
2.2 KiB
JavaScript
// Switch these lines once there are useful utils
|
|
// const testUtils = require('./utils');
|
|
require('./utils');
|
|
|
|
const assert = require('assert');
|
|
const sinon = require('sinon');
|
|
const {LastSeenAtUpdater} = require('../');
|
|
const DomainEvents = require('@tryghost/domain-events');
|
|
const {MemberPageViewEvent, MemberSubscribeEvent} = require('@tryghost/member-events');
|
|
const moment = require('moment');
|
|
|
|
describe('LastSeenAtUpdater', function () {
|
|
it('Fires on MemberPageViewEvent events', async function () {
|
|
const now = moment('2022-02-28T18:00:00Z').utc();
|
|
const previousLastSeen = moment('2022-02-27T23:00:00Z').toISOString();
|
|
const spy = sinon.spy();
|
|
new LastSeenAtUpdater({
|
|
memberModel: {
|
|
update: spy
|
|
}
|
|
});
|
|
DomainEvents.dispatch(MemberPageViewEvent.create({memberId: '1', memberLastSeenAt: previousLastSeen, url: '/'}, now.toDate()));
|
|
assert(spy.calledOnceWithExactly({
|
|
last_seen_at: now.format('YYYY-MM-DD HH:mm:ss')
|
|
}, {
|
|
id: '1'
|
|
}), 'The LastSeenAtUpdater should attempt a member update with the current date.');
|
|
});
|
|
|
|
it('Doesn\'t update when last_seen_at is too recent', async function () {
|
|
const now = moment('2022-02-28T18:00:00Z');
|
|
const previousLastSeen = moment('2022-02-28T00:00:00Z').toISOString();
|
|
const spy = sinon.spy();
|
|
new LastSeenAtUpdater({
|
|
memberModel: {
|
|
update: spy
|
|
}
|
|
});
|
|
DomainEvents.dispatch(MemberPageViewEvent.create({memberId: '1', memberLastSeenAt: previousLastSeen, url: '/'}, now.toDate()));
|
|
assert(spy.notCalled, 'The LastSeenAtUpdater should\'t update a member when the previous last_seen_at is close to the event timestamp.');
|
|
});
|
|
|
|
it('Doesn\'t fire on other events', async function () {
|
|
const now = moment('2022-02-28T18:00:00Z');
|
|
const spy = sinon.spy();
|
|
new LastSeenAtUpdater({
|
|
memberModel: {
|
|
update: spy
|
|
}
|
|
});
|
|
DomainEvents.dispatch(MemberSubscribeEvent.create({memberId: '1', source: 'api'}, now.toDate()));
|
|
assert(spy.notCalled, 'The LastSeenAtUpdater should never fire on MemberPageViewEvent events.');
|
|
});
|
|
});
|