Ghost/ghost/admin/app
Kevin Ansfield d3447315ee Excluded all email related events from feeds when newsletter is disabled
refs https://github.com/TryGhost/Team/issues/1290

- added `{{members-event-filter}}` helper that can be used to build an event filter string that will always exclude email events when the newsletter is disabled
  - useful when used in conjunction with `{{members-event-fetcher}}` because the filter is automatically adjusted for you without needing additional logic or JS backing files for components
- updated dashboard and member screen activity widgets to use `{{members-event-filter}}`
- updated members-activity screen
  - updated to use `{{members-activity-filter}}` helper in the template which allowed for removal of filter generation in the controller
  - changed `@hideMemberOnlyEvents` to `@hiddenEvents` on `<MembersActivity::EventTypeFilter>` so that we can control which events are available in the filter based on newsletter enable/disable and presence of a filtered member
2022-01-27 19:19:15 +00:00
..
adapters Added initial wiring for offer screens 2021-10-06 20:01:25 +05:30
authenticators Made session.user a synchronous property rather than a promise 2021-07-08 14:54:31 +01:00
components Excluded all email related events from feeds when newsletter is disabled 2022-01-27 19:19:15 +00:00
controllers Excluded all email related events from feeds when newsletter is disabled 2022-01-27 19:19:15 +00:00
errors Improved validation process for members CSV import 2020-07-07 00:28:30 +12:00
helpers Excluded all email related events from feeds when newsletter is disabled 2022-01-27 19:19:15 +00:00
initializers Resolved ember-simple-auth deprecations 2022-01-22 00:30:56 +00:00
mixins Refactored away CurrentUserSettings mixin (#2200) 2022-01-17 10:05:27 +00:00
models Removed Archived Tiers from Portal settings 2022-01-24 12:12:15 +02:00
modifiers Added scroll-into-view behavior when opening gif selector 2021-11-30 12:51:56 +00:00
routes Improved Email newsletter settings page (#2207) 2022-01-27 12:40:11 +01:00
serializers Added customThemeSettings service with all-records-in-one save request 2021-09-28 16:50:28 +01:00
services Refactored post email preview modal 2022-01-25 13:17:05 +00:00
session-stores Made session.user a synchronous property rather than a promise 2021-07-08 14:54:31 +01:00
styles Styled up the filters dropdown for activity with a few other tweaks 2022-01-27 17:14:06 +00:00
templates Excluded all email related events from feeds when newsletter is disabled 2022-01-27 19:19:15 +00:00
transforms Fixed product benefits not loaded on memberships settings 2021-09-17 12:41:56 +05:30
transitions Fixed autofocus not working on modal inputs 2018-06-04 17:48:57 +01:00
utils Added new free tier card with custom description/benefits (#2203) 2022-01-18 00:23:43 +05:30
validators Updated name validation for offer to restrict to 40 chars 2021-11-24 18:18:22 +05:30
app.js Updated scheduling copy 2020-10-02 10:45:49 +02:00
index.html Changed Apple touch icon to the new Ghost logo 2022-01-11 12:47:50 +01:00
README.md Convert Sass to Myth 2015-05-22 19:05:09 +01:00
router.js Added initial setup of members activity feed 2022-01-17 18:06:12 +00:00
transitions.js Removed tour feature 2021-03-02 14:29:26 +00:00

Ghost Admin Client

Ember.js application used as a client-side admin for the Ghost blogging platform. This readme is a work in progress guide aimed at explaining the specific nuances of the Ghost Ember app to contributors whose main focus is on this side of things.

CSS

We use pure CSS, which is pre-processed for backwards compatibility by Myth. We do not follow any strict CSS framework, however our general style is pretty similar to BEM.

Styles are primarily broken up into 4 main categories:

  • Patterns - are base level visual styles for HTML elements (eg. Buttons)
  • Components - are groups of patterns used to create a UI component (eg. Modals)
  • Layouts - are groups of components used to create application screens (eg. Settings)

All of these separate files are subsequently imported and compiled in app.css.

Front End Standards

  • 4 spaces for HTML & CSS indentation. Never tabs.
  • Double quotes only, never single quotes.
  • Use tags and elements appropriate for an HTML5 doctype (including self-closing tags)
  • Adhere to the Recess CSS property order.
  • Always a space after a property's colon (.e.g, display: block; and not display:block;).
  • End all lines with a semi-colon.
  • For multiple, comma-separated selectors, place each selector on its own line.
  • Use js- prefixed classes for JavaScript hooks into the DOM, and never use these in CSS as per Slightly Obtrusive JavaSript
  • Avoid over-nesting CSS. Never nest more than 3 levels deep.
  • Use comments to explain "why" not "what" (Good: This requires a z-index in order to appear above mobile navigation. Bad: This is a thing which is always on top!)