mirror of
https://github.com/TryGhost/Ghost.git
synced 2024-12-30 14:22:07 +03:00
b00d9fee6d
refs #2182 * 🔥 Remove unused options from server init - this is left over from old code and is now unused * 🎨 Move knex-migrator check to db health - Move complex check function into own module - Call module from server/index.js - This just improves the readability of server/index.js * 🔥 Remove old comments - These comments all make no sense now! * 🎨 ⏱ Move model init out of promise chain - Model.init() does not return a promise - Therefore, we can move it to the top of the init function, outside of the promise change - This should be a minor optimisation, and again improves readability /clarity of what's happening * ✨ ⁉️ Move DBHash init / first run to Settings model - this structure is left over from when we had code we executed on the first run of Ghost - the implementation used the API to initialise one setting before populateDefaults is called - this had lots of dependencies - the whole model, API, and permissions structure had to be initialised for it to work - the new implementation is simpler, it captures the dbHash getting initialised during populateDefaults() - it also adds an event, so we can do first-run code later if we really want to (or maybe apps can?!) - perhaps this is hiding behaviour, and there's a nicer way to do it, but populateDefaults seems like a sane place to populate a default setting 😁 * ⏱ Optimise require order so config is first - the first require to config will cause the files to be read etc - this ensures that it happens early, and isn't confusingly timed as part of loading a different module * 🎨 Simplify settings model changes
41 lines
1.6 KiB
JavaScript
41 lines
1.6 KiB
JavaScript
var KnexMigrator = require('knex-migrator'),
|
|
config = require('../../config'),
|
|
errors = require('../../errors'),
|
|
models = require('../../models');
|
|
|
|
module.exports.check = function healthCheck() {
|
|
var knexMigrator = new KnexMigrator({
|
|
knexMigratorFilePath: config.get('paths:appRoot')
|
|
});
|
|
|
|
return knexMigrator.isDatabaseOK()
|
|
.catch(function (outerErr) {
|
|
if (outerErr.code === 'DB_NOT_INITIALISED') {
|
|
throw outerErr;
|
|
}
|
|
|
|
// CASE: migration table does not exist, figure out if database is compatible
|
|
return models.Settings.findOne({key: 'databaseVersion', context: {internal: true}})
|
|
.then(function (response) {
|
|
// CASE: no db version key, database is compatible
|
|
if (!response) {
|
|
throw outerErr;
|
|
}
|
|
|
|
throw new errors.DatabaseVersionError({
|
|
message: 'Your database version is not compatible with Ghost 1.0.0 Alpha (master branch)',
|
|
context: 'Want to keep your DB? Use Ghost < 1.0.0 or the "stable" branch. Otherwise please delete your DB and restart Ghost.',
|
|
help: 'More information on the Ghost 1.0.0 Alpha at https://support.ghost.org/v1-0-alpha'
|
|
});
|
|
})
|
|
.catch(function (err) {
|
|
// CASE: settings table does not exist
|
|
if (err.errno === 1 || err.errno === 1146) {
|
|
throw outerErr;
|
|
}
|
|
|
|
throw err;
|
|
});
|
|
});
|
|
};
|