TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-12-24 19:33:02 +03:00
Code Issues Projects Releases Wiki Activity
d6b7ebb517
Ghost/ghost/core/test
History
Nicholas Mizoguchi d6b7ebb517
Enforced more Mocha lint rules (#19720) 
ref https://github.com/TryGhost/Ghost/issues/11038

1. Enforced lint rule
**[ghost/mocha/no-identical-title](https://github.com/lo1tuma/eslint-plugin-mocha/blob/main/docs/rules/no-identical-title.md)**
- Fixed relevant tests
2. Enforced lint rule
**[ghost/mocha/max-top-level-suites](https://github.com/lo1tuma/eslint-plugin-mocha/blob/main/docs/rules/max-top-level-suites.md)**
- No required fixes, as tests are compliant already

#### Additional details
Specifically for `ghost/mocha/no-identical-title` most fixes were simple
test description updates. Added comments to aid the PR review for the
ones that had relevant changes, and might require more attention. They
are as follows:
*
[e2e-api/admin/invites.test.js](https://github.com/TryGhost/Ghost/pull/19720#discussion_r1496397548):
Removed duplicated test (exact same code on both);
*
[e2e-api/admin/members.test.js](https://github.com/TryGhost/Ghost/pull/19720#discussion_r1496399107):
From the[ PR this was
introduced](73466c1c40 (diff-4dbc7e96e356428561085147e00e9acb5c71b58d4c1bd3d9fc9ac30e77c45be0L236-L237))
seems like author based his test on an existing one but possibly forgot
to rename it;
*
[unit/api/canary/utils/serializers/input/pages.test.js](https://github.com/TryGhost/Ghost/pull/19720#discussion_r1496400143):
The [page filter](https://github.com/TryGhost/Ghost/pull/14829/files)
was removed, so changed the description accordingly;
*
[unit/api/canary/utils/serializers/input/posts.test.js](https://github.com/TryGhost/Ghost/pull/19720#discussion_r1496400329):
The [page filter](https://github.com/TryGhost/Ghost/pull/14829/files)
was removed, so changed the description accordingly;
*
[unit/frontend/services/rendering/templates.test.js](https://github.com/TryGhost/Ghost/pull/19720#discussion_r1496402430):
Removed duplicated test
*
[unit/server/models/post.test.js](https://github.com/TryGhost/Ghost/pull/19720#discussion_r1496403529):
the change in [this
PR](https://github.com/TryGhost/Ghost/pull/14586/files#diff-c351cb589adefbb886570cfadb33b33eb8fdc12bde1024d1188cd18c165fc5e8L1010)
made three tests here mostly the same. Deduplicated them and kept only
one.
2024-04-16 09:37:06 +02:00
..
e2e-api Enforced more Mocha lint rules (#19720) 2024-04-16 09:37:06 +02:00
e2e-browser Enforced more Mocha lint rules (#19720) 2024-04-16 09:37:06 +02:00
e2e-frontend Added new member signup flow behind labs flag (#19986) 2024-04-04 15:25:41 -07:00
e2e-server Enforced more Mocha lint rules (#19720) 2024-04-16 09:37:06 +02:00
e2e-webhooks Cleaned up lexicalEditor labs flag, switched Post model to lexical-by-default (#18607) 2023-10-23 17:51:34 +01:00
integration Enforced more Mocha lint rules (#19720) 2024-04-16 09:37:06 +02:00
regression Enforced more Mocha lint rules (#19720) 2024-04-16 09:37:06 +02:00
unit Enforced more Mocha lint rules (#19720) 2024-04-16 09:37:06 +02:00
utils Optimised email stats aggregation query for typical column usage 2024-04-03 16:27:23 +01:00
.eslintignore ✨ Added Source as the new default theme 2023-10-03 14:02:08 +02:00
.eslintrc.js Enforced more Mocha lint rules (#19720) 2024-04-16 09:37:06 +02:00