mirror of
https://github.com/TryGhost/Ghost.git
synced 2024-12-19 00:11:49 +03:00
d81bc91bd2
refs #7116, refs #2001 - Changes the way Ghost errors are implemented to benefit from proper inheritance - Moves all error definitions into a single file - Changes the error constructor to take an options object, rather than needing the arguments to be passed in the correct order. - Provides a wrapper so that any errors that haven't already been converted to GhostErrors get converted before they are displayed. Summary of changes: * 🐛 set NODE_ENV in config handler * ✨ add GhostError implementation (core/server/errors.js) - register all errors in one file - inheritance from GhostError - option pattern * 🔥 remove all error files * ✨ wrap all errors into GhostError in case of HTTP * 🎨 adaptions - option pattern for errors - use GhostError when needed * 🎨 revert debug deletion and add TODO for error id's
203 lines
7.6 KiB
JavaScript
203 lines
7.6 KiB
JavaScript
var sinon = require('sinon'),
|
|
should = require('should'),
|
|
express = require('express'),
|
|
Promise = require('bluebird'),
|
|
fs = require('fs'),
|
|
hbs = require('express-hbs'),
|
|
themeHandler = require('../../../server/middleware/theme-handler'),
|
|
logging = require('../../../server/logging'),
|
|
api = require('../../../server/api'),
|
|
configUtils = require('../../utils/configUtils'),
|
|
sandbox = sinon.sandbox.create();
|
|
|
|
describe('Theme Handler', function () {
|
|
var req, res, next, blogApp;
|
|
|
|
beforeEach(function () {
|
|
req = sinon.spy();
|
|
res = sinon.spy();
|
|
next = sinon.spy();
|
|
blogApp = express();
|
|
req.app = blogApp;
|
|
});
|
|
|
|
afterEach(function () {
|
|
sandbox.restore();
|
|
configUtils.restore();
|
|
});
|
|
|
|
describe('ghostLocals', function () {
|
|
it('sets all locals', function () {
|
|
req.path = '/awesome-post';
|
|
|
|
themeHandler.ghostLocals(req, res, next);
|
|
|
|
res.locals.should.be.an.Object();
|
|
should.exist(res.locals.version);
|
|
should.exist(res.locals.safeVersion);
|
|
res.locals.relativeUrl.should.equal(req.path);
|
|
next.called.should.be.true();
|
|
});
|
|
});
|
|
|
|
describe('activateTheme', function () {
|
|
it('should activate new theme with partials', function () {
|
|
var fsStub = sandbox.stub(fs, 'stat', function (path, cb) {
|
|
cb(null, {isDirectory: function () { return true; }});
|
|
}),
|
|
hbsStub = sandbox.spy(hbs, 'express3');
|
|
|
|
themeHandler.activateTheme(blogApp, 'casper');
|
|
|
|
fsStub.calledOnce.should.be.true();
|
|
hbsStub.calledOnce.should.be.true();
|
|
hbsStub.firstCall.args[0].should.be.an.Object().and.have.property('partialsDir');
|
|
hbsStub.firstCall.args[0].partialsDir.should.have.lengthOf(2);
|
|
blogApp.get('activeTheme').should.equal('casper');
|
|
});
|
|
|
|
it('should activate new theme without partials', function () {
|
|
var fsStub = sandbox.stub(fs, 'stat', function (path, cb) {
|
|
cb(null, null);
|
|
}),
|
|
hbsStub = sandbox.spy(hbs, 'express3');
|
|
|
|
themeHandler.activateTheme(blogApp, 'casper');
|
|
|
|
fsStub.calledOnce.should.be.true();
|
|
hbsStub.calledOnce.should.be.true();
|
|
hbsStub.firstCall.args[0].should.be.an.Object().and.have.property('partialsDir');
|
|
hbsStub.firstCall.args[0].partialsDir.should.have.lengthOf(1);
|
|
blogApp.get('activeTheme').should.equal('casper');
|
|
});
|
|
});
|
|
|
|
describe('configHbsForContext', function () {
|
|
it('handles non secure context', function () {
|
|
res.locals = {};
|
|
themeHandler.configHbsForContext(req, res, next);
|
|
|
|
should.not.exist(res.locals.secure);
|
|
next.called.should.be.true();
|
|
});
|
|
|
|
it('handles secure context', function () {
|
|
var themeOptSpy = sandbox.stub(hbs, 'updateTemplateOptions');
|
|
req.secure = true;
|
|
res.locals = {};
|
|
configUtils.set({urlSSL: 'https://secure.blog'});
|
|
|
|
themeHandler.configHbsForContext(req, res, next);
|
|
|
|
themeOptSpy.calledOnce.should.be.true();
|
|
themeOptSpy.firstCall.args[0].should.be.an.Object().and.have.property('data');
|
|
themeOptSpy.firstCall.args[0].data.should.be.an.Object().and.have.property('blog');
|
|
themeOptSpy.firstCall.args[0].data.blog.should.be.an.Object().and.have.property('url');
|
|
themeOptSpy.firstCall.args[0].data.blog.url.should.eql('https://secure.blog');
|
|
res.locals.secure.should.equal(true);
|
|
next.called.should.be.true();
|
|
});
|
|
|
|
it('sets view path', function () {
|
|
req.secure = true;
|
|
res.locals = {};
|
|
blogApp.set('activeTheme', 'casper');
|
|
|
|
themeHandler.configHbsForContext(req, res, next);
|
|
|
|
blogApp.get('views').should.not.be.undefined();
|
|
});
|
|
|
|
it('sets view path', function () {
|
|
req.secure = true;
|
|
res.locals = {};
|
|
blogApp.set('activeTheme', 'casper');
|
|
|
|
themeHandler.configHbsForContext(req, res, next);
|
|
|
|
blogApp.get('views').should.not.be.undefined();
|
|
});
|
|
});
|
|
|
|
describe('updateActiveTheme', function () {
|
|
it('updates the active theme if changed', function (done) {
|
|
var activateThemeSpy = sandbox.spy(themeHandler, 'activateTheme');
|
|
|
|
sandbox.stub(api.settings, 'read').withArgs(sandbox.match.has('key', 'activeTheme')).returns(Promise.resolve({
|
|
settings: [{
|
|
key: 'activeKey',
|
|
value: 'casper'
|
|
}]
|
|
}));
|
|
blogApp.set('activeTheme', 'not-casper');
|
|
configUtils.set({paths: {availableThemes: {casper: {}}}});
|
|
|
|
themeHandler.updateActiveTheme(req, res, function () {
|
|
activateThemeSpy.called.should.be.true();
|
|
done();
|
|
});
|
|
});
|
|
|
|
it('does not update the active theme if not changed', function (done) {
|
|
var activateThemeSpy = sandbox.spy(themeHandler, 'activateTheme');
|
|
sandbox.stub(api.settings, 'read').withArgs(sandbox.match.has('key', 'activeTheme')).returns(Promise.resolve({
|
|
settings: [{
|
|
key: 'activeKey',
|
|
value: 'casper'
|
|
}]
|
|
}));
|
|
blogApp.set('activeTheme', 'casper');
|
|
configUtils.set({paths: {availableThemes: {casper: {}}}});
|
|
|
|
themeHandler.updateActiveTheme(req, res, function () {
|
|
activateThemeSpy.called.should.be.false();
|
|
done();
|
|
});
|
|
});
|
|
|
|
it('throws error if theme is missing', function (done) {
|
|
var activateThemeSpy = sandbox.spy(themeHandler, 'activateTheme');
|
|
|
|
sandbox.stub(api.settings, 'read').withArgs(sandbox.match.has('key', 'activeTheme')).returns(Promise.resolve({
|
|
settings: [{
|
|
key: 'activeKey',
|
|
value: 'rasper'
|
|
}]
|
|
}));
|
|
|
|
blogApp.set('activeTheme', 'not-casper');
|
|
configUtils.set({paths: {availableThemes: {casper: {}}}});
|
|
|
|
themeHandler.updateActiveTheme(req, res, function (err) {
|
|
should.exist(err);
|
|
activateThemeSpy.called.should.be.false();
|
|
err.message.should.eql('The currently active theme "rasper" is missing.');
|
|
done();
|
|
});
|
|
});
|
|
|
|
it('throws only warns if theme is missing for admin req', function (done) {
|
|
var activateThemeSpy = sandbox.spy(themeHandler, 'activateTheme'),
|
|
loggingWarnStub = sandbox.spy(logging, 'warn');
|
|
|
|
sandbox.stub(api.settings, 'read').withArgs(sandbox.match.has('key', 'activeTheme')).returns(Promise.resolve({
|
|
settings: [{
|
|
key: 'activeKey',
|
|
value: 'rasper'
|
|
}]
|
|
}));
|
|
|
|
res.isAdmin = true;
|
|
blogApp.set('activeTheme', 'not-casper');
|
|
configUtils.set({paths: {availableThemes: {casper: {}}}});
|
|
|
|
themeHandler.updateActiveTheme(req, res, function () {
|
|
activateThemeSpy.called.should.be.false();
|
|
loggingWarnStub.called.should.be.true();
|
|
loggingWarnStub.calledWith('The currently active theme "rasper" is missing.').should.be.true();
|
|
done();
|
|
});
|
|
});
|
|
});
|
|
});
|