Ghost/ghost/admin
Kevin Ansfield daa36a91b1
Fixed infinite save loop due to missing post_revisions include on saves (#18597)
refs edcd6caf2b
refs 56f2832754

- although we added an include for `post_revisions` when fetching a post for editing we didn't have the same `include` param added to saves meaning our revisions list was wiped from the store on each update
- on leaving the editor we check the last post revision to see if anything has changed and we need to save again, but with it being wiped and not being re-populated on save it meant the check always failed leading to an infinite loop of saves
- updated the posts and pages adapters to use the full includes param on create/update requests so we don't lose what we're trying to compare against
2023-10-12 19:16:45 +00:00
..
app Fixed infinite save loop due to missing post_revisions include on saves (#18597) 2023-10-12 19:16:45 +00:00
config Updated Koenig-Lexical bundling 2023-10-04 12:50:21 +02:00
lib Deleted all Admin code relating to the old editor (#18580) 2023-10-12 13:17:39 +01:00
mirage Deleted all Admin code relating to the old editor (#18580) 2023-10-12 13:17:39 +01:00
public/assets Deleted all Admin code relating to the old editor (#18580) 2023-10-12 13:17:39 +01:00
tests Deleted all Admin code relating to the old editor (#18580) 2023-10-12 13:17:39 +01:00
.editorconfig deps: ember-cli@2.8.0 2016-10-07 17:32:30 +01:00
.ember-cli Co-located component template files 2020-05-18 13:14:08 +01:00
.eslintignore Updated Ember dependencies to 3.24 (#2221) 2022-01-22 11:24:26 +00:00
.eslintrc.js Added eslint rule for file naming convention 2023-05-09 12:34:34 -04:00
.lint-todo Deleted all Admin code relating to the old editor (#18580) 2023-10-12 13:17:39 +01:00
.lint-todorc.js Reset linter warnings with longer decay times 2022-05-09 12:57:19 +01:00
.template-lintrc.js Update dependency ember-template-lint to v5.3.0 (#16062) 2023-01-04 09:39:32 +00:00
.watchmanconfig deps: ember-cli@1.13.13 2015-11-30 11:21:39 -06:00
ember-cli-build.js Deleted all Admin code relating to the old editor (#18580) 2023-10-12 13:17:39 +01:00
ember-cli-update.json Updated core files to match ember-cli new output 2020-08-03 09:24:58 +01:00
jsconfig.json 🐛 Fixed beta editor HTML cards auto-closing tags when rendering 2023-06-19 14:39:51 +02:00
package.json Deleted all Admin code relating to the old editor (#18580) 2023-10-12 13:17:39 +01:00
README.md 2023 2023-08-03 20:40:44 +01:00
testem.js Only show failed tests in Admin CI output 2022-08-31 15:53:27 +01:00

Ghost-Admin

This is the home of the Ember.js-based Admin app that ships with Ghost.

Running tests

Build and run tests once:

TZ=UTC yarn test

Note the TZ=UTC environment variable which is currently required to get tests working if your system timezone doesn't match UTC.

If you are serving the admin app (e.g., when running yarn serve, or when running yarn dev in the main Ghost project), you can also run the tests in your browser by going to http://localhost:4200/tests.

This has the additional benefit that you can use await this.pauseTest() in your tests to temporarily pause tests (best to also add this.timeout(0); to avoid timeouts). This allows you to inspect the DOM in your browser to debug tests. You can resume tests by running resumeTest() in your browser console.

More information

Writing tests

When writing tests and not using the http://localhost:4200/tests browser tests, it can be easier to have a separate watching build that builds the project for the test environment (this drastically reduces the time you have to wait when running tests):

yarn build --environment=test -w -o="dist-test"

After that, you can easily run tests locally:

Run all tests:

TZ=UTC yarn test 1 --path="dist-test"

To have a cleaner output:

TZ=UTC yarn test 1 --reporter dot  --path="dist-test"

This shows a dot (.) for every successful test, and F for every failed test. At the end, it will only show the output of the failed tests.

To run a specific test file:

TZ=UTC yarn test 1 --reporter dot  --path="dist-test" -mp=tests/acceptance/settings/newsletters-test.js

Hint: you can easily copy the path of a test in VSCode by right clicking on the test file and choosing Copy Relative Path.

To have a full list of the available options, run

ember exam --help

Copyright & License

Copyright (c) 2013-2023 Ghost Foundation - Released under the MIT license. Ghost and the Ghost Logo are trademarks of Ghost Foundation Ltd. Please see our trademark policy for info on acceptable usage.