mirror of
https://github.com/TryGhost/Ghost.git
synced 2024-12-23 02:41:50 +03:00
22e13acd65
- All var declarations are now const or let as per ES6 - All comma-separated lists / chained declarations are now one declaration per line - This is for clarity/readability but also made running the var-to-const/let switch smoother - ESLint rules updated to match How this was done: - npm install -g jscodeshift - git clone https://github.com/cpojer/js-codemod.git - git clone git@github.com:TryGhost/Ghost.git shallow-ghost - cd shallow-ghost - jscodeshift -t ../js-codemod/transforms/unchain-variables.js . -v=2 - jscodeshift -t ../js-codemod/transforms/no-vars.js . -v=2 - yarn - yarn test - yarn lint / fix various lint errors (almost all indent) by opening files and saving in vscode - grunt test-regression - sorted!
291 lines
10 KiB
JavaScript
291 lines
10 KiB
JavaScript
const should = require('should');
|
|
const sinon = require('sinon');
|
|
const _ = require('lodash');
|
|
const testUtils = require('../../../../utils');
|
|
const helpers = require('../../../../../core/frontend/services/routing/helpers');
|
|
const labs = require('../../../../../core/server/services/labs');
|
|
|
|
describe('Contexts', function () {
|
|
let req;
|
|
let res;
|
|
let data;
|
|
|
|
beforeEach(function () {
|
|
req = {
|
|
params: {},
|
|
body: {}
|
|
};
|
|
res = {
|
|
locals: {},
|
|
routerOptions: {}
|
|
};
|
|
data = {};
|
|
});
|
|
|
|
afterEach(function () {
|
|
sinon.restore();
|
|
});
|
|
|
|
describe('Unknown', function () {
|
|
it('should return empty array with no error if all parameters are empty', function () {
|
|
// Reset all parameters to empty
|
|
req = {};
|
|
res = {};
|
|
data = {};
|
|
|
|
helpers.context(req, res, data);
|
|
|
|
should.exist(res.locals.context);
|
|
res.locals.context.should.be.an.Array().with.lengthOf(0);
|
|
});
|
|
|
|
it('should return empty array with no error with basic parameters', function () {
|
|
helpers.context(req, res, data);
|
|
|
|
should.exist(res.locals.context);
|
|
res.locals.context.should.be.an.Array().with.lengthOf(0);
|
|
});
|
|
});
|
|
|
|
describe('index context', function () {
|
|
it('should correctly identify index channel', function () {
|
|
res.locals.relativeUrl = '/does/not/matter/';
|
|
res.routerOptions.context = ['index'];
|
|
|
|
helpers.context(req, res, data);
|
|
|
|
should.exist(res.locals.context);
|
|
res.locals.context.should.be.an.Array().with.lengthOf(1);
|
|
res.locals.context[0].should.eql('index');
|
|
});
|
|
|
|
it('should correctly identify / as home', function () {
|
|
res.locals.relativeUrl = '/';
|
|
res.routerOptions.context = ['index'];
|
|
|
|
// Execute test
|
|
helpers.context(req, res, data);
|
|
|
|
// Check context
|
|
should.exist(res.locals.context);
|
|
res.locals.context.should.be.an.Array().with.lengthOf(2);
|
|
res.locals.context[0].should.eql('home');
|
|
res.locals.context[1].should.eql('index');
|
|
});
|
|
|
|
it('will not identify / as index without config', function () {
|
|
res.locals.relativeUrl = '/';
|
|
res.routerOptions.context = [];
|
|
|
|
// Execute test
|
|
helpers.context(req, res, data);
|
|
|
|
// Check context
|
|
should.exist(res.locals.context);
|
|
res.locals.context.should.be.an.Array().with.lengthOf(1);
|
|
res.locals.context[0].should.eql('home');
|
|
});
|
|
|
|
it('will not identify /page/2/ as index & paged without page param', function () {
|
|
res.locals.relativeUrl = '/page/2/';
|
|
res.routerOptions.context = ['index'];
|
|
|
|
helpers.context(req, res, data);
|
|
|
|
should.exist(res.locals.context);
|
|
res.locals.context.should.be.an.Array().with.lengthOf(1);
|
|
res.locals.context[0].should.eql('index');
|
|
});
|
|
|
|
it('should identify /page/2/ as index & paged with page param', function () {
|
|
res.locals.relativeUrl = '/page/2/';
|
|
req.params.page = 2;
|
|
res.routerOptions.context = ['index'];
|
|
|
|
helpers.context(req, res, data);
|
|
|
|
should.exist(res.locals.context);
|
|
res.locals.context.should.be.an.Array().with.lengthOf(2);
|
|
res.locals.context[0].should.eql('paged');
|
|
res.locals.context[1].should.eql('index');
|
|
});
|
|
});
|
|
|
|
describe('Tag', function () {
|
|
it('should correctly identify tag channel', function () {
|
|
res.locals.relativeUrl = '/tag/getting-started/';
|
|
res.routerOptions.context = ['tag'];
|
|
|
|
helpers.context(req, res, data);
|
|
|
|
should.exist(res.locals.context);
|
|
res.locals.context.should.be.an.Array().with.lengthOf(1);
|
|
res.locals.context[0].should.eql('tag');
|
|
});
|
|
|
|
it('will not identify tag channel url without config', function () {
|
|
res.locals.relativeUrl = '/tag/getting-started/';
|
|
res.routerOptions.context = [];
|
|
|
|
helpers.context(req, res, data);
|
|
|
|
should.exist(res.locals.context);
|
|
res.locals.context.should.be.an.Array().with.lengthOf(0);
|
|
});
|
|
|
|
it('will not identify /page/2/ as paged without page param', function () {
|
|
res.locals.relativeUrl = '/tag/getting-started/page/2/';
|
|
res.routerOptions.context = ['tag'];
|
|
|
|
helpers.context(req, res, data);
|
|
|
|
should.exist(res.locals.context);
|
|
res.locals.context.should.be.an.Array().with.lengthOf(1);
|
|
res.locals.context[0].should.eql('tag');
|
|
});
|
|
|
|
it('should correctly identify /page/2/ as paged with page param', function () {
|
|
res.locals.relativeUrl = '/tag/getting-started/page/2/';
|
|
req.params.page = 2;
|
|
res.routerOptions.context = ['tag'];
|
|
|
|
helpers.context(req, res, data);
|
|
|
|
should.exist(res.locals.context);
|
|
res.locals.context.should.be.an.Array().with.lengthOf(2);
|
|
res.locals.context[0].should.eql('paged');
|
|
res.locals.context[1].should.eql('tag');
|
|
});
|
|
});
|
|
|
|
describe('Author', function () {
|
|
it('should correctly identify author channel', function () {
|
|
res.locals.relativeUrl = '/author/pat/';
|
|
res.routerOptions.context = ['author'];
|
|
|
|
helpers.context(req, res, data);
|
|
|
|
should.exist(res.locals.context);
|
|
res.locals.context.should.be.an.Array().with.lengthOf(1);
|
|
res.locals.context[0].should.eql('author');
|
|
});
|
|
|
|
it('will not identify author channel url without config', function () {
|
|
res.locals.relativeUrl = '/author/pat/';
|
|
res.routerOptions.context = [];
|
|
|
|
helpers.context(req, res, data);
|
|
|
|
should.exist(res.locals.context);
|
|
res.locals.context.should.be.an.Array().with.lengthOf(0);
|
|
});
|
|
|
|
it('will not identify /page/2/ as paged without page param', function () {
|
|
res.locals.relativeUrl = '/author/pat/page/2/';
|
|
res.routerOptions.context = ['author'];
|
|
|
|
helpers.context(req, res, data);
|
|
|
|
should.exist(res.locals.context);
|
|
res.locals.context.should.be.an.Array().with.lengthOf(1);
|
|
res.locals.context[0].should.eql('author');
|
|
});
|
|
|
|
it('should correctly identify /page/2/ as paged with page param', function () {
|
|
res.locals.relativeUrl = '/author/pat/page/2/';
|
|
req.params.page = 2;
|
|
res.routerOptions.context = ['author'];
|
|
|
|
helpers.context(req, res, data);
|
|
|
|
should.exist(res.locals.context);
|
|
res.locals.context.should.be.an.Array().with.lengthOf(2);
|
|
res.locals.context[0].should.eql('paged');
|
|
res.locals.context[1].should.eql('author');
|
|
});
|
|
});
|
|
|
|
describe('Custom', function () {
|
|
it('will use a custom context', function () {
|
|
res.locals.relativeUrl = 'anything';
|
|
res.routerOptions.context = ['custom-context', 'test'];
|
|
|
|
helpers.context(req, res, data);
|
|
|
|
should.exist(res.locals.context);
|
|
res.locals.context.should.be.an.Array().with.lengthOf(2);
|
|
res.locals.context[0].should.eql('custom-context');
|
|
res.locals.context[1].should.eql('test');
|
|
});
|
|
});
|
|
|
|
describe('Posts & Pages', function () {
|
|
it('ensure correct context', function () {
|
|
res.locals.relativeUrl = '/welcome-to-ghost/';
|
|
res.routerOptions.context = ['post'];
|
|
|
|
helpers.context(req, res, data);
|
|
|
|
should.exist(res.locals.context);
|
|
res.locals.context.should.be.an.Array().with.lengthOf(1);
|
|
res.locals.context[0].should.eql('post');
|
|
});
|
|
});
|
|
|
|
describe('Private', function () {
|
|
it('should correctly identify /private/ as the private route', function () {
|
|
res.locals.relativeUrl = '/private/?r=';
|
|
delete res.routerOptions;
|
|
|
|
helpers.context(req, res, data);
|
|
|
|
should.exist(res.locals.context);
|
|
res.locals.context.should.be.an.Array().with.lengthOf(1);
|
|
res.locals.context[0].should.eql('private');
|
|
});
|
|
});
|
|
|
|
describe('Subscribe', function () {
|
|
it('should not identify /subscribe/ as subscribe route if labs flag NOT set', function () {
|
|
res.locals.relativeUrl = '/subscribe/';
|
|
sinon.stub(labs, 'isSet').withArgs('subscribers').returns(false);
|
|
data.post = testUtils.DataGenerator.forKnex.createPost();
|
|
|
|
delete res.routerOptions;
|
|
helpers.context(req, res, data);
|
|
|
|
should.exist(res.locals.context);
|
|
res.locals.context.should.be.an.Array().with.lengthOf(1);
|
|
res.locals.context[0].should.eql('post');
|
|
});
|
|
});
|
|
|
|
describe('AMP', function () {
|
|
it('should correctly identify AMP post', function () {
|
|
res.locals.relativeUrl = '/welcome-to-ghost/amp/';
|
|
data.post = testUtils.DataGenerator.forKnex.createPost();
|
|
|
|
delete res.routerOptions;
|
|
helpers.context(req, res, data);
|
|
|
|
should.exist(res.locals.context);
|
|
res.locals.context.should.be.an.Array().with.lengthOf(2);
|
|
res.locals.context[0].should.eql('amp');
|
|
res.locals.context[1].should.eql('post');
|
|
});
|
|
|
|
it('should correctly identify AMP page', function () {
|
|
res.locals.relativeUrl = '/welcome-to-ghost/amp/';
|
|
data.page = testUtils.DataGenerator.forKnex.createPost({page: true});
|
|
|
|
delete res.routerOptions;
|
|
helpers.context(req, res, data);
|
|
|
|
should.exist(res.locals.context);
|
|
res.locals.context.should.be.an.Array().with.lengthOf(2);
|
|
res.locals.context[0].should.eql('amp');
|
|
res.locals.context[1].should.eql('page');
|
|
});
|
|
});
|
|
});
|