TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-11-30 11:54:33 +03:00
Code Issues Projects Releases Wiki Activity
e01ffa3620
Ghost/ghost/admin/app
History
Kevin Ansfield e01ffa3620 Always call _super when using Ember hooks 
no issue
- review use of Ember core hooks and add a call to `this._super` if missing
- fix a few occurrences of using the wrong component lifecycle hooks that could result in multiple/duplicate event handlers being attached

`_super` should always be called when overriding Ember's base hooks so that core functionality or app functionality added through extensions, mixins or addons is not lost. This is important as it guards against issues arising from later refactorings or core changes.

As example of lost functionality, there were a number of routes that extended from `AuthenticatedRoute` but then overrode the `beforeModel` hook without calling `_super` which meant that the route was no longer treated as authenticated.
2015-11-30 12:45:37 +00:00
..
adapters Use es6 across client and add ember-suave to enforce rules 2015-11-30 10:41:01 +00:00
assets/lib Use es6 across client and add ember-suave to enforce rules 2015-11-30 10:41:01 +00:00
authenticators Use es6 across client and add ember-suave to enforce rules 2015-11-30 10:41:01 +00:00
authorizers deps: ember-simple-auth@1.0.0 2015-10-18 13:17:02 -05:00
components Always call _super when using Ember hooks 2015-11-30 12:45:37 +00:00
controllers Always call _super when using Ember hooks 2015-11-30 12:45:37 +00:00
helpers Use es6 across client and add ember-suave to enforce rules 2015-11-30 10:41:01 +00:00
html uhbuhbyenow 2015-09-02 17:49:15 +02:00
initializers Use es6 across client and add ember-suave to enforce rules 2015-11-30 10:41:01 +00:00
instance-initializers Use es6 across client and add ember-suave to enforce rules 2015-11-30 10:41:01 +00:00
mirage Use es6 across client and add ember-suave to enforce rules 2015-11-30 10:41:01 +00:00
mixins Always call _super when using Ember hooks 2015-11-30 12:45:37 +00:00
models Use es6 across client and add ember-suave to enforce rules 2015-11-30 10:41:01 +00:00
routes Always call _super when using Ember hooks 2015-11-30 12:45:37 +00:00
serializers Use es6 across client and add ember-suave to enforce rules 2015-11-30 10:41:01 +00:00
services Use es6 across client and add ember-suave to enforce rules 2015-11-30 10:41:01 +00:00
session-stores deps: ember-simple-auth@1.0.0 2015-10-18 13:17:02 -05:00
styles Update public API labs flag text 2015-11-17 21:28:16 +00:00
templates Unify mobile state in JS, drop resize 2015-11-25 11:54:08 -05:00
transforms Use es6 across client and add ember-suave to enforce rules 2015-11-30 10:41:01 +00:00
utils Use es6 across client and add ember-suave to enforce rules 2015-11-30 10:41:01 +00:00
validators Use es6 across client and add ember-suave to enforce rules 2015-11-30 10:41:01 +00:00
_config.yml The great migration (EAK -> ember-cli) 2015-03-11 12:37:41 -06:00
app.js Use es6 across client and add ember-suave to enforce rules 2015-11-30 10:41:01 +00:00
index.html Remove extra ember container 2015-05-22 19:05:14 +01:00
README.md Convert Sass to Myth 2015-05-22 19:05:09 +01:00
router.js Use es6 across client and add ember-suave to enforce rules 2015-11-30 10:41:01 +00:00

README.md

Ghost Admin Client

Ember.js application used as a client-side admin for the Ghost blogging platform. This readme is a work in progress guide aimed at explaining the specific nuances of the Ghost Ember app to contributors whose main focus is on this side of things.

CSS

We use pure CSS, which is pre-processed for backwards compatibility by Myth. We do not follow any strict CSS framework, however our general style is pretty similar to BEM.

Styles are primarily broken up into 4 main categories:

  • Patterns - are base level visual styles for HTML elements (eg. Buttons)
  • Components - are groups of patterns used to create a UI component (eg. Modals)
  • Layouts - are groups of components used to create application screens (eg. Settings)

All of these separate files are subsequently imported and compiled in app.css.

Front End Standards

  • 4 spaces for HTML & CSS indentation. Never tabs.
  • Double quotes only, never single quotes.
  • Use tags and elements appropriate for an HTML5 doctype (including self-closing tags)
  • Adhere to the Recess CSS property order.
  • Always a space after a property's colon (.e.g, display: block; and not display:block;).
  • End all lines with a semi-colon.
  • For multiple, comma-separated selectors, place each selector on its own line.
  • Use js- prefixed classes for JavaScript hooks into the DOM, and never use these in CSS as per Slightly Obtrusive JavaSript
  • Avoid over-nesting CSS. Never nest more than 3 levels deep.
  • Use comments to explain "why" not "what" (Good: This requires a z-index in order to appear above mobile navigation. Bad: This is a thing which is always on top!)