mirror of
https://github.com/TryGhost/Ghost.git
synced 2024-12-21 09:52:06 +03:00
e060a4f811
no issue 🎨 simplify loader - use loadOneTheme for init - use loadOneTheme for init - move updateThemeList to the one place that it is used - this just reduces the surface area of the loader 🎨 Move init up to index temporarily - need to figure out what stuff goes in here as well as loading themes - will move it again later once I've got it figured out 🎨 Reorder & cleanup theme middleware - move the order in blog/app.js so that theme middleware isn't called for shared assets - add comments & cleanup in the middleware itself, for clarity 🎨 Simplify the logic in themes middleware - Separate out config dependent on settings changing and config dependent on request - Move blogApp.set('views') - no reason why this isn't in the theme activation method as it's actually simpler if it is there, we already know the active theme exists & can remove the if-guard 🎨 Improve error handling for missing theme - ensure we display a warning - don't have complex logic for handling errors - move loading of an empty hbs object into the error-handler as this will support more cases 🐛 Fix assetHash clearing bug on theme switch - asset hash wasn't correctly being set on theme switch 🎨 Remove themes.read & test loader instead - Previously, we've simplified loader & improved error handling - We are now able to completely remove theme.read as it's nothing more than a wrapper for package.read - This also means we can change our tests from testing the theme reader to loader
107 lines
3.8 KiB
JavaScript
107 lines
3.8 KiB
JavaScript
var debug = require('debug')('ghost:blog'),
|
|
path = require('path'),
|
|
|
|
// App requires
|
|
config = require('../config'),
|
|
storage = require('../storage'),
|
|
utils = require('../utils'),
|
|
|
|
// This should probably be an internal app
|
|
sitemapHandler = require('../data/xml/sitemap/handler'),
|
|
|
|
// routes
|
|
routes = require('./routes'),
|
|
|
|
// local middleware
|
|
cacheControl = require('../middleware/cache-control'),
|
|
urlRedirects = require('../middleware/url-redirects'),
|
|
errorHandler = require('../middleware/error-handler'),
|
|
maintenance = require('../middleware/maintenance'),
|
|
prettyURLs = require('../middleware/pretty-urls'),
|
|
serveSharedFile = require('../middleware/serve-shared-file'),
|
|
staticTheme = require('../middleware/static-theme'),
|
|
themeHandler = require('../middleware/theme-handler'),
|
|
customRedirects = require('../middleware/custom-redirects'),
|
|
serveFavicon = require('../middleware/serve-favicon');
|
|
|
|
module.exports = function setupBlogApp() {
|
|
debug('Blog setup start');
|
|
|
|
var blogApp = require('express')();
|
|
|
|
// ## App - specific code
|
|
// set the view engine
|
|
blogApp.set('view engine', 'hbs');
|
|
|
|
// you can extend Ghost with a custom redirects file
|
|
// see https://github.com/TryGhost/Ghost/issues/7707
|
|
customRedirects(blogApp);
|
|
|
|
// Static content/assets
|
|
// @TODO make sure all of these have a local 404 error handler
|
|
// Favicon
|
|
blogApp.use(serveFavicon());
|
|
// Ghost-Url
|
|
blogApp.use(serveSharedFile('shared/ghost-url.js', 'application/javascript', utils.ONE_HOUR_S));
|
|
blogApp.use(serveSharedFile('shared/ghost-url.min.js', 'application/javascript', utils.ONE_HOUR_S));
|
|
// Serve sitemap.xsl file
|
|
blogApp.use(serveSharedFile('sitemap.xsl', 'text/xsl', utils.ONE_DAY_S));
|
|
// Serve robots.txt if not found in theme
|
|
blogApp.use(serveSharedFile('robots.txt', 'text/plain', utils.ONE_HOUR_S));
|
|
// Serve blog images using the storage adapter
|
|
blogApp.use('/' + utils.url.STATIC_IMAGE_URL_PREFIX, storage.getStorage().serve());
|
|
|
|
// Theme middleware
|
|
// This should happen AFTER any shared assets are served, as it only changes things to do with templates
|
|
// At this point the active theme object is already updated, so we have the right path, so it can probably
|
|
// go after staticTheme() as well, however I would really like to simplify this and be certain
|
|
blogApp.use(themeHandler.updateActiveTheme);
|
|
blogApp.use(themeHandler.configHbsForContext);
|
|
debug('Themes done');
|
|
|
|
// Theme static assets/files
|
|
blogApp.use(staticTheme());
|
|
debug('Static content done');
|
|
|
|
// setup middleware for internal apps
|
|
// @TODO: refactor this to be a proper app middleware hook for internal & external apps
|
|
config.get('internalApps').forEach(function (appName) {
|
|
var app = require(path.join(config.get('paths').internalAppPath, appName));
|
|
if (app.hasOwnProperty('setupMiddleware')) {
|
|
app.setupMiddleware(blogApp);
|
|
}
|
|
});
|
|
|
|
// site map - this should probably be refactored to be an internal app
|
|
sitemapHandler(blogApp);
|
|
debug('Internal apps done');
|
|
|
|
// send 503 error page in case of maintenance
|
|
blogApp.use(maintenance);
|
|
|
|
// Force SSL if required
|
|
// must happen AFTER asset loading and BEFORE routing
|
|
blogApp.use(urlRedirects);
|
|
|
|
// Add in all trailing slashes & remove uppercase
|
|
// must happen AFTER asset loading and BEFORE routing
|
|
blogApp.use(prettyURLs);
|
|
|
|
// ### Caching
|
|
// Blog frontend is cacheable
|
|
blogApp.use(cacheControl('public'));
|
|
|
|
debug('General middleware done');
|
|
|
|
// Set up Frontend routes (including private blogging routes)
|
|
blogApp.use(routes());
|
|
|
|
// ### Error handlers
|
|
blogApp.use(errorHandler.pageNotFound);
|
|
blogApp.use(errorHandler.handleHTMLResponse);
|
|
|
|
debug('Blog setup end');
|
|
|
|
return blogApp;
|
|
};
|