mirror of
https://github.com/TryGhost/Ghost.git
synced 2024-12-20 09:22:49 +03:00
e060a4f811
no issue 🎨 simplify loader - use loadOneTheme for init - use loadOneTheme for init - move updateThemeList to the one place that it is used - this just reduces the surface area of the loader 🎨 Move init up to index temporarily - need to figure out what stuff goes in here as well as loading themes - will move it again later once I've got it figured out 🎨 Reorder & cleanup theme middleware - move the order in blog/app.js so that theme middleware isn't called for shared assets - add comments & cleanup in the middleware itself, for clarity 🎨 Simplify the logic in themes middleware - Separate out config dependent on settings changing and config dependent on request - Move blogApp.set('views') - no reason why this isn't in the theme activation method as it's actually simpler if it is there, we already know the active theme exists & can remove the if-guard 🎨 Improve error handling for missing theme - ensure we display a warning - don't have complex logic for handling errors - move loading of an empty hbs object into the error-handler as this will support more cases 🐛 Fix assetHash clearing bug on theme switch - asset hash wasn't correctly being set on theme switch 🎨 Remove themes.read & test loader instead - Previously, we've simplified loader & improved error handling - We are now able to completely remove theme.read as it's nothing more than a wrapper for package.read - This also means we can change our tests from testing the theme reader to loader
112 lines
4.5 KiB
JavaScript
112 lines
4.5 KiB
JavaScript
var _ = require('lodash'),
|
|
fs = require('fs'),
|
|
path = require('path'),
|
|
hbs = require('express-hbs'),
|
|
config = require('../config'),
|
|
utils = require('../utils'),
|
|
errors = require('../errors'),
|
|
i18n = require('../i18n'),
|
|
settingsCache = require('../settings/cache'),
|
|
themeList = require('../themes').list,
|
|
themeHandler;
|
|
|
|
themeHandler = {
|
|
// ### configHbsForContext Middleware
|
|
// Setup handlebars for the current context (admin or theme)
|
|
configHbsForContext: function configHbsForContext(req, res, next) {
|
|
// Static information, same for every request unless the settings change
|
|
// @TODO: bind this once and then update based on events?
|
|
var themeData = {
|
|
title: settingsCache.get('title'),
|
|
description: settingsCache.get('description'),
|
|
facebook: settingsCache.get('facebook'),
|
|
twitter: settingsCache.get('twitter'),
|
|
timezone: settingsCache.get('activeTimezone'),
|
|
navigation: settingsCache.get('navigation'),
|
|
posts_per_page: settingsCache.get('postsPerPage'),
|
|
icon: settingsCache.get('icon'),
|
|
cover: settingsCache.get('cover'),
|
|
logo: settingsCache.get('logo'),
|
|
amp: settingsCache.get('amp')
|
|
},
|
|
labsData = _.cloneDeep(settingsCache.get('labs'));
|
|
|
|
// Request-specific information
|
|
// These things are super dependent on the request, so they need to be in middleware
|
|
themeData.url = utils.url.urlFor('home', {secure: req.secure}, true);
|
|
|
|
// Pass 'secure' flag to the view engine
|
|
// so that templates can choose to render https or http 'url', see url utility
|
|
res.locals.secure = req.secure;
|
|
|
|
// @TODO: only do this if something changed?
|
|
hbs.updateTemplateOptions({
|
|
data: {
|
|
blog: themeData,
|
|
labs: labsData
|
|
}
|
|
});
|
|
|
|
next();
|
|
},
|
|
|
|
// ### Activate Theme
|
|
// Helper for updateActiveTheme
|
|
activateTheme: function activateTheme(blogApp, activeThemeName) {
|
|
var themePartialsPath = path.join(config.getContentPath('themes'), activeThemeName, 'partials'),
|
|
hbsOptions = {
|
|
partialsDir: [config.get('paths').helperTemplates],
|
|
onCompile: function onCompile(exhbs, source) {
|
|
return exhbs.handlebars.compile(source, {preventIndent: true});
|
|
}
|
|
};
|
|
|
|
fs.stat(themePartialsPath, function stat(err, stats) {
|
|
// Check that the theme has a partials directory before trying to use it
|
|
if (!err && stats && stats.isDirectory()) {
|
|
hbsOptions.partialsDir.push(themePartialsPath);
|
|
}
|
|
});
|
|
|
|
// reset the asset hash
|
|
config.set('assetHash', null);
|
|
// clear the view cache
|
|
blogApp.cache = {};
|
|
// Set the views and engine
|
|
blogApp.set('views', path.join(config.getContentPath('themes'), activeThemeName));
|
|
blogApp.engine('hbs', hbs.express3(hbsOptions));
|
|
|
|
// Set active theme variable on the express server
|
|
// Note: this is effectively the "mounted" theme, which has been loaded into the express app
|
|
blogApp.set('activeTheme', activeThemeName);
|
|
},
|
|
|
|
// ### updateActiveTheme
|
|
// Updates the blogApp's activeTheme variable and subsequently
|
|
// activates that theme's views with the hbs templating engine if it
|
|
// is not yet activated.
|
|
updateActiveTheme: function updateActiveTheme(req, res, next) {
|
|
var blogApp = req.app,
|
|
activeThemeName = settingsCache.get('activeTheme'),
|
|
mountedThemeName = blogApp.get('activeTheme');
|
|
|
|
// This means that the theme hasn't been loaded yet i.e. there is no active theme
|
|
if (!themeList.get(activeThemeName)) {
|
|
// This is the one place we ACTUALLY throw an error for a missing theme
|
|
// As it's a request we cannot serve
|
|
return next(new errors.InternalServerError({
|
|
message: i18n.t('errors.middleware.themehandler.missingTheme', {theme: activeThemeName})
|
|
}));
|
|
|
|
// If there is an active theme AND it has changed, call activate
|
|
} else if (activeThemeName !== mountedThemeName) {
|
|
// This is effectively "mounting" a theme into express, the theme is already "active"
|
|
themeHandler.activateTheme(blogApp, activeThemeName);
|
|
}
|
|
|
|
next();
|
|
}
|
|
};
|
|
|
|
module.exports = themeHandler;
|