Ghost/core/test/unit/middleware/static-theme_spec.js
Hannah Wolfe 47e00900cc 💄 🐷 Test consistency (#8199)
no issue

- change out should.equal for // jshint ignore:line
- ensure should is the first require in every test, and ALWAYS require
- make sinon the second require, and sandbox the last thing
- ALWAYS use sandbox, futureproofs tests against contributors who don't know it
- change require formatting
2017-03-21 09:24:11 +01:00

126 lines
3.9 KiB
JavaScript

var should = require('should'),
sinon = require('sinon'),
express = require('express'),
themeUtils = require('../../../server/themes'),
staticTheme = require('../../../server/middleware/static-theme'),
sandbox = sinon.sandbox.create();
describe('staticTheme', function () {
var expressStaticStub, activeThemeStub, req, res;
beforeEach(function () {
req = {};
res = {};
activeThemeStub = sandbox.stub(themeUtils, 'getActive').returns({
path: 'my/fake/path'
});
expressStaticStub = sandbox.spy(express, 'static');
});
afterEach(function () {
sandbox.restore();
});
it('should skip for .hbs file', function (done) {
req.path = 'mytemplate.hbs';
staticTheme()(req, res, function next() {
activeThemeStub.called.should.be.false();
expressStaticStub.called.should.be.false();
done();
});
});
it('should skip for .md file', function (done) {
req.path = 'README.md';
staticTheme()(req, res, function next() {
activeThemeStub.called.should.be.false();
expressStaticStub.called.should.be.false();
done();
});
});
it('should skip for .json file', function (done) {
req.path = 'sample.json';
staticTheme()(req, res, function next() {
activeThemeStub.called.should.be.false();
expressStaticStub.called.should.be.false();
done();
});
});
it('should call express.static for .css file', function (done) {
req.path = 'myvalidfile.css';
staticTheme()(req, res, function next() {
// Specifically gets called twice
activeThemeStub.calledTwice.should.be.true();
expressStaticStub.called.should.be.true();
// Check that express static gets called with the theme path + maxAge
should.exist(expressStaticStub.firstCall.args);
expressStaticStub.firstCall.args[0].should.eql('my/fake/path');
expressStaticStub.firstCall.args[1].should.be.an.Object().with.property('maxAge');
done();
});
});
it('should call express.static for .js file', function (done) {
req.path = 'myvalidfile.js';
staticTheme()(req, res, function next() {
// Specifically gets called twice
activeThemeStub.calledTwice.should.be.true();
expressStaticStub.called.should.be.true();
// Check that express static gets called with the theme path + maxAge
should.exist(expressStaticStub.firstCall.args);
expressStaticStub.firstCall.args[0].should.eql('my/fake/path');
expressStaticStub.firstCall.args[1].should.be.an.Object().with.property('maxAge');
done();
});
});
it('should not error if active theme is missing', function (done) {
req.path = 'myvalidfile.css';
// make the active theme not exist
activeThemeStub.returns(undefined);
staticTheme()(req, res, function next() {
activeThemeStub.calledOnce.should.be.true();
expressStaticStub.called.should.be.false();
done();
});
});
it('should NOT skip if file is on whitelist', function (done) {
req.path = 'manifest.json';
staticTheme()(req, res, function next() {
// Specifically gets called twice
activeThemeStub.calledTwice.should.be.true();
expressStaticStub.called.should.be.true();
// Check that express static gets called with the theme path + maxAge
should.exist(expressStaticStub.firstCall.args);
expressStaticStub.firstCall.args[0].should.eql('my/fake/path');
expressStaticStub.firstCall.args[1].should.be.an.Object().with.property('maxAge');
done();
});
});
});