mirror of
https://github.com/TryGhost/Ghost.git
synced 2024-12-20 17:32:15 +03:00
d19452147d
closes https://github.com/TryGhost/Team/issues/545 The price helper requires an object with amount & currency properties to work correctly. This updates the @price data object to expose these. In order to maintain backward compatibility with using the @price data as primitive number values, we add a valueOf method which returns the legacy dollar amount value. This means you can use {{price @price.monthly}} OR {{@price.monthly}} - the second of which will output the dollar amount. A new theme fixture was added to test both usages of the @price data |
||
|---|---|---|
| .. | ||
| broken-theme | ||
| casper | ||
| casper-1.4 | ||
| price-data-test-theme | ||
| test-theme | ||
| test-theme-channels | ||
| casper.zip | ||
| invalid.zip | ||
| README.md | ||
| valid.zip | ||
| warnings.zip | ||
Modifying theme fixtures
When a new rule is introduced in gscan one of these fixture files might break and you'll have to update a "zip" which isn't as easy as opening a text editor... It could become that one day but for now here are some commands to help out with the edit process
- Unzip the theme files, e.g.:
cd $CURRENT_DIR && unzip valid.zip -d valid - Make a change in the file which caused a warning/error/whatever
- Zip the files back:
zip -r valid.zip ./valid - Commit changed zip file:
git add valid.zip ;... you know the drill :)
Ideas for future improvements in theme tests:
- Decouple tests from file system as much as possible
- Track contents of what is in "zips" in source control. Right now, having a diff on a binary file is not useful at all