Ghost/ghost/admin/app
Kevin Ansfield e3db911108
🐛 Fixed confusing error state when publishing if member count is over hosting plan limit (#15473)
closes https://github.com/TryGhost/Team/issues/1885

- adds limit check for members to the `PublishOptions` class when it's constructed to set a `publishDisabledError` property if the limit check fails
  - if `publishOptions.publishDisabledCheck` is present, all publish options in the publish flow are disabled, the underlying error message is shown, and the continue button is removed to prevent filling in everything only to find at the end of the process that publishing fails
- added handling for a `HostLimitError` error from the API when confirming publishing so the proper underlying message is displayed instead of the confusing "Host limit error, cannot edit post" error
  - this is a backup measure for any instances where you're under the max members limit when starting the publish flow but are over the limit when you reach the end of the publish flow
2022-09-26 17:37:35 +01:00
..
adapters Fixed post/page API requests having incorrect ?include= params 2022-09-16 12:54:50 +01:00
authenticators Made session.user a synchronous property rather than a promise 2021-07-08 14:54:31 +01:00
components 🐛 Fixed confusing error state when publishing if member count is over hosting plan limit (#15473) 2022-09-26 17:37:35 +01:00
controllers Added basic post table and analytics page conditionals 2022-09-22 15:40:37 +02:00
errors Improved validation process for members CSV import 2020-07-07 00:28:30 +12:00
helpers Added the new URL design for events over in the members activity page too 2022-09-22 13:44:45 +01:00
initializers Resolved ember-simple-auth deprecations 2022-01-22 00:30:56 +00:00
mixins 🐛 Fixed pasting into the post tags input not working (#1739) 2022-08-03 11:14:12 +01:00
models Added protection for missing count in clickRate 2022-09-21 11:11:06 +02:00
modifiers Updated modifiers to resolve ember-modifier@4.x deprecations 2022-08-02 16:54:34 +01:00
routes Added lexical editor feature flag 2022-09-16 11:59:03 +01:00
serializers Fixed odd behavior with saving complimentary members 2022-08-17 20:53:34 +05:30
services 🐛 Fixed confusing error state when publishing if member count is over hosting plan limit (#15473) 2022-09-26 17:37:35 +01:00
session-stores Migrated session-store to native class syntax 2022-02-02 18:41:16 +00:00
styles Made the margins event between elements in the new post rows 2022-09-23 15:55:20 +01:00
templates Added target blank to links in the link table on post analytics 2022-09-23 15:23:59 +01:00
transforms Updated usage of the Tiers API (#2388) 2022-05-16 19:51:49 +01:00
transitions Fixed autofocus not working on modal inputs 2018-06-04 17:48:57 +01:00
utils 🐛 Fixed confusing error state when publishing if member count is over hosting plan limit (#15473) 2022-09-26 17:37:35 +01:00
validators 🐛 Fixed Hidden error in "Add tier" modal (#15361) 2022-09-13 09:23:54 +01:00
app.js Updated scheduling copy 2020-10-02 10:45:49 +02:00
index.html Updated loading animation 2022-09-16 13:44:58 +02:00
README.md Renamed "client" references to "admin" 2022-05-17 09:09:14 +01:00
router.js Added basic analytics page for posts 2022-09-13 11:00:45 +02:00
transitions.js Removed tour feature 2021-03-02 14:29:26 +00:00

Ghost Admin App

Ember.js application used as a client-side admin for the Ghost blogging platform. This readme is a work in progress guide aimed at explaining the specific nuances of the Ghost Ember app to contributors whose main focus is on this side of things.

CSS

We use pure CSS, which is pre-processed for backwards compatibility by Myth. We do not follow any strict CSS framework, however our general style is pretty similar to BEM.

Styles are primarily broken up into 4 main categories:

  • Patterns - are base level visual styles for HTML elements (eg. Buttons)
  • Components - are groups of patterns used to create a UI component (eg. Modals)
  • Layouts - are groups of components used to create application screens (eg. Settings)

All of these separate files are subsequently imported and compiled in app.css.

Front End Standards

  • 4 spaces for HTML & CSS indentation. Never tabs.
  • Double quotes only, never single quotes.
  • Use tags and elements appropriate for an HTML5 doctype (including self-closing tags)
  • Adhere to the Recess CSS property order.
  • Always a space after a property's colon (.e.g, display: block; and not display:block;).
  • End all lines with a semi-colon.
  • For multiple, comma-separated selectors, place each selector on its own line.
  • Use js- prefixed classes for JavaScript hooks into the DOM, and never use these in CSS as per Slightly Obtrusive JavaSript
  • Avoid over-nesting CSS. Never nest more than 3 levels deep.
  • Use comments to explain "why" not "what" (Good: This requires a z-index in order to appear above mobile navigation. Bad: This is a thing which is always on top!)