mirror of
https://github.com/TryGhost/Ghost.git
synced 2024-12-26 20:34:02 +03:00
e19e91044d
refs #8221, closes #7688, refs #7558 🙇 Improve meta data publisher logo behaviour This is a follow-up PR for #8285. Reasons: The code changes of #8285 caused error messages when falling back to the default `favicon.ico`, as the `image-size` tool doesn't support `ico` files. This PR takes the logic to decide which logo needs to be listed in our schema into a new fn `blog_logo.js`. There we have now three decisions: 1. If we have a publication **logo**, we'll take that one 2. If we have no publication logo, but an **icon** we'll use this one. 3. If we have none of the above things, we fall back to our default `favicon.ico` Additional, we're hard coding image dimensions for whenever the logo is an `.ico` file and built and extra decision to not call `image-size` when the dimension are already given. I will create another follow-up PR, which checks the extension type for the file and offers it as a util. 🛠 Blog icon util refs #7688 Serve functionality around the blog icon in its own util: - getIconDimensions -> async function that takes the filepath of on ico file and returns its dimensions - isIcoImageType -> returns true if file has `.ico` extension - getIconType -> returns icon-type (`x-icon` or `png`) - getIconUrl -> returns the absolut or relativ URL for the favicon: `[subdirectory or not]favicon.[ico or png]` 📖 Get .ico sizes for meta data & logo improvement refs #7558 refs #8221 Use the new `blogIconUtil` in meta data to fetch the dimensions of `.ico` files. Improvements for `publisher.logo`: We're now returning a hard-coded 'faked' image dimensions value to render an `imageObject` and prevent error our schema (Google structured data). As soon as an image (`.ico` or non-`.ico`) is too large, but - in case of non-`.ico` - a square format, be set the image-dimensions to 60px width and height. This reduces the chances of getting constantly error messages from Googles' webmaster tools. - add getIconPath util |
||
|---|---|---|
| .. | ||
| api | ||
| auth | ||
| config | ||
| controllers/frontend | ||
| metadata | ||
| middleware | ||
| models/base | ||
| models_plugins | ||
| scheduling | ||
| server_helpers | ||
| sitemap | ||
| storage | ||
| themes | ||
| utils | ||
| admin_spec.js | ||
| api_utils_spec.js | ||
| apps_filters_spec.js | ||
| apps_spec.js | ||
| errors_spec.js | ||
| exporter_spec.js | ||
| filters_spec.js | ||
| ghost_url_spec.js | ||
| importer_spec.js | ||
| migration_fixture_utils_spec.js | ||
| migration_spec.js | ||
| permissions_spec.js | ||
| rss_spec.js | ||
| server_helpers_index_spec.js | ||
| server_helpers_template_spec.js | ||
| server_utils_spec.js | ||
| showdown_client_integrated_spec.js | ||
| slack_spec.js | ||
| social-urls_spec.js | ||
| utils_pipeline_spec.js | ||
| validation_spec.js | ||
| xmlrpc_spec.js | ||