mirror of
https://github.com/TryGhost/Ghost.git
synced 2024-12-24 19:33:02 +03:00
ef0b863c2b
closes https://github.com/TryGhost/Team/issues/3073 Fixed validation error when creating 0% offer. Issue was occurring due to a falsy check on the offer value. Have resolved by having a more strict check on the offer value based on the possible empty value it can be - If creating a new offer without providing an offer value, the value will be `undefined`. If supplying an offer value, then removing the offer value, the value will be an empty string. This check prevents `0` being classed as an invalid value.
78 lines
2.5 KiB
JavaScript
78 lines
2.5 KiB
JavaScript
import BaseValidator from './base';
|
|
import validator from 'validator';
|
|
|
|
export default BaseValidator.create({
|
|
properties: ['name', 'amount', 'displayTitle', 'displayDescription', 'code', 'durationInMonths'],
|
|
|
|
name(model) {
|
|
if (!model.name) {
|
|
model.errors.add('name', 'Please enter a name.');
|
|
this.invalidate();
|
|
}
|
|
if (!validator.isLength(model.name || '', 0, 40)) {
|
|
model.errors.add('name', 'Name cannot be longer than 40 characters.');
|
|
this.invalidate();
|
|
}
|
|
},
|
|
|
|
amount(model) {
|
|
if (model.amount === '' || model.amount === undefined) {
|
|
model.errors.add('amount', 'Please enter the amount.');
|
|
|
|
return this.invalidate();
|
|
}
|
|
|
|
if (model.type === 'trial') {
|
|
if (model.amount < 1) {
|
|
model.errors.add('amount', 'Free trial must be at least 1 day.');
|
|
return this.invalidate();
|
|
}
|
|
|
|
if (!model.amount.toString().match(/^\d+$/)) {
|
|
model.errors.add('amount', 'Trial days must be a whole number.');
|
|
return this.invalidate();
|
|
}
|
|
}
|
|
|
|
if (model.type === 'percent') {
|
|
if (model.amount < 0 || model.amount > 100) {
|
|
model.errors.add('amount', 'Amount must be between 0 and 100%.');
|
|
return this.invalidate();
|
|
}
|
|
|
|
if (!model.amount.toString().match(/^\d+$/)) {
|
|
model.errors.add('amount', 'Amount must be a whole number.');
|
|
return this.invalidate();
|
|
}
|
|
}
|
|
|
|
if (model.type === 'fixed') {
|
|
if (model.amount < 0) {
|
|
model.errors.add('amount', 'Amount must be greater than 0.');
|
|
return this.invalidate();
|
|
}
|
|
}
|
|
},
|
|
|
|
displayDescription(model) {
|
|
if (!validator.isLength(model.displayDescription || '', 0, 191)) {
|
|
model.errors.add('displayDescription', 'Display description cannot be longer than 191 characters.');
|
|
this.invalidate();
|
|
}
|
|
},
|
|
|
|
durationInMonths(model) {
|
|
if (model.duration === 'repeating' && !model.durationInMonths) {
|
|
model.errors.add('durationInMonths', 'Please enter the duration in months.');
|
|
this.invalidate();
|
|
}
|
|
},
|
|
|
|
code(model) {
|
|
if (!model.code) {
|
|
model.errors.add('code', 'Please enter an offer code.');
|
|
this.invalidate();
|
|
}
|
|
}
|
|
});
|