TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-12-26 04:13:30 +03:00
Code Issues Projects Releases Wiki Activity
f83d51c1e3
Ghost/ghost/oembed-service
History
Peter Zimon 8f3617aaa8
Content card design improvements (#19737) 
refs. https://linear.app/tryghost/issue/DES-122/bookmark-card-issues

This PR addresses the following content card related problems:

1. The design of the following cards are more self-contained so it makes
more sense to use `px` for their font-sizes and spacings so it looks the
same regardless of the theme. Of course themes still can override these
values.

Updated cards to use `px` for font sizing:
- audio
- bookmark
- file
- product

2. So far header and signup cards had been using `rem` for font-sizes
and some sizing. This commit updates these to use `em` instead so that
it's consistent with all other cards.

3. The favicon sometimes is not available for bookmark cards. This PR also
fixes that by providing a default favicon for these cases.
2024-02-29 17:09:34 +01:00
..
lib Content card design improvements (#19737) 2024-02-29 17:09:34 +01:00
test Updated to use assert/strict everywhere (#17047) 2023-06-21 09:56:59 +01:00
.eslintrc.js Extracted oembed service to separate package 2022-08-15 10:07:06 +02:00
index.js Added eslint rule for file naming convention 2023-05-09 12:34:34 -04:00
package.json Update metascraper to v5.42.0 2023-12-18 09:41:00 +00:00
README.md Extracted oembed service to separate package 2022-08-15 10:07:06 +02:00

README.md

Oembed Service

Oembed service for Ghost

Usage

Develop

This is a monorepo package.

Follow the instructions for the top-level repo.

  1. git clone this repo & cd into it as usual
  2. Run yarn to install top-level dependencies.

Test

  • yarn lint run just eslint
  • yarn test run lint and tests