mirror of
https://github.com/TryGhost/Ghost.git
synced 2024-12-19 00:11:49 +03:00
6161f94910
refs: https://github.com/TryGhost/Toolbox/issues/595 We're rolling out new rules around the node assert library, the first of which is enforcing the use of assert/strict. This means we don't need to use the strict version of methods, as the standard version will work that way by default. This caught some gotchas in our existing usage of assert where the lack of strict mode had unexpected results: - Url matching needs to be done on `url.href` seeaa58b354a4
- Null and undefined are not the same thing, there were a few cases of this being confused - Particularly questionable changes in [PostExporter tests](c1a468744b
) tracked [here](https://github.com/TryGhost/Team/issues/3505). - A typo seeeaac9c293a
Moving forward, using assert strict should help us to catch unexpected behaviour, particularly around nulls and undefineds during implementation.
103 lines
2.8 KiB
JavaScript
103 lines
2.8 KiB
JavaScript
const DomainEvents = require('../');
|
|
const assert = require('assert/strict');
|
|
const sinon = require('sinon');
|
|
const logging = require('@tryghost/logging');
|
|
|
|
class TestEvent {
|
|
/**
|
|
* @param {string} message
|
|
*/
|
|
constructor(message) {
|
|
this.timestamp = new Date();
|
|
this.data = {
|
|
message
|
|
};
|
|
}
|
|
}
|
|
|
|
const sleep = ms => new Promise((resolve) => {
|
|
setTimeout(resolve, ms);
|
|
});
|
|
|
|
describe('DomainEvents', function () {
|
|
afterEach(function () {
|
|
sinon.restore();
|
|
DomainEvents.ee.removeAllListeners();
|
|
});
|
|
|
|
it('Will call multiple subscribers with the event when it is dispatched', async function () {
|
|
const event = new TestEvent('Hello, world!');
|
|
|
|
let events = [];
|
|
|
|
/**
|
|
* @param {TestEvent} receivedEvent
|
|
*/
|
|
function handler1(receivedEvent) {
|
|
// Do not add assertions here, they are caught by DomainEvents
|
|
events.push(receivedEvent);
|
|
}
|
|
|
|
/**
|
|
* @param {TestEvent} receivedEvent
|
|
*/
|
|
function handler2(receivedEvent) {
|
|
// Do not add assertions here, they are caught by DomainEvents
|
|
events.push(receivedEvent);
|
|
}
|
|
|
|
DomainEvents.subscribe(TestEvent, handler1);
|
|
DomainEvents.subscribe(TestEvent, handler2);
|
|
|
|
DomainEvents.dispatch(event);
|
|
await DomainEvents.allSettled();
|
|
|
|
assert.equal(events.length, 2);
|
|
assert.equal(events[0], event);
|
|
assert.equal(events[1], event);
|
|
});
|
|
|
|
it('Catches async errors in handlers', async function () {
|
|
const event = new TestEvent('Hello, world!');
|
|
|
|
const stub = sinon.stub(logging, 'error').returns();
|
|
|
|
/**
|
|
* @param {TestEvent} receivedEvent
|
|
*/
|
|
async function handler1() {
|
|
await sleep(10);
|
|
throw new Error('Test error');
|
|
}
|
|
|
|
DomainEvents.subscribe(TestEvent, handler1);
|
|
|
|
DomainEvents.dispatch(event);
|
|
await DomainEvents.allSettled();
|
|
assert.equal(stub.calledTwice, true);
|
|
});
|
|
|
|
describe('allSettled', function () {
|
|
it('Resolves when there are no events', async function () {
|
|
await DomainEvents.allSettled();
|
|
assert(true);
|
|
});
|
|
|
|
it('Waits for all listeners', async function () {
|
|
let counter = 0;
|
|
DomainEvents.subscribe(TestEvent, async () => {
|
|
await sleep(20);
|
|
counter += 1;
|
|
});
|
|
DomainEvents.subscribe(TestEvent, async () => {
|
|
await sleep(40);
|
|
counter += 1;
|
|
});
|
|
|
|
DomainEvents.dispatch(new TestEvent('Hello, world!'));
|
|
await DomainEvents.allSettled();
|
|
assert.equal(counter, 2);
|
|
});
|
|
});
|
|
});
|