Ghost/ghost/admin/app
Fixer fc706d1c02 Additional check of privacy.useGravatar for gh-profile-image component (#761)
closes TryGhost/Ghost#8612

* Additional check of privacy.useGravatar for gh-profile-image component
- added a check for privacy.useGravatar flag
- checked: tests are OK

* fix other issues in gh-profile-image
- we had CPs with side-effects 🤢
  - replace CP with basic properties that can be set within the component
  - use `didReceiveAttrs` and `ember-concurrency` to debounce changes to the email property and make the functionality easier to reason about
- fix the broken fade-in animation when the avatar changes
- fix tests - `.to.be.blank` was always returning true, replaced with `to.be.empty` which caused the tests to fail properly then replaced them with the expectations for the actual values
2017-07-06 16:33:15 +07:00
..
adapters 💄🐷 sort-imports eslint rule (#712) 2017-05-29 20:50:03 +02:00
authenticators 💄🐷 sort-imports eslint rule (#712) 2017-05-29 20:50:03 +02:00
authorizers deps: ember-simple-auth@1.0.0 2015-10-18 13:17:02 -05:00
components Additional check of privacy.useGravatar for gh-profile-image component (#761) 2017-07-06 16:33:15 +07:00
controllers 💅🏼 Imprve theme activation error messages (#756) 2017-06-22 19:19:01 +02:00
helpers 💄🐷 sort-imports eslint rule (#712) 2017-05-29 20:50:03 +02:00
html Style updates to new app frame for all other screens 2017-02-17 10:14:16 +00:00
initializers 💄🐷 sort-imports eslint rule (#712) 2017-05-29 20:50:03 +02:00
instance-initializers convert ember imports to ember-cli-shim imports where possible (#95) 2016-06-30 11:21:47 +01:00
mixins Revert "always give editor content focus by default (#748)" (#755) 2017-06-21 18:28:29 +07:00
models 🐛 Add conditional to fix post scheduling (#760) 2017-06-23 07:13:54 +02:00
routes Revert "always give editor content focus by default (#748)" (#755) 2017-06-21 18:28:29 +07:00
serializers 💄🐷 sort-imports eslint rule (#712) 2017-05-29 20:50:03 +02:00
services New tour styles 2017-06-12 21:50:17 +01:00
session-stores Update code to match eslint rules 2016-11-14 13:26:00 +00:00
styles 💅🏼 Set width of searchinput to 100% (#764) 2017-06-29 09:54:55 +02:00
templates Additional check of privacy.useGravatar for gh-profile-image component (#761) 2017-07-06 16:33:15 +07:00
torii-providers 💄🐷 sort-imports eslint rule (#712) 2017-05-29 20:50:03 +02:00
transforms 💄🐷 sort-imports eslint rule (#712) 2017-05-29 20:50:03 +02:00
utils ctrl/cmd-shift-i triggers image file dialog (#750) 2017-06-22 13:02:38 +01:00
validators 🗜 Database soft limits (#683) 2017-05-15 13:58:32 +02:00
_config.yml The great migration (EAK -> ember-cli) 2015-03-11 12:37:41 -06:00
app.js 💄🐷 sort-imports eslint rule (#712) 2017-05-29 20:50:03 +02:00
index.html 🤡 Serve own admin favicon (#619) 2017-04-06 17:28:51 +01:00
README.md Convert Sass to Myth 2015-05-22 19:05:09 +01:00
resolver.js deps: ember-cli@2.3.0 2016-02-16 12:32:48 -06:00
router.js 💄🐷 sort-imports eslint rule (#712) 2017-05-29 20:50:03 +02:00
transitions.js welcome tour (#527) 2017-06-08 22:00:10 +07:00

Ghost Admin Client

Ember.js application used as a client-side admin for the Ghost blogging platform. This readme is a work in progress guide aimed at explaining the specific nuances of the Ghost Ember app to contributors whose main focus is on this side of things.

CSS

We use pure CSS, which is pre-processed for backwards compatibility by Myth. We do not follow any strict CSS framework, however our general style is pretty similar to BEM.

Styles are primarily broken up into 4 main categories:

  • Patterns - are base level visual styles for HTML elements (eg. Buttons)
  • Components - are groups of patterns used to create a UI component (eg. Modals)
  • Layouts - are groups of components used to create application screens (eg. Settings)

All of these separate files are subsequently imported and compiled in app.css.

Front End Standards

  • 4 spaces for HTML & CSS indentation. Never tabs.
  • Double quotes only, never single quotes.
  • Use tags and elements appropriate for an HTML5 doctype (including self-closing tags)
  • Adhere to the Recess CSS property order.
  • Always a space after a property's colon (.e.g, display: block; and not display:block;).
  • End all lines with a semi-colon.
  • For multiple, comma-separated selectors, place each selector on its own line.
  • Use js- prefixed classes for JavaScript hooks into the DOM, and never use these in CSS as per Slightly Obtrusive JavaSript
  • Avoid over-nesting CSS. Never nest more than 3 levels deep.
  • Use comments to explain "why" not "what" (Good: This requires a z-index in order to appear above mobile navigation. Bad: This is a thing which is always on top!)