Ghost/core/test/unit/api/oembed_spec.js
Kevin Ansfield cfd9ff3993 🎨 Koenig - Added support for shortened URLs in embed card (#9781)
refs https://github.com/TryGhost/Ghost/issues/9724

- perform a HEAD request on a url if we don't find a matching provider, following any redirects until we hit success response before looking up providers for the resulting url
2018-08-12 15:57:19 +02:00

114 lines
4.3 KiB
JavaScript

const common = require('../../../server/lib/common');
const nock = require('nock');
const OembedAPI = require('../../../server/api/oembed');
const should = require('should');
describe('API: oembed', function () {
describe('fn: read', function () {
// https://oembed.com/providers.json only has schemes for https://reddit.com
it('finds match for unlisted http scheme', function (done) {
let requestMock = nock('https://www.reddit.com')
.get('/oembed')
.query(true)
.reply(200, {
html: 'test'
});
OembedAPI.read({url: 'http://www.reddit.com/r/pics/comments/8qi5oq/breathtaking_picture_of_jupiter_with_its_moon_io/'})
.then((results) => {
should.exist(results);
should.exist(results.html);
done();
}).catch(done);
});
it('finds match for schema-less urls', function (done) {
let requestMock = nock('https://www.reddit.com')
.get('/oembed')
.query(true)
.reply(200, {
html: 'test'
});
OembedAPI.read({url: '//www.reddit.com/r/pics/comments/8qi5oq/breathtaking_picture_of_jupiter_with_its_moon_io/'})
.then((results) => {
requestMock.isDone().should.be.true;
should.exist(results);
should.exist(results.html);
done();
}).catch(done);
});
it('follows redirects to get base url', function (done) {
let redirectMock = nock('https://youtu.be')
.intercept('/yHohwmrxrto', 'HEAD')
.reply(302, undefined, {
// eslint-disable-next-line
'Location': 'https://www.youtube.com/watch?v=yHohwmrxrto&feature=youtu.be'
});
let videoMock = nock('https://www.youtube.com')
.intercept('/watch', 'HEAD')
.query({v: 'yHohwmrxrto', feature: 'youtu.be'})
.reply(200);
let requestMock = nock('https://www.youtube.com')
.get('/oembed')
.query(true)
.reply(200, {
html: 'test'
});
OembedAPI.read({url: 'https://youtu.be/yHohwmrxrto'})
.then((results) => {
redirectMock.isDone().should.be.true;
videoMock.isDone().should.be.true;
requestMock.isDone().should.be.true;
should.exist(results);
should.exist(results.html);
results.html.should.eql('test');
done();
}).catch(done);
});
it('returns error for missing url', function (done) {
OembedAPI.read({url: ''})
.then(() => {
done(new Error('Fetch oembed without url should error'));
}).catch((err) => {
(err instanceof common.errors.BadRequestError).should.eql(true);
done();
});
});
it('returns error for unsupported provider', function (done) {
nock('http://example.com')
.intercept('/unknown', 'HEAD')
.reply(200);
OembedAPI.read({url: 'http://example.com/unknown'})
.then(() => {
done(new Error('Fetch oembed with unknown url provider should error'));
}).catch((err) => {
(err instanceof common.errors.ValidationError).should.eql(true);
done();
});
});
it('returns error for fetch failure', function (done) {
let requestMock = nock('https://www.youtube.com')
.get('/oembed')
.query(true)
.reply(500);
OembedAPI.read({url: 'https://www.youtube.com/watch?v=E5yFcdPAGv0'})
.then(() => {
done(new Error('Fetch oembed with external failure should error'));
}).catch((err) => {
(err instanceof common.errors.InternalServerError).should.eql(true);
done();
});
});
});
});