mirror of
https://github.com/TryGhost/Ghost.git
synced 2024-12-23 02:41:50 +03:00
b392d1925a
refs #9601 ### Dynamic Routing This is the beta version of dynamic routing. - we had a initial implementation of "channels" available in the codebase - we have removed and moved this implementation - there is now a centralised place for dynamic routing - server/services/routing - each routing component is represented by a router type e.g. collections, routes, static pages, taxonomies, rss, preview of posts - keep as much as possible logic of routing helpers, middlewares and controllers - ensure test coverage - connect all the things together - yaml file + validation - routing + routers - url service - sitemaps - url access - deeper implementation of yaml validations - e.g. hard require slashes - ensure routing hierarchy/order - e.g. you enable the subscriber app - you have a custom static page, which lives under the same slug /subscribe - static pages are stronger than apps - e.g. the first collection owns the post it has filtered - a post cannot live in two collections - ensure apps are still working and hook into the routers layer (or better said: and register in the routing service) - put as much as possible comments to the code base for better understanding - ensure a clean debug log - ensure we can unmount routes - e.g. you have a collection permalink of /:slug/ represented by {globals.permalink} - and you change the permalink in the admin to dated permalink - the express route get's refreshed from /:slug/ to /:year/:month/:day/:slug/ - unmount without server restart, yey - ensure we are backwards compatible - e.g. render home.hbs for collection index if collection route is / - ensure you can access your configured permalink from the settings table with {globals.permalink} ### Render 503 if url service did not finish - return 503 if the url service has not finished generating the resource urls ### Rewrite sitemaps - we have rewritten the sitemaps "service", because the url generator does no longer happen on runtime - we generate all urls on bootstrap - the sitemaps service will consume created resource and router urls - these urls will be shown on the xml pages - we listen on url events - we listen on router events - we no longer have to fetch the resources, which is nice - the urlservice pre-fetches resources and emits their urls - the urlservice is the only component who knows which urls are valid - i made some ES6 adaptions - we keep the caching logic -> only regenerate xml if there is a change - updated tests - checked test coverage (100%) ### Re-work usage of Url utility - replace all usages of `urlService.utils.urlFor` by `urlService.getByResourceId` - only for resources e.g. post, author, tag - this is important, because with dynamic routing we no longer create static urls based on the settings permalink on runtime - adapt url utility - adapt tests
58 lines
2.2 KiB
JavaScript
58 lines
2.2 KiB
JavaScript
const _ = require('lodash'),
|
|
debug = require('ghost-ignition').debug('services:routing:controllers:rss'),
|
|
url = require('url'),
|
|
common = require('../../../lib/common'),
|
|
security = require('../../../lib/security'),
|
|
settingsCache = require('../../settings/cache'),
|
|
rssService = require('../../rss'),
|
|
helpers = require('../helpers');
|
|
|
|
// @TODO: is this the right logic? move to UrlService utils
|
|
function getBaseUrlForRSSReq(originalUrl, pageParam) {
|
|
return url.parse(originalUrl).pathname.replace(new RegExp('/' + pageParam + '/$'), '/');
|
|
}
|
|
|
|
// @TODO: is this really correct? Should we be using meta data title?
|
|
function getTitle(relatedData) {
|
|
relatedData = relatedData || {};
|
|
var titleStart = _.get(relatedData, 'author[0].name') || _.get(relatedData, 'tag[0].name') || '';
|
|
|
|
titleStart += titleStart ? ' - ' : '';
|
|
return titleStart + settingsCache.get('title');
|
|
}
|
|
|
|
// @TODO: the collection controller does almost the same
|
|
module.exports = function rssController(req, res, next) {
|
|
debug('rssController');
|
|
|
|
const pathOptions = {
|
|
page: req.params.page !== undefined ? req.params.page : 1,
|
|
slug: req.params.slug ? security.string.safe(req.params.slug) : undefined
|
|
};
|
|
|
|
// CASE: we are using an rss cache - url must be normalised (without pagination)
|
|
// @TODO: this belongs to the rss service
|
|
const baseUrl = getBaseUrlForRSSReq(req.originalUrl, pathOptions.page);
|
|
|
|
helpers.fetchData(pathOptions, res.locals.routerOptions)
|
|
.then(function formatResult(result) {
|
|
const response = _.pick(result, ['posts', 'meta']);
|
|
|
|
response.title = getTitle(result.data);
|
|
response.description = settingsCache.get('description');
|
|
|
|
return response;
|
|
})
|
|
.then(function (data) {
|
|
// CASE: if requested page is greater than number of pages we have
|
|
if (pathOptions.page > data.meta.pagination.pages) {
|
|
return next(new common.errors.NotFoundError({
|
|
message: common.i18n.t('errors.errors.pageNotFound')
|
|
}));
|
|
}
|
|
|
|
return rssService.render(res, baseUrl, data);
|
|
})
|
|
.catch(helpers.handleError(next));
|
|
};
|