mirror of
https://github.com/TryGhost/Ghost.git
synced 2024-11-29 15:12:58 +03:00
b4cdc85a59
refs https://github.com/TryGhost/Ghost/issues/6949 Handle version mismatch errors by: - displaying an alert asking the user to copy any data and refresh - disabling navigation so that unsaved data is not accidentally lost Detailed changes: - add `error` action to application route for global route-based error handling - remove 404-handler mixin, move logic into app route error handler - update `.catch` in validation-engine so that promises are rejected with the original error objects - add `VersionMismatchError` and `isVersionMismatchError` to ajax service - add `upgrade-status` service - has a method to trigger the alert and toggle the "upgrade required" mode - is injected into all routes by default so that it can be checked before transitioning - add `Route` override - updates the `willTransition` hook to check the `upgrade-status` service and abort the transition if we're in "upgrade required" mode - update notifications `showAPIError` method to handle version mismatch errors - update any areas where we were catching ajax errors manually so that the version mismatch error handling is obeyed - fix redirect tests in editor acceptance test - fix mirage's handling of 404s for unknown posts in get post requests - adjust alert z-index to to appear above modal backgrounds
161 lines
5.8 KiB
JavaScript
161 lines
5.8 KiB
JavaScript
import Mixin from 'ember-metal/mixin';
|
|
import RSVP from 'rsvp';
|
|
import {A as emberA, isEmberArray} from 'ember-array/utils';
|
|
import DS from 'ember-data';
|
|
import Model from 'ember-data/model';
|
|
|
|
import InviteUserValidator from 'ghost-admin/validators/invite-user';
|
|
import NavItemValidator from 'ghost-admin/validators/nav-item';
|
|
import PostValidator from 'ghost-admin/validators/post';
|
|
import ResetValidator from 'ghost-admin/validators/reset';
|
|
import SettingValidator from 'ghost-admin/validators/setting';
|
|
import SetupValidator from 'ghost-admin/validators/setup';
|
|
import SigninValidator from 'ghost-admin/validators/signin';
|
|
import SignupValidator from 'ghost-admin/validators/signup';
|
|
import SlackIntegrationValidator from 'ghost-admin/validators/slack-integration';
|
|
import SubscriberValidator from 'ghost-admin/validators/subscriber';
|
|
import TagSettingsValidator from 'ghost-admin/validators/tag-settings';
|
|
import UserValidator from 'ghost-admin/validators/user';
|
|
|
|
import ValidatorExtensions from 'ghost-admin/utils/validator-extensions';
|
|
|
|
const {Errors} = DS;
|
|
|
|
// our extensions to the validator library
|
|
ValidatorExtensions.init();
|
|
|
|
/**
|
|
* The class that gets this mixin will receive these properties and functions.
|
|
* It will be able to validate any properties on itself (or the model it passes to validate())
|
|
* with the use of a declared validator.
|
|
*/
|
|
export default Mixin.create({
|
|
// these validators can be passed a model to validate when the class that
|
|
// mixes in the ValidationEngine declares a validationType equal to a key on this object.
|
|
// the model is either passed in via `this.validate({ model: object })`
|
|
// or by calling `this.validate()` without the model property.
|
|
// in that case the model will be the class that the ValidationEngine
|
|
// was mixed into, i.e. the controller or Ember Data model.
|
|
validators: {
|
|
inviteUser: InviteUserValidator,
|
|
navItem: NavItemValidator,
|
|
post: PostValidator,
|
|
reset: ResetValidator,
|
|
setting: SettingValidator,
|
|
setup: SetupValidator,
|
|
signin: SigninValidator,
|
|
signup: SignupValidator,
|
|
slackIntegration: SlackIntegrationValidator,
|
|
subscriber: SubscriberValidator,
|
|
tag: TagSettingsValidator,
|
|
user: UserValidator
|
|
},
|
|
|
|
// This adds the Errors object to the validation engine, and shouldn't affect
|
|
// ember-data models because they essentially use the same thing
|
|
errors: null,
|
|
|
|
// Store whether a property has been validated yet, so that we know whether or not
|
|
// to show error / success validation for a field
|
|
hasValidated: null,
|
|
|
|
init() {
|
|
this._super(...arguments);
|
|
this.set('errors', Errors.create());
|
|
this.set('hasValidated', emberA());
|
|
},
|
|
|
|
/**
|
|
* Passes the model to the validator specified by validationType.
|
|
* Returns a promise that will resolve if validation succeeds, and reject if not.
|
|
* Some options can be specified:
|
|
*
|
|
* `model: Object` - you can specify the model to be validated, rather than pass the default value of `this`,
|
|
* the class that mixes in this mixin.
|
|
*
|
|
* `property: String` - you can specify a specific property to validate. If
|
|
* no property is specified, the entire model will be
|
|
* validated
|
|
*/
|
|
validate(opts) {
|
|
let model = this;
|
|
let hasValidated,
|
|
type,
|
|
validator;
|
|
|
|
opts = opts || {};
|
|
|
|
if (opts.model) {
|
|
model = opts.model;
|
|
} else if (this instanceof Model) {
|
|
model = this;
|
|
} else if (this.get('model')) {
|
|
model = this.get('model');
|
|
}
|
|
|
|
type = this.get('validationType') || model.get('validationType');
|
|
validator = this.get(`validators.${type}`) || model.get(`validators.${type}`);
|
|
hasValidated = this.get('hasValidated');
|
|
|
|
opts.validationType = type;
|
|
|
|
return new RSVP.Promise((resolve, reject) => {
|
|
let passed;
|
|
|
|
if (!type || !validator) {
|
|
return reject([`The validator specified, "${type}", did not exist!`]);
|
|
}
|
|
|
|
if (opts.property) {
|
|
// If property isn't in `hasValidated`, add it to mark that this field can show a validation result
|
|
hasValidated.addObject(opts.property);
|
|
model.get('errors').remove(opts.property);
|
|
} else {
|
|
model.get('errors').clear();
|
|
}
|
|
|
|
passed = validator.check(model, opts.property);
|
|
|
|
return (passed) ? resolve() : reject();
|
|
});
|
|
},
|
|
|
|
/**
|
|
* The primary goal of this method is to override the `save` method on Ember Data models.
|
|
* This allows us to run validation before actually trying to save the model to the server.
|
|
* You can supply options to be passed into the `validate` method, since the ED `save` method takes no options.
|
|
*/
|
|
save(options) {
|
|
let {_super} = this;
|
|
|
|
options = options || {};
|
|
options.wasSave = true;
|
|
|
|
// model.destroyRecord() calls model.save() behind the scenes.
|
|
// in that case, we don't need validation checks or error propagation,
|
|
// because the model itself is being destroyed.
|
|
if (this.get('isDeleted')) {
|
|
return this._super(...arguments);
|
|
}
|
|
|
|
// If validation fails, reject with validation errors.
|
|
// If save to the server fails, reject with server response.
|
|
return this.validate(options).then(() => {
|
|
return _super.call(this, options);
|
|
}).catch((result) => {
|
|
// server save failed or validator type doesn't exist
|
|
if (result && !isEmberArray(result)) {
|
|
throw result;
|
|
}
|
|
|
|
return RSVP.reject(result);
|
|
});
|
|
},
|
|
|
|
actions: {
|
|
validate(property) {
|
|
this.validate({property});
|
|
}
|
|
}
|
|
});
|