From f69a331f57b4278dc04d731f2e884b631ae82d5c Mon Sep 17 00:00:00 2001
From: Jason Poon <85374+jpoon@users.noreply.github.com>
Date: Fri, 29 Nov 2019 09:53:09 -0800
Subject: [PATCH] upgrade to node v12 (#4171)

* docs: small updates to contributing

* upgrade docker image to node v12

* fix warning
---
 .github/CONTRIBUTING.md | 2 +-
 build/Dockerfile        | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md
index 95e81d089..0909b8114 100644
--- a/.github/CONTRIBUTING.md
+++ b/.github/CONTRIBUTING.md
@@ -25,7 +25,7 @@ When submitting a PR, please fill out the template that is presented by GitHub w
 
 1.  Install prerequisites:
     - latest [Visual Studio Code](https://code.visualstudio.com/)
-    - [Node.js](https://nodejs.org/) v8.0.0 or higher
+    - [Node.js](https://nodejs.org/) v12.0.0 or higher
     - _Optional_: [Docker Community Edition](https://store.docker.com/search?type=edition&offering=community) 🐋
 1.  In a terminal:
 
diff --git a/build/Dockerfile b/build/Dockerfile
index 7d34e243a..0b87626dd 100644
--- a/build/Dockerfile
+++ b/build/Dockerfile
@@ -1,9 +1,9 @@
-FROM node:10.15
+FROM node:12
 
 ARG DEBIAN_FRONTEND=noninteractive
 
 RUN apt-get update && \
-    apt-get install -y xorg xvfb libxss-dev libgtk-3-0 gconf2 libnss3 libasound2
+    apt-get install -y xorg xvfb libxss-dev libgtk-3-0 gconf2 libnss3 libasound2 libsecret-1-0
 
 ENV CXX="g++-4.9"
 ENV CC="gcc-4.9"