mirror of
https://github.com/Ylianst/MeshCentral.git
synced 2024-09-11 08:55:32 +03:00
If is user using 2FA the basic URL user and pass method fails.
https://github.com/Ylianst/MeshCentral/issues/4870 If user has 2FA enabled and tries to login with URL parameters then the login should fail.
This commit is contained in:
parent
53e2c5cf69
commit
3f0d9484b7
@ -2813,7 +2813,11 @@ module.exports.CreateWebServer = function (parent, db, args, certificates, doneF
|
|||||||
} else if (req.query.user && req.query.pass) {
|
} else if (req.query.user && req.query.pass) {
|
||||||
// User credentials are being passed in the URL. WARNING: Putting credentials in a URL is bad security... but people are requesting this option.
|
// User credentials are being passed in the URL. WARNING: Putting credentials in a URL is bad security... but people are requesting this option.
|
||||||
obj.authenticate(req.query.user, req.query.pass, domain, function (err, userid, passhint, loginOptions) {
|
obj.authenticate(req.query.user, req.query.pass, domain, function (err, userid, passhint, loginOptions) {
|
||||||
if ((userid != null) && (err == null)) {
|
// 2FA is not supported in URL authentication method. If user has 2FA enabled, this login method fails.
|
||||||
|
var user = obj.users[userid];
|
||||||
|
if (checkUserOneTimePasswordRequired(domain, user, req, loginOptions) == true) {
|
||||||
|
handleRootRequestEx(req, res, domain, direct);
|
||||||
|
} else if ((userid != null) && (err == null)) {
|
||||||
// Login success
|
// Login success
|
||||||
parent.debug('web', 'handleRootRequest: user/pass in URL auth ok.');
|
parent.debug('web', 'handleRootRequest: user/pass in URL auth ok.');
|
||||||
req.session.userid = userid;
|
req.session.userid = userid;
|
||||||
|
Loading…
Reference in New Issue
Block a user