a-b-street/abstreet
1
1
Fork 0
mirror of https://github.com/a-b-street/abstreet.git synced 2024-11-29 04:35:51 +03:00
Code Issues Projects Releases Wiki Activity

list possible easy simplifications in the geom validator plugin

Browse Source
This commit is contained in:
Dustin Carlino 2019-01-16 12:19:56 -08:00
parent 52fccbf547
commit 802cf333b8
1 changed files with 71 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

71
editor/src/plugins/debug/geom_validation.rs
View File

@ -6,6 +6,8 @@ use generator::done;
use geo;
use geo::prelude::Intersects;
use geom::Polygon;
use map_model::{LaneType, Map, RoadID};
use std::collections::BTreeSet;
// Eventually this should be part of an interactive map fixing pipeline. Find problems, jump to
// them, ask for the resolution, record it.
@ -17,6 +19,8 @@ pub struct Validator {
impl Validator {
pub fn new(ctx: &mut PluginCtx) -> Option<Validator> {
if ctx.input.action_chosen("validate map geometry") {
// TODO Kinda temporarily stuck here for convenience
list_problems(&ctx.primary.map);
return Some(Validator::start(&ctx.primary.draw_map));
}
None
@ -120,3 +124,70 @@ fn make_polys(p: &Polygon) -> Vec<geo::Polygon<f64>> {
}
result
}
fn list_problems(map: &Map) {
for i in map.all_intersections() {
if !i.is_degenerate() {
continue;
}
let road_ids: Vec<RoadID> = i.roads.iter().cloned().collect();
let r1 = map.get_r(road_ids[0]);
let r2 = map.get_r(road_ids[1]);
if r1
.incoming_lanes(i.id)
.iter()
.map(|(_, lt)| *lt)
.collect::<Vec<LaneType>>()
!= r2
.outgoing_lanes(i.id)
.iter()
.map(|(_, lt)| *lt)
.collect::<Vec<LaneType>>()
{
continue;
}
if r1
.outgoing_lanes(i.id)
.iter()
.map(|(_, lt)| *lt)
.collect::<Vec<LaneType>>()
!= r2
.incoming_lanes(i.id)
.iter()
.map(|(_, lt)| *lt)
.collect::<Vec<LaneType>>()
{
continue;
}
error!(
"{} may be collapsible. OSM ways {} vs {}",
i.id, r1.osm_way_id, r2.osm_way_id
);
let tags1: BTreeSet<(&String, &String)> = r1.osm_tags.iter().collect();
let tags2: BTreeSet<(&String, &String)> = r2.osm_tags.iter().collect();
let common = tags1.intersection(&tags2).cloned().collect();
for (k, v) in tags1.difference(&common) {
if k.starts_with("tiger:")
|| k.starts_with("old_name:")
|| k.starts_with("destination")
|| k == &"source"
{
continue;
}
error!(" only {} has: {} = {}", r1.id, k, v);
}
for (k, v) in tags2.difference(&common) {
if k.starts_with("tiger:")
|| k.starts_with("old_name:")
|| k.starts_with("destination")
|| k == &"source"
{
continue;
}
error!(" only {} has: {} = {}", r2.id, k, v);
}
}
}