a-b-street/abstreet
1
1
Fork 0
mirror of https://github.com/a-b-street/abstreet.git synced 2024-12-24 23:15:24 +03:00
Code Issues Projects Releases Wiki Activity

Code review: prefer unreachable to todo for checkins

Browse Source
This commit is contained in:
Michael Kirk 2021-03-19 11:05:03 -07:00 committed by Dustin Carlino
parent 3d5876a4fd
commit 9a2276c66d
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
game/src/sandbox/dashboards/trip_table.rs
View File

@ -139,7 +139,7 @@ impl State<App> for TripTable {
} else if self.table_tabs.handle_action(ctx, &x, &mut self.panel) {
// if true, tabs handled the action
} else {
todo!("unhandled action: {}", x)
unreachable!("unhandled action: {}", x)
}
}
Outcome::Changed => {

2
game/src/sandbox/time_warp.rs
View File

@ -168,7 +168,7 @@ impl State<App> for JumpToTime {
if self.tabs.handle_action(ctx, action, &mut self.panel) {
// if true, tabs has handled the action
} else {
todo!("handle action: {}", action)
unreachable!("unhandled action: {}", action)
}
}
},