a-b-street/abstreet
1
1
Fork 0
mirror of https://github.com/a-b-street/abstreet.git synced 2024-12-29 17:34:58 +03:00
Code Issues Projects Releases Wiki Activity

removes position enum, abstracts the way we assign text to waypoint icons, and cleans up syntax noise

Browse Source
This commit is contained in:
Gedalia Kott 2021-09-18 12:45:04 -07:00 committed by Dustin Carlino
parent dc5398fa14
commit a851b1e52d
1 changed files with 21 additions and 41 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

62
game/src/common/waypoints.rs
View File

@ -29,6 +29,10 @@ struct Waypoint {
center: Pt2D,
}
fn get_waypoint_text(idx: usize) -> char {
char::from_u32('A' as u32 + idx as u32).unwrap()
}
impl InputWaypoints {
pub fn new(ctx: &mut EventCtx, app: &App) -> InputWaypoints {
let map = &app.primary.map;
@ -66,9 +70,9 @@ impl InputWaypoints {
let mut delete_buttons = Vec::new();
for (idx, waypt) in self.waypoints.iter().enumerate() {
let order = char::from_u32('A' as u32 + idx as u32).unwrap();
let text = get_waypoint_text(idx);
let icon = {
let text = Text::from(Line(order.to_string()).fg(Color::WHITE).bold_body());
let text = Text::from(Line(text).fg(Color::WHITE).bold_body());
let batch = text.render(ctx);
let bounds = batch.get_bounds();
let image = Image::from_batch(batch, bounds)
@ -187,11 +191,6 @@ impl InputWaypoints {
if let Some(x) = x.strip_prefix("delete waypoint ") {
let idx = x.parse::<usize>().unwrap();
self.waypoints.remove(idx);
// Recalculate labels, in case we deleted in the middle
for waypt in self.waypoints.iter_mut() {
*waypt = Waypoint::new(app, waypt.at);
}
self.update_waypoints_drawable(ctx);
return true;
} else {
@ -218,41 +217,28 @@ impl InputWaypoints {
fn get_waypoint_color(&self, idx: usize) -> Color {
let total_waypoints = self.waypoints.len();
let wp = {
match idx {
0 => WaypointPosition::Start,
idx if idx == total_waypoints - 1 => WaypointPosition::End,
// technically this includes the case where idx >= total_waypoints which should hopefully never happen
_ => WaypointPosition::Middle,
}
};
match wp {
WaypointPosition::Start => Color::GREEN,
WaypointPosition::End => Color::RED,
WaypointPosition::Middle => [Color::BLUE, Color::ORANGE, Color::PURPLE][idx % 3],
match idx {
0 => Color::GREEN,
idx if idx == total_waypoints - 1 => Color::RED,
// technically this includes the case where idx >= total_waypoints which should hopefully never happen
_ => [Color::BLUE, Color::ORANGE, Color::PURPLE][idx % 3],
}
}
fn update_waypoints_drawable(&mut self, ctx: &mut EventCtx) {
let mut batch = GeomBatch::new();
for (idx, waypt) in &mut self.waypoints.iter().enumerate() {
let geom = {
let color = self.get_waypoint_color(idx);
for (idx, waypt) in self.waypoints.iter().enumerate() {
let color = self.get_waypoint_color(idx);
let mut geom = GeomBatch::new();
let mut geom = GeomBatch::new();
geom.push(color, waypt.hitbox.clone());
let text = get_waypoint_text(idx);
geom.append(
Text::from(Line(format!("{}", text)).fg(Color::WHITE))
.render(ctx)
.centered_on(waypt.center),
);
geom.push(color, waypt.hitbox.clone());
let order = char::from_u32('A' as u32 + idx as u32).unwrap();
geom.append(
Text::from(Line(format!("{}", order)).fg(Color::WHITE))
.render(ctx)
.centered_on(waypt.center),
);
geom
};
batch.append(geom);
}
self.draw_waypoints = ctx.upload(batch);
@ -297,12 +283,6 @@ impl InputWaypoints {
}
}
enum WaypointPosition {
Start,
Middle,
End,
}
impl Waypoint {
fn new(app: &App, at: TripEndpoint) -> Waypoint {
let map = &app.primary.map;