WIP woops, found a bug with bike_reached_end

docs/design/code.md

@@ -118,3 +118,7 @@ necessary to plumb more log context anyway.
 At some point, geometry was a separate layer from the graph base-layer of
 map_model. That doesn't work -- we can't even reason about what turns logically
 exist without operating on cleaned-up geometry.
+
+## IDs
+
+Should LaneID have LaneType bundled in for convenience? CarID and VehicleType?

sim/src/driving.rs

@@ -584,6 +584,7 @@ impl DrivingSimState {
 
         let mut finished_parking: Vec<ParkedCar> = Vec::new();
         let mut vanished_at_border: Vec<CarID> = Vec::new();
+        // The lane is the where the bike ended, so NOT a sidewalk
         let mut done_biking: Vec<(CarID, LaneID, Distance)> = Vec::new();
 
         // Apply moves. Since lookahead behavior works, there are no conflicts to resolve, meaning

sim/src/sim.rs

@@ -192,10 +192,10 @@ impl Sim {
         for c in at_border {
             self.trips_state.car_reached_border(c, self.time);
         }
-        for (bike, lane, dist) in done_biking {
+        for (bike, last_lane, dist) in done_biking {
             // TODO push an event, backtrace, etc
             self.spawner
-                .bike_reached_end(self.time, bike, lane, dist, &mut self.trips_state);
+                .bike_reached_end(self.time, bike, last_lane, dist, &mut self.trips_state);
         }
 
         self.walking_state.populate_view(&mut view);

sim/src/spawn.rs

@@ -600,11 +600,12 @@ impl Spawner {
         &mut self,
         at: Tick,
         bike: CarID,
-        lane: LaneID,
+        last_lane: LaneID,
         dist: Distance,
         trips: &mut TripManager,
     ) {
         let (trip, ped, walk_to) = trips.bike_reached_end(bike);
+        // TODO last_lane is not the sidewalk, we need to look that up
         self.enqueue_command(Command::Walk(
             at.next(),
             trip,

sim/src/walking.rs

@@ -66,6 +66,7 @@ impl SidewalkSpot {
     }
 
     pub fn bike_rack(sidewalk: LaneID, dist_along: Distance) -> SidewalkSpot {
+        // TODO verify the thing passed in is a sidewalk!
         SidewalkSpot {
             connection: SidewalkPOI::BikeRack,
             sidewalk,