a-b-street/abstreet
1
1
Fork 0
mirror of https://github.com/a-b-street/abstreet.git synced 2024-11-27 15:03:20 +03:00
Code Issues Projects Releases Wiki Activity

clarify "time difference" chart

Browse Source 
- bar height represents accumulated time, not trip count
- buckets are from duration *before* edits
This commit is contained in:
Michael Kirk 2021-03-22 13:22:59 -07:00 committed by Dustin Carlino
parent 75b39c7b35
commit b6c5ee38c2
1 changed files with 9 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
game/src/sandbox/dashboards/summaries.rs
View File

@ -260,10 +260,12 @@ fn contingency_table(ctx: &mut EventCtx, app: &App, filter: &Filter) -> Widget {
if points.is_empty() {
return Widget::nothing();
}
// bucket by trip duration _before_ changes
let num_buckets = 10;
let (_, endpts) = points
.iter()
.map(|(b, a)| a.max(b))
.map(|(b, _a)| b)
.max()
.unwrap()
.make_intervals_for_max(num_buckets);
@ -271,7 +273,7 @@ fn contingency_table(ctx: &mut EventCtx, app: &App, filter: &Filter) -> Widget {
let mut batch = GeomBatch::new();
batch.autocrop_dims = false;
// Draw the X axis, time before changes in buckets.
// Draw the X axis
for (idx, mins) in endpts.iter().enumerate() {
batch.append(
Text::from(Line(mins.to_string()).secondary())
@ -303,6 +305,7 @@ fn contingency_table(ctx: &mut EventCtx, app: &App, filter: &Filter) -> Widget {
.take(num_buckets)
.collect();
for (b, a) in points {
// bucket by trip duration _before_ changes
let before_mins = b.num_minutes_rounded_up();
let raw_idx = endpts.iter().rev().position(|x| before_mins >= *x).unwrap();
let mut idx = endpts.len() - 1 - raw_idx;
@ -385,15 +388,15 @@ fn contingency_table(ctx: &mut EventCtx, app: &App, filter: &Filter) -> Widget {
Widget::col(vec![
Text::from_multiline(vec![
Line("Number of slower/faster trips").small_heading(),
Line("by ranges of trip time (after)").small_heading(),
Line("Time difference by trip length").small_heading(),
Line("Grouped by the length of the trip before your changes."),
])
.into_widget(ctx),
Line("number of trips (faster)")
Line("Total Time Saved (faster)")
.secondary()
.into_widget(ctx),
DrawWithTooltips::new(ctx, batch, tooltips, Box::new(|_| GeomBatch::new())),
Line("number of trips (slower)")
Line("Total Time Lost (slower)")
.secondary()
.into_widget(ctx),
])