a-b-street/abstreet
1
1
Fork 0
mirror of https://github.com/a-b-street/abstreet.git synced 2024-11-24 09:24:26 +03:00
Code Issues Projects Releases Wiki Activity

Don't assume an autocomplete widget will be consumed after a value is chosen. In particular, if the user types nonsense into the city picker and presses enter, don't crash.

Browse Source
This commit is contained in:
Dustin Carlino 2020-10-29 15:18:15 -07:00
parent 1707b6fe37
commit bb081bbd28
1 changed files with 5 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
widgetry/src/widgets/autocomplete.rs
View File

@ -88,8 +88,6 @@ impl<T: 'static + Clone> WidgetImpl for Autocomplete<T> {
}
fn event(&mut self, ctx: &mut EventCtx, output: &mut WidgetOutput) {
assert!(self.chosen_values.is_none());
self.tb.event(ctx, output);
if self.tb.get_line() != self.current_line {
self.current_line = self.tb.get_line();
@ -100,24 +98,23 @@ impl<T: 'static + Clone> WidgetImpl for Autocomplete<T> {
let mut tmp_output = WidgetOutput::new();
self.menu.event(ctx, &mut tmp_output);
if let Outcome::Clicked(ref choice) = tmp_output.outcome {
// Mutating choices is fine, because we're supposed to be consumed by the
// caller immediately after this.
if choice.starts_with("anything matching") {
let query = self.current_line.to_ascii_lowercase();
let mut matches = Vec::new();
for (name, choices) in self.choices.drain(..) {
for (name, choices) in &self.choices {
if name.to_ascii_lowercase().contains(&query) {
matches.extend(choices);
matches.extend(choices.clone());
}
}
self.chosen_values = Some(matches);
} else {
self.chosen_values = Some(
self.choices
.drain(..)
.iter()
.find(|(name, _)| name == choice)
.unwrap()
.1,
.1
.clone(),
);
}
}