Commit Graph

117 Commits

Author SHA1 Message Date
Dustin Carlino
d8e8ab76b6 Rename rat-run to shortcut in the user-visible part of the LTN tool.
"Rat-run" is a politicized term. It's helpful to be more neutral during
consultations.
2022-05-08 09:58:47 +01:00
Dustin Carlino
8de65419e6 Mechanical refactor in code from "rat run" to "shortcut" 2022-05-08 09:45:07 +01:00
Dustin Carlino
b4896ee450 Make untrimmed_road_geometry infalliable, in preparation for storing a
PolyLine instead of list of points.

This exposed two edge cases, fixed here:

1) While merging short roads near junctions, we sometimes create a loop.
   Filter it out immeditely.
2) If an OSM way is physically sharing geometry with another one
   invalidly, detect that and discard it much earlier.
2022-05-07 22:02:06 +01:00
Dustin Carlino
43c946a2b6 Fix crashing tutorial after Seattle OSM updates. #914 2022-05-07 15:20:42 +01:00
Dustin Carlino
596bd5d04d Problem plot per lane too, sadly mostly by copying code 2022-05-07 13:04:09 +01:00
Dustin Carlino
586ee1c96d Show live time-series of problems per intersection 2022-05-07 13:04:09 +01:00
Dustin Carlino
3426d2e917 Refactoring problem type code in preparation for new info panel tabs 2022-05-06 15:31:37 +01:00
Dustin Carlino
15111dcf9d Recalculate prebaked data for Seattle. I'm seeing a crash in the Arboretum and a diff in Montlake since the last update in 3d738e93e8. Not sure how things got out of sync -- possibly the S3 bug just synced. 2022-05-06 12:46:16 +01:00
Dustin Carlino
1325c45013 Change how the relative problems layer works. Color roads and
intersections, using the same technique as the relative throughput
layer. Add tooltips to show specific before/after counts. This is much
easier to understand than #905
2022-05-06 12:03:27 +01:00
Dustin Carlino
e66112b3ea Click trip problems to time-warp. Useful for debugging spurious diffs in greater detail 2022-05-03 16:08:22 +01:00
Dustin Carlino
0fd39db440 Fix crash when drawing problems before edits. Need to use the unedited map 2022-05-03 13:45:00 +01:00
Dustin Carlino
136eef3c3b Just rename center_points to osm_center_points to be more clear. https://github.com/a-b-street/osm2streets/issues/2 2022-05-01 21:33:44 +01:00
Dustin Carlino
f72dd62e56 Store lane_specs_ltr on RawRoad, instead of constantly recalculating. https://github.com/a-b-street/osm2streets/issues/2 2022-05-01 19:39:57 +01:00
Dustin Carlino
738f50f5b8 Prevent pedestrians from endlessly cutting off cars at a stop sign by
limiting how long a crowd can enter a crosswalk. #517

Removing Tehran from prebaking; it starts gridlocking. I didn't
investigate why; making SMP realistic unfortunately takes priority right
now.
2022-05-01 17:02:14 +01:00
Dustin Carlino
ae8d6f6cf2 Spinner widgets for distances are weird, because the step size probably shouldn't depend on the user's metric/imperial setting. Just flip the prior hack and always use meters for the spinners. Sorry not sorry USA users. 2022-04-30 15:32:24 +01:00
Dustin Carlino
aff8d8ceef Automatically change metric/imperial based on the map loaded. 2022-04-30 15:24:18 +01:00
Dustin Carlino
00c34ab8f6 Add proposed sidewalk widths for SMP, mapped by Gabriela.
Also add a little edit mode tool to auto-fix sidewalk direction, to
avoid a crash in pathfinding! We should enforce this eventually.
2022-04-30 15:00:51 +01:00
Dustin Carlino
19447b5a26 Create a layer to show where problems are occurring more or less. #859 2022-04-29 14:08:52 +01:00
Dustin Carlino
4b446c754e Make leader agents call ahead before starting a turn. Don't make use of
this yet. #517

Dump the intersection state to JSON too for the UI debugger, to inspect
easily.
2022-04-28 12:50:23 +01:00
Dustin Carlino
dff4e17b28 Let the user make edits to switch between marked/unmarked crosswalks! 2022-04-26 16:42:37 +01:00
Dustin Carlino
5890e600d3 Refactor pedestrian radius 2022-04-24 09:38:19 +01:00
Dustin Carlino
651a1f571a Slow down pedestrians when they're on a crowded sidewalk. #859 2022-04-23 21:18:26 +01:00
Dustin Carlino
9b4abae174 Fix a treachurous bug that was crashing the simulation, first uncovered
by chance in #870.

A vehicle exits a driveway and blocks a lane on its way out. When we try
to clear the static blockage, the queue calculation recurses to resolve
distances on the queue where that vehicle is entering. But since we
temporarily don't have the car in the list of cars (for the borrow
checker), it was crashing.

One of those "2 hours to figure out, 30 seconds to fix" bugs.
2022-04-23 20:03:28 +01:00
Michael Kirk
d76bb3fbbd update to geo 0.20.1 2022-04-22 18:13:36 +01:00
Dustin Carlino
8244a900cf Refactor constructors for RawRoad and RawIntersection. #893 2022-04-21 14:32:48 +01:00
Dustin Carlino
8a23b347e5
Save LTN proposals in a more future-proof format (#894) 2022-04-21 04:40:00 -07:00
Dustin Carlino
3aa711acf4 When you click a degenerate intersection in the LTN tool, still cycle through no filters or a filter on each of the adjoining roads. Otherwise there's unintuitive unclickable space. 2022-04-19 09:55:01 +01:00
Dustin Carlino
e66cb88c5d Rearrange intersection geometry code and start goldenfile tests to pick up changes. #846 2022-04-18 08:48:07 +01:00
Dustin Carlino
7b77b070a8 Draw diagonal filters the same as regular filters (with a circle and a line) 2022-04-17 17:19:34 +01:00
Dustin Carlino
832f02cad9 Always draw unzoomed LTN filters as a red circle with a white line, even
when very unzoomed
2022-04-17 17:19:34 +01:00
Dustin Carlino
237f00d1cc Centralize logic in TransitRoute::all_path_requests. Stop repeating it
in the sim transit layer. Simplify the sim transit state accordingly.

Along the way, temporarily sacrifice tracking the paths taken by transit
passengers -- it wasn't correct before.

Not regenerating maps yet.
2022-04-17 11:13:05 +01:00
Dustin Carlino
d386948a13 Import GTFS for São Paulo 2022-04-14 15:19:29 +01:00
Dustin Carlino
9ffab3c976 Don't use assemble_ltr outside of raw_map; it's one small complication to switching to osm2lanes for https://github.com/a-b-street/osm2lanes/issues/71 2022-04-14 09:41:18 +01:00
Dustin Carlino
914ee80a7c In the LTN route planner, draw waypoints on top of the routes 2022-04-12 16:16:30 +01:00
Dustin Carlino
1c05a99969 Try tracing paths more precisely along road edges, even with changing widths. Use in the experimental bus tool. It needs work, but solid start. 2022-04-04 19:12:00 +01:00
Dustin Carlino
6aa71539a5 Start mocking out a UI to sketch bus routes, showing people and places
nearby. Shove it in the 15m tool momentarily.

Also make the thresholds/colors for isochrones more configurable.
2022-03-30 15:56:37 +01:00
Dustin Carlino
d6dc4332b0 Make the LTN impact UI easier to see. Draw less stuff, only focus on roads with changes [rebuild] [release] 2022-03-28 11:13:17 +01:00
Dustin Carlino
33eac8cba8 Transition the old path debugger to using the split Pathfinder for
custom RoutingParams. #852
2022-03-26 09:39:54 +00:00
Dustin Carlino
2e4e11f6b0 Flesh out the UI for showing specific changed paths 2022-03-25 16:20:40 +00:00
Dustin Carlino
272408002f Ignore spurious changes in pathfinding for the LTN impact tool. #868 2022-03-25 13:15:33 +00:00
Dustin Carlino
1126972fdd For roads we predict to get more/less traffic from LTN interventions,
click them and explore specific routes.

UI needs plenty of work.

And the results show plenty of spurious changes not explained by new
filters.
2022-03-25 12:07:23 +00:00
Dustin Carlino
d0f0fcf611 Cache the custom pathfinders in the LTN impact tool. I had trouble with this previously, because it was exposing the RoutingParams bug just fixed. #852 2022-03-25 11:24:18 +00:00
Dustin Carlino
b0a6f16613 Use the correct time estimates in the LTN route planner; the slowdown factor for major roads is important! [rebuild] [release] 2022-03-23 11:08:48 +00:00
Dustin Carlino
c88f7bbc53 Display info about the 4 routes more consistently [rebuild] [release] 2022-03-23 10:47:01 +00:00
Dustin Carlino
1e07a148fa Show walking directions in the LTN tool as well. Start to tune all the route colors on the map 2022-03-23 09:58:10 +00:00
Dustin Carlino
696f010301 Restrict the LTN route planner to 2 waypoints. Too easy to accidentally click and add a third, and the route overlapping itself is a total mess. 2022-03-23 09:49:08 +00:00
Dustin Carlino
e5ea25ec58 Show biking directions in the LTN tool too
(Many UI problems)
2022-03-22 22:25:42 +00:00
Dustin Carlino
df82f54879 Cache custom pathfinders directly for the LTN route planning tool. #852 2022-03-22 22:25:42 +00:00
Dustin Carlino
3b664ea54e Give callers a way to create and use a Pathfinder directly, not storing
it as part of the Map. #852

This has an immediate use in the LTN rat run calculation -- share the
pathfinder across threads, avoid massive logspam.

There's a much larger refactor in another branch, but just starting with
this.
2022-03-21 12:58:20 +00:00
Dustin Carlino
1661957511 Just change the error message in the select boundary tool to emphasize it's probably not the user's fault 2022-03-21 12:28:37 +00:00