Typcheck imports before statements (#2253)

- closes #2248

src/Juvix/Compiler/Internal/Translation/FromInternal/Analysis/TypeChecking/Checker.hs

@@ -48,11 +48,16 @@ checkModuleNoCache ::
   Sem r Module
 checkModuleNoCache (ModuleIndex Module {..}) = do
   _moduleBody' <-
-    (evalState (mempty :: NegativeTypeParameters) . checkModuleBody) _moduleBody
+    evalState (mempty :: NegativeTypeParameters)
+      . checkModuleBody
+      $ _moduleBody
+  _moduleExamples <- mapM checkExample _moduleExamples
   return
     Module
       { _moduleBody = _moduleBody',
-        ..
+        _moduleName,
+        _moduleExamples,
+        _modulePragmas
       }
 
 checkModuleBody ::
@@ -60,8 +65,8 @@ checkModuleBody ::
   ModuleBody ->
   Sem r ModuleBody
 checkModuleBody ModuleBody {..} = do
-  _moduleStatements' <- mapM checkStatement _moduleStatements
   _moduleImports' <- mapM checkImport _moduleImports
+  _moduleStatements' <- mapM checkStatement _moduleStatements
   return
     ModuleBody
       { _moduleStatements = _moduleStatements',

src/Juvix/Compiler/Internal/Translation/FromInternal/Analysis/TypeChecking/Data/Inference.hs

@@ -422,7 +422,7 @@ addIdens idens = do
 functionDefEval :: forall r'. Member (State FunctionsTable) r' => FunctionDef -> Sem r' (Maybe Expression)
 functionDefEval = runFail . goTop
   where
-    goTop :: forall r. (Members '[Fail, State FunctionsTable] r) => FunctionDef -> Sem r Expression
+    goTop :: forall r. Members '[Fail, State FunctionsTable] r => FunctionDef -> Sem r Expression
     goTop f =
       case f ^. funDefClauses of
         c :| [] -> goClause c
@@ -458,7 +458,7 @@ functionDefEval = runFail . goTop
             go :: [(PatternArg, Expression)] -> Sem r Expression
             go = \case
               [] -> return (c ^. clauseBody)
-              ((p, ty) : ps)
+              (p, ty) : ps
                 | Implicit <- p ^. patternArgIsImplicit -> fail
                 | otherwise -> go ps >>= goPattern (p ^. patternArgPattern, ty)
 

test/Typecheck/Positive.hs

@@ -236,7 +236,11 @@ tests =
     posTest
       "Nested pattern match with type variables"
       $(mkRelDir ".")
-      $(mkRelFile "NestedPatterns.juvix")
+      $(mkRelFile "NestedPatterns.juvix"),
+    posTest
+      "issue2248: Import type alias"
+      $(mkRelDir "issue2248")
+      $(mkRelFile "Main.juvix")
   ]
     <> [ compilationTest t | t <- Compilation.tests
        ]

tests/positive/issue2248/Bug.juvix

@@ -0,0 +1,8 @@
+module Bug;
+
+type A := mkA : A;
+
+aliasA : Type;
+aliasA := A;
+
+type C := mkC : aliasA -> C;

tests/positive/issue2248/Main.juvix

@@ -0,0 +1,5 @@
+module Main;
+
+import Bug open;
+
+c : C := mkC mkA;

tests/positive/issue2248/juvix.yaml

@@ -0,0 +1,4 @@
+dependencies:
+- .juvix-build/stdlib/
+name: issue2248
+version: 0.0.0