mirror of
https://github.com/anoma/juvix.git
synced 2024-12-12 14:28:08 +03:00
1b30c75657
This PR replaces fetching a precompiled binary of smoke with a build/cache for macOS smoke tests on CI. smoke dynamically links to icu4c, so a cached binary of smoke will break when brew bumps the icu4c version. In this PR we use the icu4c version in the cache key of the smoke build to avoid this issue. NB: The smoke build cannot be done as a separate job because the smoke binary must be built using exactly the same version of the macos-12 runner image as the smoke testing step to make sure that the icu4c versions match. Motivation for doing this is this failure: https://github.com/anoma/juvix/actions/runs/5325094406/jobs/9645334642 which uses this release of the runner image https://github.com/actions/runner-images/releases/tag/macOS-12%2F20230618.1 which contains the updated brew version of icu4c. 20230618.1 is currently a prerelease, but will start to run on more jobs shortly. ``` 2023-06-20T17:10:13.2222310Z Copied executables to /Users/runner/.local/bin: 2023-06-20T17:10:13.2223440Z - juvix 2023-06-20T17:10:13.5312790Z dyld[90256]: Library not loaded: '/usr/local/opt/icu4c/lib/libicuuc.72.dylib' 2023-06-20T17:10:13.5331930Z Referenced from: '/Users/runner/hostedtoolcache/jonaprieto/smoke/latest/darwin-x64/smoke' 2023-06-20T17:10:13.5333610Z Reason: tried: '/usr/local/opt/icu4c/lib/libicuuc.72.dylib' (no such file), '/usr/local/lib/libicuuc.72.dylib' (no such file), '/usr/lib/libicuuc.72.dylib' (no such file), '/usr/local/Cellar/icu4c/73.2/lib/libicuuc.72.dylib' (no such file), '/usr/local/lib/libicuuc.72.dylib' (no such file), '/usr/lib/libicuuc.72.dylib' (no such file) 2023-06-20T17:10:13.5334690Z make[1]: *** [smoke-only] Abort trap: 6 2023-06-20T17:10:13.5335310Z make: *** [smoke] Error 2 2023-06-20T17:10:13.5363170Z ##[error]Process completed with exit code 2. ``` |
||
|---|---|---|
| .. | ||
| ISSUE_TEMPLATE | ||
| workflows | ||
| pull_request_template.md | ||